Re: [PATCH] D16396: Warn if variable cannot be implicitly instantiated

rsmith added a comment. I would prefer to avoid adding the `%qt` format if we can. But if we do provide it, the template parameter names we use should match what was written in the declaration of the template itself. Comment at: lib/AST/Decl.cpp:1423 @@ +1422,3 @@ +/// +/// is

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

bader added a comment. LGTM http://reviews.llvm.org/D19071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

rsmith added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaType.cpp:2163-2165 @@ -2161,3 +2162,5 @@ if (!T->isDependentType() && isCompleteType(Loc, BaseT) && - !BaseT.isPODType(Context) && !BaseT->isObjCLifetimeType()) { + RD && !RD->hasDefau

r266245 - [SemaObjC] Properly handle mix between type arguments and protocols.

Author: bruno Date: Wed Apr 13 15:59:07 2016 New Revision: 266245 URL: http://llvm.org/viewvc/llvm-project?rev=266245&view=rev Log: [SemaObjC] Properly handle mix between type arguments and protocols. Under certain conditions clang currently fails to properly diagnostic ObjectC parameter list whe

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno closed this revision. bruno added a comment. Committed r266245 http://reviews.llvm.org/D18997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19074: [CUDA] removed unneeded __nvvm_reflect_anchor()

tra created this revision. tra added reviewers: jlebar, majnemer. tra added a subscriber: cfe-commits. Since r265060 LLVM infers correct __nvvm_reflect attributes. http://reviews.llvm.org/D19074 Files: lib/Headers/__clang_cuda_runtime_wrapper.h Index: lib/Headers/__clang_cuda_runtime_wrappe

Re: r266178 - constexpr -> const to appease MSVC bots.

Thanks! -- Sean Silva On Wed, Apr 13, 2016 at 12:47 AM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Wed Apr 13 02:47:38 2016 > New Revision: 266178 > > URL: http://llvm.org/viewvc/llvm-project?rev=266178&view=rev > Log: > constexpr -> const to appe

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu added a comment. ping. The currently -fembed-bitcode option is only half working. I don't want to leave it like that too long. http://reviews.llvm.org/D17392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

rnk added a comment. ping http://reviews.llvm.org/D18271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r266254 - [modules] Remove CXX_CTOR_INITIALIZERS_OFFSETS table. Instead of storing an ID

Author: rsmith Date: Wed Apr 13 16:57:08 2016 New Revision: 266254 URL: http://llvm.org/viewvc/llvm-project?rev=266254&view=rev Log: [modules] Remove CXX_CTOR_INITIALIZERS_OFFSETS table. Instead of storing an ID of a table entry in the corresponding decl, store an offset from the current record to

Re: [PATCH] D19072: [CodeGen] Split CGDebugInfo into CGDebugInfo and CGDebugDwarf

aprantl added inline comments. Comment at: lib/CodeGen/CodeGenModule.h:292 @@ -291,3 +291,3 @@ CGCUDARuntime* CUDARuntime; - CGDebugInfo* DebugInfo; + std::unique_ptr DebugInfo; ObjCEntrypoints *ObjCData; This could be a separate useful NFC commit. http:

Re: [PATCH] D19072: [CodeGen] Split CGDebugInfo into CGDebugInfo and CGDebugDwarf

echristo added inline comments. Comment at: lib/CodeGen/CodeGenModule.h:292 @@ -291,3 +291,3 @@ CGCUDARuntime* CUDARuntime; - CGDebugInfo* DebugInfo; + std::unique_ptr DebugInfo; ObjCEntrypoints *ObjCData; aprantl wrote: > This could be a separate useful N

r266263 - [CodeGen] Avoid ctor/dtor boilerplate with some C++11

Author: rnk Date: Wed Apr 13 18:37:17 2016 New Revision: 266263 URL: http://llvm.org/viewvc/llvm-project?rev=266263&view=rev Log: [CodeGen] Avoid ctor/dtor boilerplate with some C++11 Non-owning pointers that cache LLVM types and constants can use 'nullptr' default member initializers so that we

Re: [PATCH] D19072: [CodeGen] Split CGDebugInfo into CGDebugInfo and CGDebugDwarf

rnk marked 2 inline comments as done. Comment at: lib/CodeGen/CodeGenModule.h:292 @@ -291,3 +291,3 @@ CGCUDARuntime* CUDARuntime; - CGDebugInfo* DebugInfo; + std::unique_ptr DebugInfo; ObjCEntrypoints *ObjCData; echristo wrote: > aprantl wrote: > > This co

r266264 - ObjC kindof: order the methods in global pool relative to availability.

Author: mren Date: Wed Apr 13 18:43:56 2016 New Revision: 266264 URL: http://llvm.org/viewvc/llvm-project?rev=266264&view=rev Log: ObjC kindof: order the methods in global pool relative to availability. r265877 tries to put methods that are deprecated or unavailable to the front of the global poo

[PATCH] D19084: [clang-analyzer] fix warnings emitted on clang code base

apelete created this revision. apelete added a subscriber: cfe-commits. The following warnings were reported while running clang analyzer on Clang code base: API: argument with 'nonnull' attribute passed null, on file: - lib/AST/NestedNameSpecifier.cpp. Logic error: called C++ object pointer is

[clang-tools-extra] r266265 - clang-tools-extra/test/clang-tidy/readability-deleted-default.cpp: Add -fno-ms-compatibility.

Author: chapuni Date: Wed Apr 13 18:50:45 2016 New Revision: 266265 URL: http://llvm.org/viewvc/llvm-project?rev=266265&view=rev Log: clang-tools-extra/test/clang-tidy/readability-deleted-default.cpp: Add -fno-ms-compatibility. Modified: clang-tools-extra/trunk/test/clang-tidy/readability-de

r266266 - [modules] Remove CXX_BASE_SPECIFIERS_OFFSETS table. Instead of storing an ID of

Author: rsmith Date: Wed Apr 13 19:29:55 2016 New Revision: 266266 URL: http://llvm.org/viewvc/llvm-project?rev=266266&view=rev Log: [modules] Remove CXX_BASE_SPECIFIERS_OFFSETS table. Instead of storing an ID of a table entry in the corresponding decl, store an offset from the current record to t

Re: [clang-tools-extra] r266265 - clang-tools-extra/test/clang-tidy/readability-deleted-default.cpp: Add -fno-ms-compatibility.

Thanks! I was planning to do this myself, but got side-tracked. On Thu, Apr 14, 2016 at 1:50 AM, NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chapuni > Date: Wed Apr 13 18:50:45 2016 > New Revision: 266265 > > URL: http://llvm.org/viewvc/llvm-project?rev=266265&v

r266268 - Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

Author: alexfh Date: Wed Apr 13 19:47:40 2016 New Revision: 266268 URL: http://llvm.org/viewvc/llvm-project?rev=266268&view=rev Log: Reorder ASTNodeKind::AllKindInfo to match NodeKindId. Summary: AllKindInfo is being indexed by NodeKindId, so the order must match. Extended ASTTypeTraits tests to

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

This revision was automatically updated to reflect the committed changes. Closed by commit rL266268: Reorder ASTNodeKind::AllKindInfo to match NodeKindId. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D19059?vs=53569&id=53647#toc Repository: rL LLVM http://reviews.l

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

pxli168 added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:421 @@ +420,3 @@ +switch (LangOpts.OpenCLVersion) { +case 0: +case 100: What is 0 stand for as OpenCLVersion, it seems the default OpenCLVersion if we did not pass any -cl-st

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

pxli168 added inline comments. Comment at: lib/Headers/opencl.h:13721-13726 @@ +13720,8 @@ + +/** + * Queue a memory fence to ensure correct ordering of memory + * operations between work-items of a work-group to + * image memory. + */ +#define CLK_IMAGE_MEM_FENCE 0x04 +

r266276 - Do not use llvm:getGlobalContext() in unittests

Author: mehdi_amini Date: Thu Apr 14 00:34:32 2016 New Revision: 266276 URL: http://llvm.org/viewvc/llvm-project?rev=266276&view=rev Log: Do not use llvm:getGlobalContext() in unittests Currently trying to nuke this API from LLVM. From: Mehdi Amini Modified: cfe/trunk/unittests/CodeGen/Buf

r266277 - Make sure the LLVMContext outlive the CompilerInstance

Author: mehdi_amini Date: Thu Apr 14 00:37:41 2016 New Revision: 266277 URL: http://llvm.org/viewvc/llvm-project?rev=266277&view=rev Log: Make sure the LLVMContext outlive the CompilerInstance From: Mehdi Amini Modified: cfe/trunk/unittests/CodeGen/BufferSourceTest.cpp Modified: cfe/trunk/

r266278 - [Clang][AVX512][Builtin] Adding intrinsics of vpmovus{d|q}{b|w|d}{128|256|512} instruction set

Author: mzuckerm Date: Thu Apr 14 01:48:09 2016 New Revision: 266278 URL: http://llvm.org/viewvc/llvm-project?rev=266278&view=rev Log: [Clang][AVX512][Builtin] Adding intrinsics of vpmovus{d|q}{b|w|d}{128|256|512} instruction set Differential Revision: http://reviews.llvm.org/D19050 Modified:

<    1   2