[clang-tools-extra] r265210 - [clang-tidy] Update an example. NFC.

2016-04-01 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Fri Apr 1 22:44:23 2016 New Revision: 265210 URL: http://llvm.org/viewvc/llvm-project?rev=265210&view=rev Log: [clang-tidy] Update an example. NFC. Modified: clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.py Modified: clang-tools-extra/trunk/test/clang-tidy/ch

Re: [PATCH] D17482: [clang-tidy] Allow tests to verify changes made to header files

2016-04-01 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D17482#387457, @LegalizeAdulthood wrote: > I'm sorry to be such a nag and I know you're busy, but > > This changeset has been held up for a month and a half. (6 weeks since > originally posted in http://reviews.llvm.org/D16953) > > The chang

Re: [PATCH] D16183: Added CheckName field to YAML report

2016-04-01 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Sorry for the lng delay. I missed you patch among all other ones. Could you rebase your patch on top of HEAD and clang-format the files you changed? I'll come back with more substantial comments early next week. http://reviews.llvm.org/D16183

Re: [PATCH] D18703: [clang-tidy] Add new checker for comparison with runtime string functions.

2016-04-01 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/misc/SuspiciousStringCompareCheck.cpp:38 @@ +37,3 @@ + callExpr(hasDeclaration(functionDecl( + hasAnyName("__builtin_memcmp", + "__builtin_strcasecmp", Should we add a configura

Re: [PATCH] D18703: [clang-tidy] Add new checker for comparison with runtime string functions.

2016-04-01 Thread Etienne Bergeron via cfe-commits
etienneb added a comment. I spent time thinking about Eugene.Zelenko@ comment and I start to believe that given the difference between the errors ratio and the warnings ratio, maybe we should gate the report 'explicitly comparing result' under a configurable option. There is an order of magnit

r265218 - [test] Don't use "UNSUPPORTED" in FileCheck prefixes

2016-04-01 Thread Greg Parker via cfe-commits
Author: gparker Date: Sat Apr 2 00:29:00 2016 New Revision: 265218 URL: http://llvm.org/viewvc/llvm-project?rev=265218&view=rev Log: [test] Don't use "UNSUPPORTED" in FileCheck prefixes lit uses "UNSUPPORTED:" for its own purposes and may be confused if that text appears elsewhere in the test f

<    1   2