Re: [PATCH] D16044: getDescriptiveName() for MemRegion

Alexander_Droste added a comment. Here's the crash report that appears in case of the unknown function body: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 clang 0x000105f544b7 abort + 39 (Signals.inc:440) 1 clang

[PATCH] D18617: Call TargetMachine::addEarlyAsPossiblePasses from BackendUtil.

jlebar created this revision. jlebar added a reviewer: chandlerc. jlebar added subscribers: tra, cfe-commits, rnk. As of D18614, TargetMachine exposes a hook to add a set of passes that should be run as early as possible. Invoke this hook from clang when setting up the pass manager. http://revie

Re: [PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

This is already being done in http://reviews.llvm.org/D18582 On Wed, Mar 30, 2016 at 12:44 PM, Richard wrote: > LegalizeAdulthood added a subscriber: LegalizeAdulthood. > LegalizeAdulthood added a comment. > > Can you add a synopsis of this new check to `docs/ReleaseNotes.rst` please? > > > Repo

Re: [PATCH] Canonicalize UnaryTransformType types when they don't have a known underlying type

+ DependentDecltypeTypes.InsertNode(Canon, InsertPos); This is being inserted into the wrong set. +ut = new (*this, TypeAlignment) UnaryTransformType (BaseTy, UnderlyingTy, +Kind, +

Re: [PATCH] D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash

rsmith added inline comments. Comment at: test/PCH/arm-__va_list_tag.c:1-7 @@ +1,8 @@ +// REQUIRES: arm-registered-target + +// This test checks the patch for the compilation error / crash described in the D18557. + +// Test as a C source +// RUN: %clang_cc1 -triple=armv7-linux-g

[PATCH] D18618: [ObjC] Pop all cleanups created in CodeGenFunction::EmitObjCForCollectionStmt

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. This patch fixes a bug where EmitObjCForCollectionStmt doesn't pop cleanups for captures. For example, in the following for-in loop, a block which captures self is passed to foo1: for

Re: [PATCH] D17451: PR26448: [Sema] Fix determined type of ternary operator acting on two xvalue class types

erik.pilkington added a comment. Ping! http://reviews.llvm.org/D17451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18585: [CrashReproducer] Add a module map callback for added headers

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D18585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

r264908 - [modules] Add a regression test for PR21547.

Author: vvassilev Date: Wed Mar 30 15:10:07 2016 New Revision: 264908 URL: http://llvm.org/viewvc/llvm-project?rev=264908&view=rev Log: [modules] Add a regression test for PR21547. Added: cfe/trunk/test/Modules/Inputs/PR21547/ cfe/trunk/test/Modules/Inputs/PR21547/FirstHeader.h cfe/tr

Re: [PATCH] D18196: [CodeGen] Emit lifetime.end intrinsic after destructor call in landing pad

ahatanak updated this revision to Diff 52110. ahatanak added a comment. Add "REQUIRES: asserts" to test case to enable checking basic block names. http://reviews.llvm.org/D18196 Files: lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/EHScopeStack.h test/CodeGenCXX/destructor

r264913 - [modules] Write out identifiers if the ID is local, too.

Author: vvassilev Date: Wed Mar 30 15:16:03 2016 New Revision: 264913 URL: http://llvm.org/viewvc/llvm-project?rev=264913&view=rev Log: [modules] Write out identifiers if the ID is local, too. In some cases a slot for an identifier is requested but it gets written to another module, causing an as

Re: [PATCH] D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, do you need someone to commit this for you? Repository: rL LLVM http://reviews.llvm.org/D18557 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D18538: [Sema] s/UseUsingDeclRules/UseMemberUsingDeclRules/

This revision was automatically updated to reflect the committed changes. Closed by commit rL264920: [Sema] s/UseUsingDeclRules/UseMemberUsingDeclRules/ (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18538?vs=51866&id=52117#toc Repository: rL LLVM http://reviews.llv

r264920 - [Sema] s/UseUsingDeclRules/UseMemberUsingDeclRules/

Author: jlebar Date: Wed Mar 30 15:41:05 2016 New Revision: 264920 URL: http://llvm.org/viewvc/llvm-project?rev=264920&view=rev Log: [Sema] s/UseUsingDeclRules/UseMemberUsingDeclRules/ Summary: IsOverload has a param named UseUsingDeclRules. But as far as I can tell, it should be called UseMembe

Re: [PATCH] D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash

iid_iunknown marked an inline comment as done. Comment at: test/PCH/arm-__va_list_tag.c:1-7 @@ +1,8 @@ +// REQUIRES: arm-registered-target + +// This test checks the patch for the compilation error / crash described in the D18557. + +// Test as a C source +// RUN: %clang_cc1 -tri

Re: [PATCH] D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash

iid_iunknown updated this revision to Diff 52114. iid_iunknown added a comment. The test enabled for all targets. Repository: rL LLVM http://reviews.llvm.org/D18557 Files: lib/AST/ASTContext.cpp test/PCH/Inputs/__va_list_tag-typedef.h test/PCH/__va_list_tag-typedef.c Index: test/PCH/_

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

LegalizeAdulthood added inline comments. Comment at: clang-tidy/add_new_check.py:283 @@ +282,3 @@ + elif not clang_tidy_heading_found: +if line.startswith('^^'): + clang_tidy_heading_found = True Alex changed the f

Re: [PATCH] D17482: [clang-tidy] Allow tests to verify changes made to header files

LegalizeAdulthood added a comment. I'm sorry to be such a nag and I know you're busy, but This changeset has been held up for a month and a half. (6 weeks since originally posted in http://reviews.llvm.org/D16953) The change isn't that complicated and there haven't really been any comments

Re: [PATCH] D18608: note for top-level consts in function decls tidy

LegalizeAdulthood added a subscriber: LegalizeAdulthood. Comment at: docs/ReleaseNotes.rst:153-154 @@ -152,2 +152,4 @@ + * `readability-avoid-const-params-in-decls +

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

On Wed, Mar 30, 2016 at 10:54:32AM -0700, Adrian Prantl via cfe-commits wrote: > > Let's take a kernel as example. I want to include certain types for > > dtrace-like use with /dev/kmem, but not all the 100KB+ of boring types. > > Enough for doing some basic post-mortem debugging even on embedded >

Re: [PATCH] D18608: note for top-level consts in function decls tidy

fowles added inline comments. Comment at: docs/ReleaseNotes.rst:153-154 @@ -152,2 +152,4 @@ + * `readability-avoid-const-params-in-decls + `_ * `re

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

LegalizeAdulthood added inline comments. Comment at: docs/ReleaseNotes.rst:143 @@ -71,3 +142,3 @@ Improvements to ``modularize`` ^^ LegalizeAdulthood wrote: > The formatting here has been changed on trunk. Please rebase with a full

Re: [PATCH] D18557: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash

iid_iunknown marked an inline comment as done. iid_iunknown added a comment. I have commit access. Thank you for your help with the patch! Repository: rL LLVM http://reviews.llvm.org/D18557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

xur created this revision. xur added reviewers: davidxl, bogner, joker.eph. xur added subscribers: cfe-commits, vsk, xur. Write out the PGOFuncName meta data if PGOFuncName is different from function's raw name. This should only apply to internal linkage functions. This is to be consumed by indi

Re: [PATCH] D18608: note for top-level consts in function decls tidy

LegalizeAdulthood added inline comments. Comment at: docs/ReleaseNotes.rst:153-154 @@ -152,2 +152,4 @@ + * `readability-avoid-const-params-in-decls +

r264930 - [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash

Author: oleg Date: Wed Mar 30 16:30:30 2016 New Revision: 264930 URL: http://llvm.org/viewvc/llvm-project?rev=264930&view=rev Log: [Clang][ARM] __va_list declaration is not saved in ASTContext causing compilation error or crash Summary: When the code is compiled for arm32 and the builtin `__va_l

Re: [PATCH] D18608: note for top-level consts in function decls tidy

fowles updated this revision to Diff 52126. fowles added a comment. - move release note to 3.9 section http://reviews.llvm.org/D18608 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ do

Re: [PATCH] D18608: note for top-level consts in function decls tidy

fowles marked an inline comment as done. fowles added a comment. http://reviews.llvm.org/D18608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r264931 - AMDGPU: Remove separate r600 double data layout

Author: arsenm Date: Wed Mar 30 16:32:37 2016 New Revision: 264931 URL: http://llvm.org/viewvc/llvm-project?rev=264931&view=rev Log: AMDGPU: Remove separate r600 double data layout This is identical to the other r600 datalayout string. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe

Re: [PATCH] D18472: AMDGPU: Remove separate r600 double data layout

arsenm closed this revision. arsenm added a comment. r264931 http://reviews.llvm.org/D18472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r264932 - Silencing warnings from MSVC 2015 Update 2. Both of these changes silence "C4334 '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)". NFC.

Author: aaronballman Date: Wed Mar 30 16:33:34 2016 New Revision: 264932 URL: http://llvm.org/viewvc/llvm-project?rev=264932&view=rev Log: Silencing warnings from MSVC 2015 Update 2. Both of these changes silence "C4334 '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shi

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko added a comment. Sections headers are not problem :-) See newly added "Clang-tidy changes from 3.7 to 3.8" section. It contains only names of checks with link to documentation page without brief description. Repository: rL LLVM http://reviews.llvm.org/D18582 __

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

> On Mar 30, 2016, at 2:19 PM, Joerg Sonnenberger via cfe-commits > wrote: > > On Wed, Mar 30, 2016 at 10:54:32AM -0700, Adrian Prantl via cfe-commits wrote: >>> Let's take a kernel as example. I want to include certain types for >>> dtrace-like use with /dev/kmem, but not all the 100KB+ of bor

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

yaxunl added a comment. In http://reviews.llvm.org/D18369#385799, @Anastasia wrote: > Regarding half types since there is inconsistency in both headers (commented > in CL1.2), should we just enable the extension cl_khr_fp16 in the header and > then have the overloads with half there with all th

Re: [PATCH] D18501: Fix compilation on FreeBSD

EricWF added a comment. In http://reviews.llvm.org/D18501#384285, @dim wrote: > Note that these compilation errors came up specifically because @bdrewery is > doing cross-compilation of FreeBSD with recent versions of gcc. Apparently > clang does not give the same errors on these undefined ide

Re: [PATCH] D18501: Fix compilation on FreeBSD

rsmith added a subscriber: rsmith. rsmith added a comment. libc++'s converts the `signbit` macro into a function. If you're not seeing a function here, that suggests your include paths are messed up and the C library is being found before libc++'s . http://reviews.llvm.org/D18501

Re: r264908 - [modules] Add a regression test for PR21547.

On Wed, Mar 30, 2016 at 1:10 PM, Vassil Vassilev via cfe-commits wrote: > Author: vvassilev > Date: Wed Mar 30 15:10:07 2016 > New Revision: 264908 > > URL: http://llvm.org/viewvc/llvm-project?rev=264908&view=rev > Log: > [modules] Add a regression test for PR21547. > > Added: > cfe/trunk/test

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

xur updated this revision to Diff 52134. xur added a comment. sync the change in http://reviews.llvm.org/D18623. http://reviews.llvm.org/D18624 Files: lib/CodeGen/CodeGenPGO.cpp Index: lib/CodeGen/CodeGenPGO.cpp === --- lib/Code

Re: r264908 - [modules] Add a regression test for PR21547.

On 31/03/16 00:08, Richard Smith wrote: On Wed, Mar 30, 2016 at 1:10 PM, Vassil Vassilev via cfe-commits wrote: Author: vvassilev Date: Wed Mar 30 15:10:07 2016 New Revision: 264908 URL: http://llvm.org/viewvc/llvm-project?rev=264908&view=rev Log: [modules] Add a regression test for PR21547.

Re: [PATCH] D18380: [CUDA] Make unattributed constexpr functions (usually) implicitly host+device.

rsmith added a comment. LGTM http://reviews.llvm.org/D18380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16948: [libcxx] Filesystem TS Part 1 -- path

EricWF added a comment. Ping! http://reviews.llvm.org/D16948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r264937 - Canonicalize UnaryTransformType types when they don't have a known underlying type.

Author: vvassilev Date: Wed Mar 30 17:18:29 2016 New Revision: 264937 URL: http://llvm.org/viewvc/llvm-project?rev=264937&view=rev Log: Canonicalize UnaryTransformType types when they don't have a known underlying type. Fixes https://llvm.org/bugs/show_bug.cgi?id=26014 Reviewed by Richard Smith

r264939 - Add -emit-llvm-only to the regression test for PR21547.

Author: vvassilev Date: Wed Mar 30 17:22:50 2016 New Revision: 264939 URL: http://llvm.org/viewvc/llvm-project?rev=264939&view=rev Log: Add -emit-llvm-only to the regression test for PR21547. Modified: cfe/trunk/test/Modules/pr21547.cpp Modified: cfe/trunk/test/Modules/pr21547.cpp URL: http

r264940 - Fix Clang crash with template type diffing.

Author: rtrieu Date: Wed Mar 30 17:23:00 2016 New Revision: 264940 URL: http://llvm.org/viewvc/llvm-project?rev=264940&view=rev Log: Fix Clang crash with template type diffing. Fixes https://llvm.org/bugs/show_bug.cgi?id=27129 which is crash involving type aliases and template type diffing. Temp

Re: r264908 - [modules] Add a regression test for PR21547.

On 31/03/16 00:08, Richard Smith wrote: On Wed, Mar 30, 2016 at 1:10 PM, Vassil Vassilev via cfe-commits wrote: Author: vvassilev Date: Wed Mar 30 15:10:07 2016 New Revision: 264908 URL: http://llvm.org/viewvc/llvm-project?rev=264908&view=rev Log: [modules] Add a regression test for PR21547.

r264941 - Docs: keep copyright years up-to-date.

Author: probinson Date: Wed Mar 30 17:24:57 2016 New Revision: 264941 URL: http://llvm.org/viewvc/llvm-project?rev=264941&view=rev Log: Docs: keep copyright years up-to-date. Modified: cfe/trunk/docs/analyzer/conf.py Modified: cfe/trunk/docs/analyzer/conf.py URL: http://llvm.org/viewvc/llvm

Re: [PATCH] Canonicalize UnaryTransformType types when they don't have a known underlying type

On 30/03/16 21:38, Richard Smith wrote: + DependentDecltypeTypes.InsertNode(Canon, InsertPos); This is being inserted into the wrong set. +ut = new (*this, TypeAlignment) UnaryTransformType (BaseTy, UnderlyingTy, +Kind, +

r264946 - Update copyright year to 2016.

Author: probinson Date: Wed Mar 30 17:38:44 2016 New Revision: 264946 URL: http://llvm.org/viewvc/llvm-project?rev=264946&view=rev Log: Update copyright year to 2016. Modified: cfe/trunk/LICENSE.TXT Modified: cfe/trunk/LICENSE.TXT URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/LICENSE.T

[clang-tools-extra] r264947 - Update copyright year to 2016.

Author: probinson Date: Wed Mar 30 17:38:47 2016 New Revision: 264947 URL: http://llvm.org/viewvc/llvm-project?rev=264947&view=rev Log: Update copyright year to 2016. Modified: clang-tools-extra/trunk/LICENSE.TXT Modified: clang-tools-extra/trunk/LICENSE.TXT URL: http://llvm.org/viewvc/llvm

[libclc] r264949 - Update copyright year to 2016.

Author: probinson Date: Wed Mar 30 17:39:03 2016 New Revision: 264949 URL: http://llvm.org/viewvc/llvm-project?rev=264949&view=rev Log: Update copyright year to 2016. Modified: libclc/trunk/LICENSE.TXT Modified: libclc/trunk/LICENSE.TXT URL: http://llvm.org/viewvc/llvm-project/libclc/trunk/

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

LGTM from the Darwin-side, assuming Reid doesn't have any more comments. > On 2016-Mar-28, at 13:12, Bruno Cardoso Lopes wrote: > > bruno updated this revision to Diff 51828. > bruno added a comment. > > Thanks Reid. The original idea was to have MaxDigits despite the size of the > input array

[libcxx] r264950 - Update copyright year to 2016.

Author: probinson Date: Wed Mar 30 17:39:53 2016 New Revision: 264950 URL: http://llvm.org/viewvc/llvm-project?rev=264950&view=rev Log: Update copyright year to 2016. Modified: libcxx/trunk/LICENSE.TXT Modified: libcxx/trunk/LICENSE.TXT URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/

[libcxxabi] r264952 - Update copyright year to 2016.

Author: probinson Date: Wed Mar 30 17:40:47 2016 New Revision: 264952 URL: http://llvm.org/viewvc/llvm-project?rev=264952&view=rev Log: Update copyright year to 2016. Modified: libcxxabi/trunk/LICENSE.TXT Modified: libcxxabi/trunk/LICENSE.TXT URL: http://llvm.org/viewvc/llvm-project/libcxxa

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. LGTM from the Darwin-side, assuming Reid doesn't have any more comments. http://reviews.llvm.org/D18304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

zaks.anna added a comment. It's a bug in the checker. dyn_cast should not be called on a null pointer. You could either check for nun or call dyn_cast_or_null. http://reviews.llvm.org/D16044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

r264960 - AMDGPU: Add frexp_mant + frexp_exp builtins

Author: arsenm Date: Wed Mar 30 17:57:40 2016 New Revision: 264960 URL: http://llvm.org/viewvc/llvm-project?rev=264960&view=rev Log: AMDGPU: Add frexp_mant + frexp_exp builtins Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/tes

Re: [PATCH] D18338: AMDGPU: Add frexp_exp builtins

arsenm closed this revision. arsenm added a comment. r264960 http://reviews.llvm.org/D18338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18629: [CUDA] Don't initialize the CUDA toolchain if we don't have any CUDA inputs.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: cfe-commits, sunfish, echristo. This prevents errors when you invoke clang with a flag that the NVPTX toolchain doesn't support. For example, on x86-64, clang -mthread-model single -x c++ /dev/null -o /dev/nu

Re: [PATCH] D18539: [CUDA] Add math forward declares.

jlebar marked an inline comment as done. jlebar added a comment. Thank you for the review, Art! http://reviews.llvm.org/D18539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18380: [CUDA] Make unattributed constexpr functions (usually) implicitly host+device.

jlebar marked an inline comment as done. jlebar added a comment. Thank you all your time here, Art, Reid, and Richard. Fingers crossed we don't have to worry about this again for a while... http://reviews.llvm.org/D18380 ___ cfe-commits mailing li

Re: [PATCH] D18629: [CUDA] Don't initialize the CUDA toolchain if we don't have any CUDA inputs.

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. Not sure if that's clang-formatted, but please do so if not :) -eric http://reviews.llvm.org/D18629 ___

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. lgtm, go for it Comment at: lib/Driver/Driver.cpp:2549-2550 @@ +2548,4 @@ + unsigned CurDigit = 0; + unsigned MaxDigits = Digits.size(); + while (CurDi

Re: [PATCH] D18629: [CUDA] Don't initialize the CUDA toolchain if we don't have any CUDA inputs.

jlebar added a comment. Discussed offline, this is clang-formatted. Thank you for the review, Eric! http://reviews.llvm.org/D18629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste updated this revision to Diff 52148. Alexander_Droste added a comment. - check memory regions for `nullptr` in `checkDoubleNonblocking` and `checkUnmatchedWaits` before they get passed to `dyn_cast` http://reviews.llvm.org/D12761 Files: lib/StaticAnalyzer/Checkers/CMakeLists

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

Alexander_Droste added a comment. > It's a bug in the checker. dyn_cast should not be called on a null pointer. > You could either check for nun or call dyn_cast_or_null. Thanks for pointing this out! Adding guards that check for `nullptr` fixed the problem. http://reviews.llvm.org/D16044

r264963 - [CUDA] Add math forward declares to CUDA header wrapper.

Author: jlebar Date: Wed Mar 30 18:30:14 2016 New Revision: 264963 URL: http://llvm.org/viewvc/llvm-project?rev=264963&view=rev Log: [CUDA] Add math forward declares to CUDA header wrapper. Summary: This is necessary for a future patch which will make all constexpr functions implicitly host+devic

r264964 - [CUDA] Make unattributed constexpr functions implicitly host+device.

Author: jlebar Date: Wed Mar 30 18:30:21 2016 New Revision: 264964 URL: http://llvm.org/viewvc/llvm-project?rev=264964&view=rev Log: [CUDA] Make unattributed constexpr functions implicitly host+device. With this patch, by a constexpr function is implicitly host+device unless: a) it's a variadic

Re: [PATCH] D18629: [CUDA] Don't initialize the CUDA toolchain if we don't have any CUDA inputs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264965: [CUDA] Don't initialize the CUDA toolchain if we don't have any CUDA inputs. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18629?vs=52146&id=52153#toc Repository: rL

Re: [PATCH] D18380: [CUDA] Make unattributed constexpr functions (usually) implicitly host+device.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264964: [CUDA] Make unattributed constexpr functions implicitly host+device. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18380?vs=51868&id=52152#toc Repository: rL LLVM h

Re: [PATCH] D18539: [CUDA] Add math forward declares.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264963: [CUDA] Add math forward declares to CUDA header wrapper. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18539?vs=51988&id=52151#toc Repository: rL LLVM http://review

r264965 - [CUDA] Don't initialize the CUDA toolchain if we don't have any CUDA inputs.

Author: jlebar Date: Wed Mar 30 18:30:25 2016 New Revision: 264965 URL: http://llvm.org/viewvc/llvm-project?rev=264965&view=rev Log: [CUDA] Don't initialize the CUDA toolchain if we don't have any CUDA inputs. Summary: This prevents errors when you invoke clang with a flag that the NVPTX toolchai

r264967 - Fix deduction of __atomic_load's parameter types.

Author: ericwf Date: Wed Mar 30 18:39:56 2016 New Revision: 264967 URL: http://llvm.org/viewvc/llvm-project?rev=264967&view=rev Log: Fix deduction of __atomic_load's parameter types. Summary: __atomic_load's allows it's first argument to be a pointer to a const type. However the second argument

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

alexfh added a comment. In http://reviews.llvm.org/D18582#387525, @Eugene.Zelenko wrote: > Sections headers are not problem :-) > > See newly added "Clang-tidy changes from 3.7 to 3.8" section. It contains > only names of checks with link to documentation page without brief > description. The

r264969 - [CUDA] Add -disable-llvm-passes to CodeGenCUDA/link-device-bitcode.cu. NFC

Author: jlebar Date: Wed Mar 30 18:45:38 2016 New Revision: 264969 URL: http://llvm.org/viewvc/llvm-project?rev=264969&view=rev Log: [CUDA] Add -disable-llvm-passes to CodeGenCUDA/link-device-bitcode.cu. NFC We already have this flag in most of the file, but we need it everywhere else, to disabl

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko added a comment. Which links should I use, since it should point to release specific location, but 3.9 is not branched yet? Repository: rL LLVM http://reviews.llvm.org/D18582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r264970 - [VFS] Handle empty entries in directory traversal

Author: bruno Date: Wed Mar 30 18:54:00 2016 New Revision: 264970 URL: http://llvm.org/viewvc/llvm-project?rev=264970&view=rev Log: [VFS] Handle empty entries in directory traversal The VFS YAML files contain empty directory entries to describe that it's returning from a subdirectory before descr

r264971 - [CrashReproducer] Add a module map callback for added headers

Author: bruno Date: Wed Mar 30 18:54:25 2016 New Revision: 264971 URL: http://llvm.org/viewvc/llvm-project?rev=264971&view=rev Log: [CrashReproducer] Add a module map callback for added headers The current ModuleDependencyCollector has a AST listener to collect header files present in loaded modu

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

Alexander_Droste added inline comments. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:653 @@ +652,3 @@ +// name by calling 'getDescriptiveName' recursively. +else { + std::string Idx = ER->getDescriptiveName(false); Alexander_Droste wrote: > zaks.

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

michael_miller updated this revision to Diff 52156. michael_miller added a comment. Added explanation of changes to ReleaseNotes.rst and cleaned up documentation for the check a little. http://reviews.llvm.org/D18584 Files: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tidy

Re: [PATCH] D18618: [ObjC] Pop all cleanups created in CodeGenFunction::EmitObjCForCollectionStmt

rjmccall added a comment. If multiple cleanups can be entered, the appropriate thing to do is enter a RunCleanupsScope of some sort and then pop it at the right time. But you should find out why the cleanup is being entered — it's possible that it's not being properly bound to a full-expressio

[PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

pcc created this revision. pcc added reviewers: rsmith, eugenis, aaron.ballman, cfe-commits. pcc added subscribers: joker.eph, pete. Bitsets, and the compiler features they rely on (vtable opt, CFI), only have scope within the linkage unit. Therefore, only enable these features for classes with li

r264975 - [Sema] Fix PR27122: ICE with enable_if+ill-formed call.

Author: gbiv Date: Wed Mar 30 19:16:25 2016 New Revision: 264975 URL: http://llvm.org/viewvc/llvm-project?rev=264975&view=rev Log: [Sema] Fix PR27122: ICE with enable_if+ill-formed call. In some cases, when we encounter a direct function call with an incorrect number of arguments, we'll emit a di

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko updated this revision to Diff 52163. Eugene.Zelenko added a comment. Addressed Alex and Richard comments except links. Also fixed spotted issues in checks documentation. Looks like better documentation proofreading during code review is needed. Repository: rL LLVM http://revi

Re: [PATCH] D18540: [Sema] Note when we've actually encountered a failure in ExprConstant, and take that into account when looking up objects.

george.burgess.iv updated this revision to Diff 52167. george.burgess.iv marked an inline comment as done. george.burgess.iv added a comment. Addressed all feedback. http://reviews.llvm.org/D18540 Files: lib/AST/ExprConstant.cpp test/SemaCXX/builtin-object-size-cxx14.cpp test/SemaCXX/cons

Re: [PATCH] D18540: [Sema] Note when we've actually encountered a failure in ExprConstant, and take that into account when looking up objects.

george.burgess.iv added inline comments. Comment at: include/clang/AST/Expr.h:541-546 @@ -540,1 +540,8 @@ +/// \brief Whether the evaluation was unable to reduce a construct to a +/// value. +/// +/// For example, in foo(bar, baz, qux), if evaluating bar fails, w

Re: [PATCH] D18618: [ObjC] Pop all cleanups created in CodeGenFunction::EmitObjCForCollectionStmt

ahatanak added a comment. In CodeGenFunction::EmitARCRetainScalarExpr, if I move the declaration of "scope" above the call to enterFullExpression, the cleanup is popped before the loop body is entered right after the method returning the collection (foo1 in the test case) is called. if (const

[libcxx] r264985 - Update container_test_types.h and cleanup the related tests

Author: ericwf Date: Wed Mar 30 21:13:14 2016 New Revision: 264985 URL: http://llvm.org/viewvc/llvm-project?rev=264985&view=rev Log: Update container_test_types.h and cleanup the related tests Modified: libcxx/trunk/test/std/containers/unord/unord.map/max_load_factor.pass.cpp libcxx/trun

[libcxx] r264986 - Teach __tree how to handle map's __value_type

Author: ericwf Date: Wed Mar 30 21:15:15 2016 New Revision: 264986 URL: http://llvm.org/viewvc/llvm-project?rev=264986&view=rev Log: Teach __tree how to handle map's __value_type This patch is fairly large and contains a number of changes. The changes all work towards allowing __tree to properly

Re: [PATCH] D18479: [CodeGenCXX] Fix ItaniumCXXABI::getAlignmentOfExnObject to return 8-byte alignment on Darwin

rjmccall added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:174 @@ +173,3 @@ +else + Align = CGM.getContext().getTargetDefaultAlignForAttributeAligned(); + Just add a ExnObjectAlignment field to TargetInfo, please. We already have a Darwin

r264987 - [DarwinDriver] Increase the number of valid digits for ld64 version string.

Author: bruno Date: Wed Mar 30 21:45:46 2016 New Revision: 264987 URL: http://llvm.org/viewvc/llvm-project?rev=264987&view=rev Log: [DarwinDriver] Increase the number of valid digits for ld64 version string. Previously only 3 digits were valid. Increase it to 5. Differential Revision: http://rev

[PATCH] D18636: [PGO] Avoid instrumenting constants at value sites

betulb created this revision. betulb added reviewers: davidxl, bogner. betulb added subscribers: llvm-commits, cfe-commits. betulb set the repository for this revision to rL LLVM. betulb changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Value p

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno added a comment. Committed r264987! Comment at: lib/Driver/Driver.cpp:2549-2550 @@ +2548,4 @@ + unsigned CurDigit = 0; + unsigned MaxDigits = Digits.size(); + while (CurDigit < MaxDigits) { +unsigned Digit = (unsigned)strtol(Str, &End, 10); rnk wrot

Re: [PATCH] D18618: [ObjC] Pop all cleanups created in CodeGenFunction::EmitObjCForCollectionStmt

rjmccall added a comment. In http://reviews.llvm.org/D18618#387847, @ahatanak wrote: > In CodeGenFunction::EmitARCRetainScalarExpr, if I move the declaration of > "scope" above the call to enterFullExpression, the cleanup is popped before > the loop body is entered right after the method return

[libcxx] r264989 - Fix LWG issue 2469 - Use piecewise construction in map::operator[].

Author: ericwf Date: Wed Mar 30 22:13:37 2016 New Revision: 264989 URL: http://llvm.org/viewvc/llvm-project?rev=264989&view=rev Log: Fix LWG issue 2469 - Use piecewise construction in map::operator[]. map's allocator may only be used to construct objects of 'value_type', or in this case 'pair'. I

[PATCH] D18637: Extract key to avoid preemptive mallocs in insert/emplace in associative containers

EricWF created this revision. EricWF added reviewers: mclow.lists, dexonsmith. EricWF added a subscriber: cfe-commits. This patch applies Duncan's work on __hash_table to __tree. http://reviews.llvm.org/D18637 Files: include/__hash_table include/__tree include/__tuple include/type_traits

r264991 - Fix -Wdynamic-class-memaccess to skip invalid classes.

Author: rtrieu Date: Wed Mar 30 23:18:07 2016 New Revision: 264991 URL: http://llvm.org/viewvc/llvm-project?rev=264991&view=rev Log: Fix -Wdynamic-class-memaccess to skip invalid classes. This warning sometimes will infinitely recurse on CXXRecordDecl's from ill-formed recursive classes that have

Re: [PATCH] D18479: [CodeGenCXX] Fix ItaniumCXXABI::getAlignmentOfExnObject to return 8-byte alignment on Darwin

ahatanak updated this revision to Diff 52171. ahatanak added a comment. Thank you for the review, John. I've updated the patch as per your request. I defined virtual function getExnObjectAlignment instead of adding a ExnObjectAlignment field to TargetInfo since I found that getDefaultAlignForAt

Re: [PATCH] D18636: [PGO] Avoid instrumenting constants at value sites

davidxl added inline comments. Comment at: lib/CodeGen/CodeGenPGO.cpp:758 @@ -757,1 +757,3 @@ + if (dyn_cast(ValuePtr)) +return; Is it the bitcast guaranteed to be already stripped here? Repository: rL LLVM http://reviews.llvm.org/D18636 ___

r264997 - Visual Studio native visualization for clang::TemplateDecl

Author: mps Date: Thu Mar 31 01:09:56 2016 New Revision: 264997 URL: http://llvm.org/viewvc/llvm-project?rev=264997&view=rev Log: Visual Studio native visualization for clang::TemplateDecl With this change, TemplateDecls display in the Locals Window something like template struct A; Modified

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

baloghadamsoftware added a comment. In http://reviews.llvm.org/D18265#387078, @LegalizeAdulthood wrote: > Please summarize this check in `docs/ReleaseNotes.rst`. OK, I will do it after the name is decided. http://reviews.llvm.org/D18265 ___ cfe-c

<    1   2   3   >