[PATCH] D18473: AMDGPU: Add test for generic builtin behavior

arsenm created this revision. arsenm added a reviewer: tstellarAMD. arsenm added a subscriber: cfe-commits. This is the same as the default implementation, but add a comment and make sure the behavior is tested. http://reviews.llvm.org/D18473 Files: lib/Basic/Targets.cpp test/CodeGenOpenCL/b

Re: [PATCH] D17987: [clang-tidy] Extension of checker misc-misplaced-widening-cast

baloghadamsoftware updated this revision to Diff 51633. baloghadamsoftware added a comment. Requested revision done. http://reviews.llvm.org/D17987 Files: clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp clang-tidy/misc/MisplacedWideningCastCheck.cpp clang-tidy/misc/MisplacedWidenin

Re: [PATCH] D17987: [clang-tidy] Extension of checker misc-misplaced-widening-cast

baloghadamsoftware marked 9 inline comments as done. Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:117 @@ +116,3 @@ +static llvm::SmallDenseMap createRelativeCharSizesMap() { + llvm::SmallDenseMap Result(6); + Result[BuiltinType::UChar] = 1; I chang

Re: [PATCH] D17516: AMDGPU: Verify subtarget specific builtins

arsenm updated this revision to Diff 51636. arsenm added a comment. Try to move more code into initFeatureMap. I'm not sure how the booleans for features in the class are for now. X86 seems to have them, but it seems they are only used with user specified features? The only ones that matter rig

Re: [PATCH] D17951: Implement is_always_lock_free

This revision was automatically updated to reflect the committed changes. Closed by commit rL264413: Implement is_always_lock_free (authored by jfb). Changed prior to commit: http://reviews.llvm.org/D17951?vs=51607&id=51638#toc Repository: rL LLVM http://reviews.llvm.org/D17951 Files: lib

[libcxx] r264413 - Implement is_always_lock_free

Author: jfb Date: Fri Mar 25 10:48:21 2016 New Revision: 264413 URL: http://llvm.org/viewvc/llvm-project?rev=264413&view=rev Log: Implement is_always_lock_free Summary: This was voted into C++17 at the Jacksonville meeting. The final P0152R1 paper will be in the upcoming post-Jacksonville mailin

[PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, sfantao, Hahnfeld. carlo.bertolli added subscribers: arpith-jacob, caomhin, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. This patch fixes a bug in code generation of the correct OpenMP ru

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

sfantao added a comment. Thanks for the fix! Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4257 @@ +4256,3 @@ +hasEnclosingTeams(const Stmt *TargetBody) { + if(auto *TeamsDir = dyn_cast(TargetBody)) return TeamsDir; + I think that this can be simplified to: ```

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

kkwli0 added a comment. Thanks for the review. As request, I will split this patch into two: 1. to and from clause (without test cases) 2. target update directive (with test cases) I will use this review for the target update directive. http://reviews.llvm.org/D15944 __

r264417 - [ASTMatchers] Add own version of VariadicFunction.

Author: sbenza Date: Fri Mar 25 11:29:30 2016 New Revision: 264417 URL: http://llvm.org/viewvc/llvm-project?rev=264417&view=rev Log: [ASTMatchers] Add own version of VariadicFunction. Summary: llvm::VariadicFunction is only being used by ASTMatchers. Having our own copy here allows us to remove t

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264417: [ASTMatchers] Add own version of VariadicFunction. (authored by sbenza). Changed prior to commit: http://reviews.llvm.org/D18275?vs=51447&id=51645#toc Repository: rL LLVM http://reviews.llvm

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4257 @@ +4256,3 @@ +hasEnclosingTeams(const Stmt *TargetBody) { + if(auto *TeamsDir = dyn_cast(TargetBody)) return TeamsDir; + sfantao wrote: > I think that this can be simplified t

[PATCH] D18475: [clang-tidy] Add more detection rules for redundant c_str calls.

etienneb created this revision. etienneb added a subscriber: cfe-commits. The string class contains methods which support receiving either a string literal or a string object. For example, calls to append can receive either a char* or a string. ``` string& append (const string& str); string&

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4257 @@ +4256,3 @@ +hasEnclosingTeams(const Stmt *TargetBody) { + if(auto *TeamsDir = dyn_cast(TargetBody)) return TeamsDir; + carlo.bertolli wrote: > sfantao wrote: > > I think that this

Re: [PATCH] D18475: [clang-tidy] Add more detection rules for redundant c_str calls.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Thank you for enhancement! I think will be good idea to extend check for any function call that receives .c_str(), since it mat be in other classes could have methods which receives both C++ or C strings. See als

r264423 - [index] Remove redundancy between symbol kind and language

Author: benlangmuir Date: Fri Mar 25 12:01:59 2016 New Revision: 264423 URL: http://llvm.org/viewvc/llvm-project?rev=264423&view=rev Log: [index] Remove redundancy between symbol kind and language Condense the ObjCKIND and CXXKIND options into just KIND, since the language was already specified o

Re: [PATCH] D18475: [clang-tidy] Add more detection rules for redundant c_str calls.

On Fri, Mar 25, 2016 at 9:59 AM, Etienne Bergeron via cfe-commits < cfe-commits@lists.llvm.org> wrote: > etienneb created this revision. > etienneb added a subscriber: cfe-commits. > > The string class contains methods which support receiving either a string > literal or a string object. > > For e

Re: [PATCH] D18475: [clang-tidy] Add more detection rules for redundant c_str calls.

etienneb added a comment. In http://reviews.llvm.org/D18475#383520, @Eugene.Zelenko wrote: > Thank you for enhancement! > > I think will be good idea to extend check for any function call that receives > .c_str(), since it mat be in other classes could have methods which receives > both C++ or

Re: [PATCH] D18475: [clang-tidy] Add more detection rules for redundant c_str calls.

etienneb updated this revision to Diff 51657. etienneb added a comment. Fixing some matchers to use the recent new AstMatcher. (see http://reviews.llvm.org/D18275) http://reviews.llvm.org/D18475 Files: clang-tidy/readability/RedundantStringCStrCheck.cpp test/clang-tidy/readability-redundant

Re: [PATCH] D18475: [clang-tidy] Add more detection rules for redundant c_str calls.

etienneb added a comment. chapuni@: I would like to know why "-target x86_64-unknown -std=c++11" was needed. I'm fixing an issue with char16_t/char32_t. Is that the problem you just fixed? http://reviews.llvm.org/D18475 ___ cfe-commits mailing lis

r264428 - [ASTMatchers] Fix build for VariadicFunction.

Author: sbenza Date: Fri Mar 25 12:46:02 2016 New Revision: 264428 URL: http://llvm.org/viewvc/llvm-project?rev=264428&view=rev Log: [ASTMatchers] Fix build for VariadicFunction. Under some conditions the implicit conversion from array to ArrayRef<> is not working. Fix the build by making it expl

Re: [PATCH] D18461: ObjCXX: Warn undeclared identifiers.

manmanren added a comment. In http://reviews.llvm.org/D18461#383218, @rjmccall wrote: > Oh, you know, this should really propagate all the dependence bits, not just > instantiation-dependence. It would be safer, at least. You could probably > find a contrived example involving value-dependenc

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sbenza > Date: Fri Mar 25 12:46:02 2016 > New Revision: 264428 > > URL: http://llvm.org/viewvc/llvm-project?rev=264428&view=rev > Log: > [ASTMatchers] Fix build for VariadicFunction. >

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

etienneb added a subscriber: etienneb. etienneb added a comment. Any plan for doing the same for : hasOverloadedOperatorName ? Repository: rL LLVM http://reviews.llvm.org/D18275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

On Fri, Mar 25, 2016 at 10:55 AM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: sbenza >> Date: Fri Mar 25 12:46:02 2016 >> New Revision: 264428 >> >> U

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

On Fri, Mar 25, 2016 at 1:55 PM, Etienne Bergeron wrote: > etienneb added a subscriber: etienneb. > etienneb added a comment. > > Any plan for doing the same for : hasOverloadedOperatorName ? > hasAnyName() was added mostly for performance reasons. We could add the 'Any' version of hasOverloaded

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

> hasAnyName() was added mostly for performance reasons. Fair enough. Thanks. On Fri, Mar 25, 2016 at 2:01 PM, Samuel Benzaquen wrote: > On Fri, Mar 25, 2016 at 1:55 PM, Etienne Bergeron > wrote: > >> etienneb added a subscriber: etienneb. >> etienneb added a comment. >> >> Any plan for doing

Re: [PATCH] D18475: [clang-tidy] Add more detection rules for redundant c_str calls.

etienneb updated this revision to Diff 51664. etienneb updated the summary for this revision. etienneb added a comment. fix unittest on linux/32-bits. tested on windows/32-bits. http://reviews.llvm.org/D18475 Files: clang-tidy/readability/RedundantStringCStrCheck.cpp test/clang-tidy/readabi

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

Hi, I think this broke clang-tidy somehow: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10881/steps/build%20stage%201/logs/stdio -- Mehdi > On Mar 25, 2016, at 9:29 AM, Samuel Benzaquen via cfe-commits > wrote: > > Author: sbenza > Date: Fri Mar 25 11:29:30 2016 > New Re

Re: [PATCH] D18461: ObjCXX: Warn undeclared identifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL26: [ObjCXX] Warn undeclared identifiers. (authored by mren). Changed prior to commit: http://reviews.llvm.org/D18461?vs=51598&id=51667#toc Repository: rL LLVM http://reviews.llvm.org/D18461 Fi

r264444 - [ObjCXX] Warn undeclared identifiers.

Author: mren Date: Fri Mar 25 13:43:46 2016 New Revision: 26 URL: http://llvm.org/viewvc/llvm-project?rev=26&view=rev Log: [ObjCXX] Warn undeclared identifiers. Instantiation dependence were not being handled correctly for OpqaueValueExpr AST nodes. As a result, if an undeclared identifie

[PATCH] D18478: python bindings: expose the clang version string

john.tornblom created this revision. john.tornblom added reviewers: eliben, compnerd. john.tornblom added a subscriber: cfe-commits. http://reviews.llvm.org/D18478 Files: bindings/python/clang/cindex.py Index: bindings/python/clang/cindex.py

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

I believe r264428 fixes this problem. On Fri, Mar 25, 2016 at 2:18 PM, Mehdi Amini wrote: > Hi, > > I think this broke clang-tidy somehow: > http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10881/steps/build%20stage%201/logs/stdio > > -- > Mehdi > > > > > > On Mar 25, 2016, at 9:29

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

The link I provided is testing r264430... -- Mehdi > On Mar 25, 2016, at 12:25 PM, Samuel Benzaquen wrote: > > I believe r264428 fixes this problem. > > On Fri, Mar 25, 2016 at 2:18 PM, Mehdi Amini > wrote: > Hi, > > I think this broke clang-tidy somehow: > ht

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

Sorry, this is an unrelated problem. It is using brace-init lists and the supported MSVC version does not support them. I'll fix that. On Fri, Mar 25, 2016 at 3:27 PM, Mehdi Amini wrote: > The link I provided is testing r264430... > > -- > Mehdi > > On Mar 25, 2016, at 12:25 PM, Samuel Benzaquen

r264453 - [ASTMatchers] Don't use brace-init lists.

Author: sbenza Date: Fri Mar 25 14:41:32 2016 New Revision: 264453 URL: http://llvm.org/viewvc/llvm-project?rev=264453&view=rev Log: [ASTMatchers] Don't use brace-init lists. They are not supported everywhere yet. This fixes the MSVC build. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMa

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

Fixed in r264453. Sorry for the inconvenience. _Sam On Fri, Mar 25, 2016 at 3:31 PM, Samuel Benzaquen wrote: > Sorry, this is an unrelated problem. > It is using brace-init lists and the supported MSVC version does not > support them. > I'll fix that. > > > On Fri, Mar 25, 2016 at 3:27 PM, Mehd

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

Thanks! > On Mar 25, 2016, at 12:47 PM, Samuel Benzaquen wrote: > > Fixed in r264453. > Sorry for the inconvenience. > > _Sam > > On Fri, Mar 25, 2016 at 3:31 PM, Samuel Benzaquen > wrote: > Sorry, this is an unrelated problem. > It is using brace-init lists and the

[PATCH] D18479: [CodeGenCXX] Fix ItaniumCXXABI::getAlignmentOfExnObject to return 8-byte alignment on Darwin

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. r246985 made changes to give a higher alignment for exception objects on the grounds that Itanium says _Unwind_Exception should be "double-word" aligned and the structure is normally de

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli updated this revision to Diff 51676. carlo.bertolli added a comment. Simplify the search function and generalize by using a template. Repository: rL LLVM http://reviews.llvm.org/D18474 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/teams_codegen.cpp Index: test/OpenMP

Re: [PATCH] D18458: [CUDA] Mangle __host__ __device__ functions differently than __host__ or __device__ functions.

jlebar added a comment. > ! In http://reviews.llvm.org/D18458#383276, @jlebar wrote: > > > ! In http://reviews.llvm.org/D18458#383266, @rsmith wrote: > > > This makes the "`constexpr` implies `__host__` `__device__`" patch look > slightly questionable: two translation units defining the s

Re: [PATCH] D18458: [CUDA] Mangle __host__ __device__ functions differently than __host__ or __device__ functions.

rsmith added a comment. It seems like we have the following constraint: on host, no attributes must mangle the same as `__host__ __device__` and `constexpr` (and probably `__global__`?). Are there any others? What do we need to do to be ABI-compatible with NVCC? (And is that possible if we all

Re: [PATCH] D18479: [CodeGenCXX] Fix ItaniumCXXABI::getAlignmentOfExnObject to return 8-byte alignment on Darwin

On Fri, Mar 25, 2016 at 12:57 PM, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ahatanak created this revision. > ahatanak added a reviewer: rjmccall. > ahatanak added a subscriber: cfe-commits. > > r246985 made changes to give a higher alignment for exception objects on >

Re: [PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

sbenza updated this revision to Diff 51684. sbenza added a comment. Using new public hasAnyName API. http://reviews.llvm.org/D17811 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DanglingHandleCheck.cpp clang-tidy/misc/DanglingHandleCheck.h clang-tidy/misc/MiscTidyModule.cpp do

Re: [PATCH] D18479: [CodeGenCXX] Fix ItaniumCXXABI::getAlignmentOfExnObject to return 8-byte alignment on Darwin

> On Mar 25, 2016, at 2:06 PM, David Majnemer via cfe-commits > wrote: > > > > On Fri, Mar 25, 2016 at 12:57 PM, Akira Hatanaka via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > ahatanak created this revision. > ahatanak added a reviewer: rjmccall. > ahatanak added a subscriber:

r264463 - [analyzer] Add CIFIlter modeling to DeallocChecker.

Author: dcoughlin Date: Fri Mar 25 16:18:22 2016 New Revision: 264463 URL: http://llvm.org/viewvc/llvm-project?rev=264463&view=rev Log: [analyzer] Add CIFIlter modeling to DeallocChecker. The -dealloc method in CIFilter is highly unusual in that it will release instance variables belonging to its

Re: [PATCH] D18458: [CUDA] Mangle __host__ __device__ functions differently than __host__ or __device__ functions.

jlebar added a comment. In http://reviews.llvm.org/D18458#383719, @rsmith wrote: > It seems like we have the following constraint: on host, no attributes must > mangle the same as `__host__ __device__` and `constexpr` (and probably > `__global__`?). Yes to `__host__ __device__` and `constexpr

r264464 - Delete dead variable.

Author: rsmith Date: Fri Mar 25 16:46:44 2016 New Revision: 264464 URL: http://llvm.org/viewvc/llvm-project?rev=264464&view=rev Log: Delete dead variable. Modified: cfe/trunk/lib/Frontend/ASTUnit.cpp Modified: cfe/trunk/lib/Frontend/ASTUnit.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/t

r264466 - Store list of undefined-but-used objects in a deterministic order to fix

Author: rsmith Date: Fri Mar 25 16:49:43 2016 New Revision: 264466 URL: http://llvm.org/viewvc/llvm-project?rev=264466&view=rev Log: Store list of undefined-but-used objects in a deterministic order to fix non-deterministic diagnostics (and non-deterministic PCH files). Check these when building a

r264471 - Don't warn on "use" of undefined inline function that isn't actually an ODR

Author: rsmith Date: Fri Mar 25 17:29:27 2016 New Revision: 264471 URL: http://llvm.org/viewvc/llvm-project?rev=264471&view=rev Log: Don't warn on "use" of undefined inline function that isn't actually an ODR use. In order for this to fire, the function needed to be a templated function marked 'co

Re: [PATCH] D18458: [CUDA] Mangle __host__ __device__ functions differently than __host__ or __device__ functions.

rsmith added a comment. In http://reviews.llvm.org/D18458#383755, @jlebar wrote: > In http://reviews.llvm.org/D18458#383719, @rsmith wrote: > > > It seems like we have the following constraint: on host, no attributes must > > mangle the same as `__host__ __device__` and `constexpr` (and probably

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

On Fri, Mar 25, 2016 at 10:55 AM, David Blaikie via cfe-commits wrote: > > > On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits > wrote: >> >> Author: sbenza >> Date: Fri Mar 25 12:46:02 2016 >> New Revision: 264428 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=264428&view=re

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

rnk updated this revision to Diff 51697. rnk added a comment. - Address review comments, use a DenseMap instead of redoing lookup http://reviews.llvm.org/D18271 Files: include/clang/Basic/Diagnostic.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaDecl

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

On Fri, Mar 25, 2016 at 4:01 PM, Richard Smith wrote: > On Fri, Mar 25, 2016 at 10:55 AM, David Blaikie via cfe-commits > wrote: > > > > > > On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits > > wrote: > >> > >> Author: sbenza > >> Date: Fri Mar 25 12:46:02 2016 > >> New Revisi

Re: [PATCH] D14905: [constexpr-lambda] Support parsing of constexpr specifier (and its inference) on lambda expressions

rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: include/clang/Basic/DiagnosticParseKinds.td:769 @@ +768,3 @@ + "attribute specifier|'constexpr'}0">; +def err_lambda_declspecifier_repeated : Error< + "%select{'mutable'|'constexpr'}0 can

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

kkwli0 added a comment. Patch for the to and from clauses is in http://reviews.llvm.org/D18488. http://reviews.llvm.org/D15944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits