On Sat, Mar 12, 2016 at 7:50 PM, Nico Weber via cfe-commits
wrote:
> On Thu, Aug 8, 2013 at 8:32 PM, Hans Wennborg wrote:
>>
>> Author: hans
>> Date: Thu Aug 8 19:32:23 2013
>> New Revision: 188037
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=188037&view=rev
>> Log:
>> clang-cl: Support /s
On 13 March 2016 at 02:56, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Sat Mar 12 13:55:59 2016
> New Revision: 263344
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263344&view=rev
> Log:
> clang-cl: Add a test for the interaction of /Yc and /showIncludes.
>
> We almost get this ri
Alexander_Droste marked 3 inline comments as done.
Alexander_Droste added a comment.
> I still have to do an overall pass over this checker, but it looks much
> better than the first version!
:D
Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:47
@@ +46,3 @@
Alexander_Droste updated this revision to Diff 50548.
Alexander_Droste marked an inline comment as done.
Alexander_Droste added a comment.
- omit superfluous arguments passed to `generateNonFatalErrorNode`
http://reviews.llvm.org/D12761
Files:
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/
Alexander_Droste added inline comments.
Comment at: test/Analysis/MPIChecker.cpp:97
@@ +96,3 @@
+
+MPI_Isend(&buf, 1, MPI_DOUBLE, rank + 1, 6, MPI_COMM_WORLD, &sendReq1); //
expected-note{{Request is previously used by nonblocking call here. }}
+MPI_Irecv(&buf, 1, MPI_DOU
Author: aaboud
Date: Sun Mar 13 06:12:57 2016
New Revision: 263380
URL: http://llvm.org/viewvc/llvm-project?rev=263380&view=rev
Log:
Added test that covers changes in r263379.
Added:
cfe/trunk/test/CodeGen/debug-info-imported-entity.cpp
Added: cfe/trunk/test/CodeGen/debug-info-imported-entit
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
Looks good with the two test nits below fixed.
Comment at: test/CodeGen/mips-zero-sized-struct.c:8-10
@@ -7,5 +7,5 @@
-// O32: define void @fn28(%struct.T2* noalias sr
Alexander_Droste updated this revision to Diff 50551.
Alexander_Droste added a comment.
- create `MemRegion.cpp`, in order to set up test cases for `getDescriptiveName`
http://reviews.llvm.org/D16044
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
lib/StaticAnalyzer/Core/
Alexander_Droste added inline comments.
Comment at: test/Analysis/MemRegion.cpp:3
@@ +2,3 @@
+
+#include "MPIMock.h"
+
The problem about these tests is that they introduce a cyclic commit
dependency. MPI-Checker depends on `getDescriptiveName`. `getDescriptiveNam
Hi,
For code like:
namespace boost {
template
T lexical_cast(const C&) {
return T();
}
}
int g();
long long f(int p);
using namespace boost;
int main() {
auto s = lexical_cast(5);
auto p = lexical_cast(6);
long long z = lexical_cast(7);
long long a2 = lexical_cast("1488");
zaks.anna added a comment.
I'd be fine if we test this function with the usual regression tests by
observing the output of the MPI checker. We could update that test with more
checks once the function is updated.
With that approach, you'd be committing both patches at the same time.
http://re
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:136
@@ +135,3 @@
+ auto NodeIt = G.eop_begin();
+ const auto NodeEndIt = G.eop_end();
+
The analyzer does not do a good job tracking global variables. You might g
Alexander_Droste added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:136
@@ +135,3 @@
+ auto NodeIt = G.eop_begin();
+ const auto NodeEndIt = G.eop_end();
+
zaks.anna wrote:
> The analyzer does not do a good job tracking glo
Alexander_Droste added a comment.
> I'd be fine if we test this function with the usual regression tests by
> observing the output of the MPI checker. We could update that test with more
> checks once the function is updated.
> With that approach, you'd be committing both patches at the same ti
On Sat, Mar 12, 2016 at 3:42 PM, don hinton via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> hintonda created this revision.
> hintonda added a reviewer: rjmccall.
> hintonda added a subscriber: cfe-commits.
>
> Fix implicit copy ctor and copy assignment operator warnings
> when -Wdeprecated
Interesting question going forwards: We usually try to make test cases
+/-Asserts agnostic (not using named values), now that we have a flag for
it, should we not bother with that & just add the command line argument to
enable names when names make testing easier? Or do we think that'll make
tests
rjmccall added a comment.
It has side effects in the destructor. It's not copyable.
It could reasonably be made movable, however, now that we require C++11 as a
host requirement. (It was written before that was true.)
http://reviews.llvm.org/D18123
rjmccall added a comment.
Yes, I guess this is fine.
http://reviews.llvm.org/D18113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
I see, they weren't being set on declarations, just definitions. Yes, this
seems reasonable.
http://reviews.llvm.org/D18071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
rjmccall added a comment.
In http://reviews.llvm.org/D14737#373532, @pete wrote:
> I stepped through this one in the debugger to make sure I had it right.
>
> So the reason the bit cast ends up not being needed is because we restricted
> this optimization to cases where the result type "isObjCOb
hintonda added a comment.
LookupResult's copy ctor and assignment operator are used in
Sema::LookupInlineAsmField(). Looks like these were added back in December.
I'll remove the defaults, from this patch, but not sure how to handle
LookupInlineAsmField(). Will add author of that change.
OTO
Author: mehdi_amini
Date: Sun Mar 13 16:05:23 2016
New Revision: 263394
URL: http://llvm.org/viewvc/llvm-project?rev=263394&view=rev
Log:
Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names
option
Summary:
This flag is enabled by default in the driver when NDEBUG is s
Prazek created this revision.
Prazek added a reviewer: alexfh.
Prazek added a subscriber: cfe-commits.
todo fix docs.
Is there any better solution for the basic_string problem?
http://reviews.llvm.org/D18136
Files:
clang-tidy/boost/BoostTidyModule.cpp
clang-tidy/boost/CMakeLists.txt
clang
jbcoe planned changes to this revision.
jbcoe added a comment.
I'll move this to `modernize` and update docs when I get over my cold. Thanks
for the feedback.
http://reviews.llvm.org/D16376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
Author: nico
Date: Sun Mar 13 17:26:26 2016
New Revision: 263400
URL: http://llvm.org/viewvc/llvm-project?rev=263400&view=rev
Log:
Try to get cl-pch-showincludes passing on AArch64 bots.
Modified:
cfe/trunk/test/Driver/cl-pch-showincludes.cpp
Modified: cfe/trunk/test/Driver/cl-pch-showinclud
r263400 probably helps, sorry about the breakage.
As far as I can tell, ~all breakages of this bot are fixed by adding a `//
REQUIRES: x86-registered-target` to a new test, so that's something you
could add yourself to get your bots back green until whoever broke it comes
back online to take a loo
emaste added a comment.
Seems fine to me
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Pavel_Odintsov added a comment.
Hello, folks!
Sorry for bothering you because I'm just user of clang 3.8 and gcc 5.3 and
haven't any experience in compiler development. But I've hit issue mentioned in
this ticket.
I've C++ 11 enabled libraries (gRPC, protobuf, bson and mongodb c++ 11 client)
sfantao added a comment.
Ping!
http://reviews.llvm.org/D16749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Sun Mar 13 21:51:50 2016
New Revision: 263405
URL: http://llvm.org/viewvc/llvm-project?rev=263405&view=rev
Log:
Mark exception-throwing test as XFAIL when exceptions are disabled
Modified:
libcxx/trunk/test/std/utilities/memory/default.allocator/allocator.members/alloc
pirama created this revision.
pirama added reviewers: srhines, olista01.
pirama added a subscriber: cfe-commits.
r246764 handled __fp16 arguments and returns for AAPCS, but skipped this
handling for OpenCL. Simlar to OpenCL, RenderScript also handles __fp16
type natively.
This patch adds the -fn
faisalv created this revision.
faisalv added a reviewer: rsmith.
faisalv added a subscriber: cfe-commits.
Implement lambda capture of *this.
struct A {
int d = 10;
auto foo() { return [*this] (auto a) mutable { d+=a; return d; }; }
};
auto L = A{}.foo(); // A{}'s lifetime is gone.
// Below i
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D18105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: echristo
Date: Mon Mar 14 01:21:07 2016
New Revision: 263410
URL: http://llvm.org/viewvc/llvm-project?rev=263410&view=rev
Log:
Give the test a temporary output so it can be cleaned up.
Modified:
cfe/trunk/test/Driver/cl-pch-showincludes.cpp
Modified: cfe/trunk/test/Driver/cl-pch-show
35 matches
Mail list logo
