Author: abataev
Date: Mon Feb 8 03:29:13 2016
New Revision: 260077
URL: http://llvm.org/viewvc/llvm-project?rev=260077&view=rev
Log:
[OPENMP 4.5] Ccapture/codegen of private non-static data members.
OpenMP 4.5 introduces privatization of non-static data members of current class
in non-static mem
a.sidorin added inline comments.
Comment at: llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:792
@@ +791,3 @@
+
+const MemRegion* MemRegionManager::getMemSpaceForLocalVariable(const VarDecl
*D, llvm::PointerUnion &V) {
+ const StackFrameContext *STC = V.get();
---
Author: djasper
Date: Mon Feb 8 03:52:54 2016
New Revision: 260080
URL: http://llvm.org/viewvc/llvm-project?rev=260080&view=rev
Log:
clang-format: Fix weird alignment when not aligning after brackets.
Before:
(, //
ccc(a, //
hokein updated this revision to Diff 47167.
hokein marked 2 inline comments as done.
hokein added a comment.
Update test.
http://reviews.llvm.org/D16764
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/IncorrectRoundings.cpp
clang-tidy/misc/IncorrectRoundings.h
clang-tidy/misc/Misc
olista01 added a comment.
Ping?
http://reviews.llvm.org/D15040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Mon Feb 8 04:16:13 2016
New Revision: 260084
URL: http://llvm.org/viewvc/llvm-project?rev=260084&view=rev
Log:
[clang-tidy] Move incorrect-roundings to upstream.
Summary: This is originally implemented by Jacques Pienaar.
Reviewers: alexfh
Subscribers: cfe-commits, jpienaa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260084: [clang-tidy] Move incorrect-roundings to upstream.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16764?vs=47167&id=47169#toc
Repository:
rL LLVM
http://reviews.llvm
I believe you forgot to add cfe-commits as subscriber on the patch.
On Sun, Feb 7, 2016 at 12:51 PM Alexander Shukaev <
cl...@alexander.shukaev.name> wrote:
> On 12/14/2015 10:03 PM, Alexander Shukaev wrote:
> > On 12/11/2015 04:40 PM, Daniel Jasper wrote:
> >> Please submit patches to clang-form
Author: ibreger
Date: Mon Feb 8 06:36:48 2016
New Revision: 260088
URL: http://llvm.org/viewvc/llvm-project?rev=260088&view=rev
Log:
AVX512: Change builtin function name for scalar intrinsics. Add "mask" to
function name to reflect the function behavior.
Differential Revision: http://reviews.ll
The test is incompatible to i686-pc-win32. See also
http://bb.pgr.jp/builders/ninja-clang-i686-msc18-R/builds/5498
On Mon, Feb 8, 2016 at 6:33 PM Alexey Bataev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: abataev
> Date: Mon Feb 8 03:29:13 2016
> New Revision: 260077
>
> URL: h
Yes, I know, will be fixed in few minutes
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
08.02.2016 15:43, NAKAMURA Takumi пишет:
The test is incompatible to i686-pc-win32. See also
http://bb.pgr.jp/builders/ninja-clang-i686-msc18-R/builds/5498
On Mon, Feb 8, 20
Author: abataev
Date: Mon Feb 8 07:02:00 2016
New Revision: 260091
URL: http://llvm.org/viewvc/llvm-project?rev=260091&view=rev
Log:
[OPENMP] Fixed test incompat with MSVC
Modified:
cfe/trunk/test/OpenMP/parallel_private_codegen.cpp
Modified: cfe/trunk/test/OpenMP/parallel_private_codegen.c
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D16979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
http://reviews.llvm.org/D16926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
alexfh added a comment.
Looks good apart from renaming and one comment that's still relevant.
Comment at: clang-tidy/misc/UninitializedFieldCheck.cpp:178
@@ +177,3 @@
+
+ SmallPtrSet FieldsToInit;
+ fieldsRequiringInit(MemberFields, FieldsToInit);
What about t
DmitryPolukhin added a comment.
Hi Stefan,
What are your plans about this patch? The patch has number of comments about
Sema part from Aaron and me but in general there are no major issues with Sema
for the attribute.
As for mangling part I think recursive approach looks reasonable because
al
danielmarjamaki added inline comments.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:31
@@ +30,3 @@
+
+ Finder->addMatcher(returnStmt(has(Cast)), this);
+ Finder->addMatcher(varDecl(has(Cast)), this);
alexfh wrote:
> FYI, these matchers can be combi
danielmarjamaki updated this revision to Diff 47181.
danielmarjamaki added a comment.
Fixes according to review comments.
http://reviews.llvm.org/D16310
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MisplacedWideningCastCheck.cpp
clang-tidy/mis
danielmarjamaki updated this revision to Diff 47182.
danielmarjamaki marked 9 inline comments as done.
danielmarjamaki added a comment.
Fixed review comments
http://reviews.llvm.org/D16310
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MisplacedWi
danielmarjamaki added inline comments.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:79
@@ +78,3 @@
+
+void MisplacedWideningCastCheck::check(const MatchFinder::MatchResult &Result)
{
+ const auto *Cast = Result.Nodes.getNodeAs("Cast");
I looked in
Author: abataev
Date: Mon Feb 8 07:47:46 2016
New Revision: 260092
URL: http://llvm.org/viewvc/llvm-project?rev=260092&view=rev
Log:
[OPENMP] Fix test incompatibility with arm buildbots
Modified:
cfe/trunk/test/OpenMP/parallel_private_codegen.cpp
Modified: cfe/trunk/test/OpenMP/parallel_pri
Hal Finkel wrote on 05.02.2016 23:14:54:
> Just a general comment: I believe we've now fixed this bug for at
> least four different architectures (each time as a separate effort).
Yes. Unfortunately I only noticed that after I'd already spent half
a day debugging the problem from scratch on Sys
On Sun, Feb 7, 2016 at 12:52 PM, H.J. Lu wrote:
> On Sun, Feb 7, 2016 at 12:48 PM, Florian Weimer wrote:
>> * H. J. Lu:
>>
I tested GCC 5.3.1 and Clang 3.5.0.
GCC Clang
s0 non-emptynon-empty
s1 non-emptyempty
s2 non-emptyempty
s3
Author: chapuni
Date: Mon Feb 8 08:04:28 2016
New Revision: 260093
URL: http://llvm.org/viewvc/llvm-project?rev=260093&view=rev
Log:
clang/test/OpenMP/parallel_private_codegen.cpp: Fix an expression.
call x86_thiscallcc void @_ZN2SSC1ERi(
It matched to:
x86_this
Modified:
cfe/trunk/t
Thanks. It didn't pass with i686-mingw32.
// LAMBDA: call
// LAMBDA: call{{.*}} void [[OUTER_LAMBDA:@.+]](
call x86_thiscallcc void @_ZN2SSC1ERi(%struct.SS* %ss, i32*
dereferenceable(4) @_ZZ4mainE5sivar)
call x86_thiscallcc void @"_ZZ4mainENK3$_0clEv"(%class.anon* %temp.lvalue)
The latte
Ok, thanks a lot! Hope it will fix win-based buildbots completely.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
08.02.2016 17:11, NAKAMURA Takumi пишет:
Thanks. It didn't pass with i686-mingw32.
// LAMBDA: call
// LAMBDA: call{{.*}} void [[OUTER_LAMBDA:@.+<
Author: aaronballman
Date: Mon Feb 8 08:25:25 2016
New Revision: 260096
URL: http://llvm.org/viewvc/llvm-project?rev=260096&view=rev
Log:
Expand the simplify boolean expression check to handle implicit conversion of
integral types to bool and improve the handling of implicit conversion of
membe
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r260096, sorry for the delay. You should speak to Chris Lattner about
getting commit privileges so that you're not blocked on one of us being
available to commit on your behalf again.
http://reviews.llvm.org/D16308
Author: aaronballman
Date: Mon Feb 8 08:37:56 2016
New Revision: 260097
URL: http://llvm.org/viewvc/llvm-project?rev=260097&view=rev
Log:
Reverting r260096; it causes build bot failures:
http://bb.pgr.jp/builders/cmake-clang-tools-x86_64-linux/builds/23351
http://lab.llvm.org:8011/builders/clang
aaron.ballman added a comment.
This is causing build bot failures:
http://bb.pgr.jp/builders/cmake-clang-tools-x86_64-linux/builds/23351
http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/492
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/812
The failure is not obvious to m
On 7 February 2016 at 17:29, Samuel F Antao wrote:
> Hi Renato,
>
> This is not related with my patch, I'm afraid your buildbot won't go green
> with the revert. This looks to be related with r259976. My patch
> triggered the problem because it touched a CmakeList.txt. The code itself
> is comple
No worries, sure, I'll do that.
Thanks!
Samuel
From: Renato Golin
To: Samuel F Antao/Watson/IBM@IBMUS
Cc: Clang Commits
Date: 02/08/2016 09:57 AM
Subject:Re: r259985 - Re-apply r259977 - [OpenMP] Reorganize code to
allow specialized code generation for differe
On 8 February 2016 at 13:54, H.J. Lu wrote:
> On Sun, Feb 7, 2016 at 12:52 PM, H.J. Lu wrote:
>
> The standard-layout POD is well defined:
>
> https://en.wikipedia.org/wiki/C%2B%2B11#Modification_to_the_definition_of_plain_old_data
>
> Here is the updated proposal for Intel386, x86-64 and IA MCU
danielmarjamaki added inline comments.
Comment at: docs/clang-tidy/checks/misc-misplaced-widening-cast.rst:2
@@ +1,3 @@
+.. title:: clang-tidy - misc-misplaced-widening-cast
+
+misc-misplaced-widening-cast
For information, it seem I had to use -DLLVM_ENABLE_SPHINX
Author: alexfh
Date: Mon Feb 8 09:09:34 2016
New Revision: 260099
URL: http://llvm.org/viewvc/llvm-project?rev=260099&view=rev
Log:
[clang-tidy] Fix an error in .rst
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-incorrect-roundings.rst
Modified:
clang-tools-extra/trunk/docs
Author: alexfh
Date: Mon Feb 8 09:09:39 2016
New Revision: 260100
URL: http://llvm.org/viewvc/llvm-project?rev=260100&view=rev
Log:
[clang-tidy] Reshuffled paragraphs a bit, added contents.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/docs/cl
On Mon, Feb 8, 2016 at 7:02 AM, Jonathan Wakely wrote:
> On 8 February 2016 at 13:54, H.J. Lu wrote:
>> On Sun, Feb 7, 2016 at 12:52 PM, H.J. Lu wrote:
>>
>> The standard-layout POD is well defined:
>>
>> https://en.wikipedia.org/wiki/C%2B%2B11#Modification_to_the_definition_of_plain_old_data
>>
Author: aaronballman
Date: Mon Feb 8 09:52:13 2016
New Revision: 260104
URL: http://llvm.org/viewvc/llvm-project?rev=260104&view=rev
Log:
Move static functions returning UDTs outside of the extern "C" block. Silences
an MSVC warning, and reduces the number of exported symbols.
Modified:
cfe
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good after fixing capitalization in comments.
Thank you!
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:32
@@ +31,3 @@
+ has(C
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D16987
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
On 8 February 2016 at 15:42, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 7:02 AM, Jonathan Wakely wrote:
>> On 8 February 2016 at 13:54, H.J. Lu wrote:
>>> On Sun, Feb 7, 2016 at 12:52 PM, H.J. Lu wrote:
>>>
>>> The standard-layout POD is well defined:
>>>
>>> https://en.wikipedia.org/wiki/C%2B%2B1
Author: sfantao
Date: Mon Feb 8 09:59:20 2016
New Revision: 260106
URL: http://llvm.org/viewvc/llvm-project?rev=260106&view=rev
Log:
Re-apply for the 2nd-time r259977 - [OpenMP] Reorganize code to allow
specialized code generation for different devices.
This was reverted by r260036, but was not
On Mon, Feb 8, 2016 at 7:59 AM, Jonathan Wakely wrote:
> On 8 February 2016 at 15:42, H.J. Lu wrote:
>> On Mon, Feb 8, 2016 at 7:02 AM, Jonathan Wakely
>> wrote:
>>> On 8 February 2016 at 13:54, H.J. Lu wrote:
On Sun, Feb 7, 2016 at 12:52 PM, H.J. Lu wrote:
The standard-layout
alexfh added a comment.
Sorry for the long delay. Currently rather swamped.
Haojian, could you take a look at this patch?
http://reviews.llvm.org/D16535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260107: [clang-tidy] Fix assertion failure on `at` function
in modernize-loop-convert. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16926?vs=47019&id=47204#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260105: [clang-tidy] Correct IncorrectRoundings namespace.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16987?vs=47199&id=47202#toc
Repository:
rL LLVM
http://reviews.llvm
Author: hokein
Date: Mon Feb 8 10:05:39 2016
New Revision: 260108
URL: http://llvm.org/viewvc/llvm-project?rev=260108&view=rev
Log:
[clang-tidy] Some improvements in 'misc-definitions-in-headers' check.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D
Author: hokein
Date: Mon Feb 8 09:59:42 2016
New Revision: 260107
URL: http://llvm.org/viewvc/llvm-project?rev=260107&view=rev
Log:
[clang-tidy] Fix assertion failure on `at` function in modernize-loop-convert.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.ll
alexfh added inline comments.
Comment at: test/clang-tidy/misc-virtual-near-miss.cpp:1
@@ -1,2 +1,2 @@
// RUN: %check_clang_tidy %s misc-virtual-near-miss %t
The check shouldn't make any changes to template classes based on any single
instantiation. An easy wa
On 8 February 2016 at 16:05, H.J. Lu wrote:
> My understanding is
>
> A type that is standard-layout means that it orders and packs its
> members in a way that is compatible with C.
>
> What is the corresponding compatible type in C?
An empty structure, such as struct A.
One of the requirements f
On Mon, Feb 8, 2016 at 11:05 AM, Haojian Wu via cfe-commits
wrote:
> Author: hokein
> Date: Mon Feb 8 10:05:39 2016
> New Revision: 260108
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260108&view=rev
> Log:
> [clang-tidy] Some improvements in 'misc-definitions-in-headers' check.
>
> Reviewers
Author: hokein
Date: Mon Feb 8 09:54:30 2016
New Revision: 260105
URL: http://llvm.org/viewvc/llvm-project?rev=260105&view=rev
Log:
[clang-tidy] Correct IncorrectRoundings namespace.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D16987
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260108: [clang-tidy] Some improvements in
'misc-definitions-in-headers' check. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16979?vs=47178&id=47205#toc
Repository:
rL LLVM
On Mon, Feb 8, 2016 at 8:15 AM, Jonathan Wakely wrote:
> On 8 February 2016 at 16:05, H.J. Lu wrote:
>> My understanding is
>>
>> A type that is standard-layout means that it orders and packs its
>> members in a way that is compatible with C.
>>
>> What is the corresponding compatible type in C?
>
sepavloff created this revision.
sepavloff added a reviewer: rsmith.
sepavloff added a subscriber: cfe-commits.
Previously if a file-level function was defined inside befriending
template class, it was treated as defined in the code like:
```
void func(int);
template class C1 {
friend void
alexfh added a comment.
Hi Richard,
Thank you for working on this. The script has been begging for refactoring for
a while ;) A couple of initial comments, and while I'm looking further into
into this patch, could you find other possible usages (in currently existing
tests) of the new function
jeanphilippeD added a comment.
Ping,
Hi Daniel,
Sorry, should I have put someone else as reviewer, I see the previous
committers for this file where Manuel Klimek, Hans Wennborg and Marek Kurdej.
Should have i added any or all of them.
I thought it made sense to put you originally since you up
vsk added a comment.
Thanks! This is definitely the right fix, since it fixes up
implicitly-generated move constructors as well. However, I think the test can
be simpler (while also checking that move constructors are handled correctly).
E.g:
struct A {
void operator=(const A &a) {}
LegalizeAdulthood added inline comments.
Comment at: test/clang-tidy/check_clang_tidy.py:122
@@ -40,2 +121,3 @@
parser.add_argument('-resource-dir')
+ parser.add_argument('--header-filter')
parser.add_argument('input_file_name')
alexfh wrote:
> There's no n
arsenm created this revision.
arsenm added a subscriber: cfe-commits.
Description copied from intrinsic
http://reviews.llvm.org/D16993
Files:
docs/LanguageExtensions.rst
Index: docs/LanguageExtensions.rst
===
--- docs/LanguageExt
ayartsev added a comment.
Ping.
http://reviews.llvm.org/D16317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood added a comment.
I wrote:
> Repeated searching of the string for the literal delimiter could be avoided
> by changing the routine to search for the delimiter. If present, it could
> examine the characters following the literal to make the literal more unique
> and then contin
Author: adrian
Date: Mon Feb 8 11:03:28 2016
New Revision: 260113
URL: http://llvm.org/viewvc/llvm-project?rev=260113&view=rev
Log:
Use llvm::TempDIScope instead of manually deleting a temporary MDNode.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib/CodeGen/CGDebugI
> On Feb 6, 2016, at 12:38 PM, Duncan P. N. Exon Smith
> wrote:
>
>>
>> On 2016-Feb-06, at 10:39, Adrian Prantl via cfe-commits
>> wrote:
>>
>> Author: adrian
>> Date: Sat Feb 6 12:39:34 2016
>> New Revision: 260002
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=260002&view=rev
>> Log
Author: awatry
Date: Mon Feb 8 11:07:21 2016
New Revision: 260114
URL: http://llvm.org/viewvc/llvm-project?rev=260114&view=rev
Log:
math: Add frexp ported from amd-builtins
The float implementation is almost a direct port from the amd-builtins,
but instead of just having a scalar and float4 impl
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D16951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
davidxl updated this revision to Diff 47217.
davidxl added a comment.
Simplified test case suggested by Vedant.
http://reviews.llvm.org/D16947
Files:
lib/CodeGen/CGClass.cpp
test/Profile/def-assignop.cpp
Index: test/Profile/def-assignop.cpp
=
On 02/08/2016 12:32 PM, Manuel Klimek wrote:
I believe you forgot to add cfe-commits as subscriber on the patch.
On Sun, Feb 7, 2016 at 12:51 PM Alexander Shukaev <
cl...@alexander.shukaev.name> wrote:
On 12/14/2015 10:03 PM, Alexander Shukaev wrote:
On 12/11/2015 04:40 PM, Daniel Jasper wrot
Author: marshall
Date: Mon Feb 8 11:38:23 2016
New Revision: 260115
URL: http://llvm.org/viewvc/llvm-project?rev=260115&view=rev
Log:
Clean up a test; get rid of hard-wired char/wchar_t code for template fns that
take any char type. Prep work for PR#26503
Modified:
libcxx/trunk/test/std/in
On Mon, Feb 8, 2016 at 7:59 AM, Jonathan Wakely wrote:
>>> A type is a standard-layout type, or it isn't.
>>
>> How about "An empty record is standard-layout Plain Old Data (POD)
>> type and ..."?
>
> That's redundant, all POD types are standard-layout types.
>
Apparently, not all standard-layout
Author: xur
Date: Mon Feb 8 12:12:41 2016
New Revision: 260116
URL: http://llvm.org/viewvc/llvm-project?rev=260116&view=rev
Log:
Fix missing space (NFC)
Fixed the inconsistently placed : (missing space) introduced in in r259811.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticDriverKin
vsk added a comment.
Lgtm.
http://reviews.llvm.org/D16947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 8 February 2016 at 17:58, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 7:59 AM, Jonathan Wakely wrote:
A type is a standard-layout type, or it isn't.
>>>
>>> How about "An empty record is standard-layout Plain Old Data (POD)
>>> type and ..."?
>>
>> That's redundant, all POD types are standard-
nemanjai updated this revision to Diff 47223.
nemanjai added a comment.
Fixed the naming, indentation and removed the use of dyn_cast for types.
Repository:
rL LLVM
http://reviews.llvm.org/D15120
Files:
bindings/python/clang/cindex.py
include/clang-c/Index.h
include/clang/AST/ASTContex
On 8 February 2016 at 18:26, Jonathan Wakely wrote:
> On 8 February 2016 at 17:58, H.J. Lu wrote:
>> On Mon, Feb 8, 2016 at 7:59 AM, Jonathan Wakely
>> wrote:
> A type is a standard-layout type, or it isn't.
How about "An empty record is standard-layout Plain Old Data (POD)
ty
On Mon, Feb 8, 2016 at 10:30 AM, Jonathan Wakely wrote:
> On 8 February 2016 at 18:26, Jonathan Wakely wrote:
>> On 8 February 2016 at 17:58, H.J. Lu wrote:
>>> On Mon, Feb 8, 2016 at 7:59 AM, Jonathan Wakely
>>> wrote:
>> A type is a standard-layout type, or it isn't.
>
> How about
On 8 February 2016 at 18:31, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 10:30 AM, Jonathan Wakely
> wrote:
>> On 8 February 2016 at 18:26, Jonathan Wakely wrote:
>>> On 8 February 2016 at 17:58, H.J. Lu wrote:
On Mon, Feb 8, 2016 at 7:59 AM, Jonathan Wakely
wrote:
>>> A type is a s
Vedant Kumar writes:
> vsk created this revision.
> vsk added a reviewer: bogner.
> vsk added a subscriber: cfe-commits.
>
> When handling 'if' statements, we crash if the condition and the consequent
> branch are spanned by a single macro expansion.
>
> The crash occurs because of a sanity 'reset
On Mon, Feb 8, 2016 at 10:46 AM, Jonathan Wakely wrote:
> On 8 February 2016 at 18:31, H.J. Lu wrote:
>> On Mon, Feb 8, 2016 at 10:30 AM, Jonathan Wakely
>> wrote:
>>> On 8 February 2016 at 18:26, Jonathan Wakely wrote:
On 8 February 2016 at 17:58, H.J. Lu wrote:
> On Mon, Feb 8, 2016
Author: davidxl
Date: Mon Feb 8 13:14:14 2016
New Revision: 260126
URL: http://llvm.org/viewvc/llvm-project?rev=260126&view=rev
Log:
Simplify test cases
Modified:
cfe/trunk/test/Profile/def-ctors.cpp
cfe/trunk/test/Profile/def-dtors.cpp
Modified: cfe/trunk/test/Profile/def-ctors.cpp
URL
vsk updated this revision to Diff 47229.
vsk added a comment.
- Made the check a bit more general by moving it to `propagateCounts`.
- Added 3 more tests.
http://reviews.llvm.org/D16934
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/macro-expressions.cpp
Index: test/Coverag
Author: rsmith
Date: Mon Feb 8 13:10:14 2016
New Revision: 260124
URL: http://llvm.org/viewvc/llvm-project?rev=260124&view=rev
Log:
Remove dead code.
Modified:
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/lib/Sema/SemaLookup.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/l
On Mon, Feb 8, 2016 at 11:14 AM, Xinliang David Li via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: davidxl
> Date: Mon Feb 8 13:14:14 2016
> New Revision: 260126
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260126&view=rev
> Log:
> Simplify test cases
>
It's handy to mention t
On Mon, Feb 8, 2016 at 10:46 AM, Jonathan Wakely via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 8 February 2016 at 18:31, H.J. Lu wrote:
> > On Mon, Feb 8, 2016 at 10:30 AM, Jonathan Wakely
> wrote:
> >> On 8 February 2016 at 18:26, Jonathan Wakely
> wrote:
> >>> On 8 February 2016 a
Hi,
I created a mailing list to discuss Linux specific,.processor independent
modification and extension of generic System V Application Binary Interface:
https://groups.google.com/d/forum/linux-abi
I will start to document existing Linux extensions, like STT_GNU_IFUNC.
I will propose some new e
On 08/02/16 20:10, Richard Smith via cfe-commits wrote:
Author: rsmith
Date: Mon Feb 8 13:10:14 2016
New Revision: 260124
URL: http://llvm.org/viewvc/llvm-project?rev=260124&view=rev
Log:
Remove dead code.
Modified:
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/lib/Sema/SemaLooku
This looks like a change to clang - could you test it in clang (& review it
on cfe-commits instead of llvm-commits)?
On Sat, Feb 6, 2016 at 11:57 AM, David Li via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> davidxl created this revision.
> davidxl added a reviewer: vsk.
> davidxl added sub
Author: vedantk
Date: Mon Feb 8 13:25:45 2016
New Revision: 260129
URL: http://llvm.org/viewvc/llvm-project?rev=260129&view=rev
Log:
[Coverage] Fix crash when handling certain macro expansions
When handling 'if' statements, we crash if the condition and the consequent
branch are spanned by a sin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260129: [Coverage] Fix crash when handling certain macro
expansions (authored by vedantk).
Changed prior to commit:
http://reviews.llvm.org/D16934?vs=47230&id=47232#toc
Repository:
rL LLVM
http://re
Both cfe-commits and llvm-commits are cc'ed.
David
On Mon, Feb 8, 2016 at 11:29 AM, David Blaikie wrote:
> This looks like a change to clang - could you test it in clang (& review it
> on cfe-commits instead of llvm-commits)?
>
> On Sat, Feb 6, 2016 at 11:57 AM, David Li via cfe-commits
> wrote
vsk updated this revision to Diff 47230.
vsk added a comment.
- Check that we don't crash on a nested 'STMT' test case.
http://reviews.llvm.org/D16934
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/macro-expressions.cpp
Index: test/CoverageMapping/macro-expressions.cpp
* H. J. Lu:
> I created a mailing list to discuss Linux specific,.processor independent
> modification and extension of generic System V Application Binary Interface:
>
> https://groups.google.com/d/forum/linux-abi
>
> I will start to document existing Linux extensions, like STT_GNU_IFUNC.
> I wil
thakis added a comment.
ping :-)
http://reviews.llvm.org/D16552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 8 February 2016 at 19:23, Richard Smith wrote:
> "POD for the purpose of layout" is defined in the Itanium C++ ABI here:
>
> http://mentorembedded.github.io/cxx-abi/abi.html#definitions
Thanks. So there's no problem using "POD for the purposes of layout",
and the change to "POD for the purpos
* H.J. Lu [2016-02-08 11:24:53 -0800]:
> I created a mailing list to discuss Linux specific,.processor independent
> modification and extension of generic System V Application Binary Interface:
>
> https://groups.google.com/d/forum/linux-abi
>
> I will start to document existing Linux extensions
On Mon, Feb 8, 2016 at 11:32 AM, Florian Weimer wrote:
> * H. J. Lu:
>
>> I created a mailing list to discuss Linux specific,.processor independent
>> modification and extension of generic System V Application Binary Interface:
>>
>> https://groups.google.com/d/forum/linux-abi
>>
>> I will start t
On Mon, Feb 8, 2016 at 11:33 AM, Szabolcs Nagy wrote:
> * H.J. Lu [2016-02-08 11:24:53 -0800]:
>> I created a mailing list to discuss Linux specific,.processor independent
>> modification and extension of generic System V Application Binary Interface:
>>
>> https://groups.google.com/d/forum/linux
On Mon, Feb 8, 2016 at 11:25 AM, Vassil Vassilev
wrote:
> On 08/02/16 20:10, Richard Smith via cfe-commits wrote:
>
>> Author: rsmith
>> Date: Mon Feb 8 13:10:14 2016
>> New Revision: 260124
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=260124&view=rev
>> Log:
>> Remove dead code.
>>
>> Mod
On Mon, Feb 8, 2016 at 9:25 AM, David Li via llvm-commits <
llvm-comm...@lists.llvm.org> wrote:
> davidxl updated this revision to Diff 47217.
> davidxl added a comment.
>
> Simplified test case suggested by Vedant.
>
>
> http://reviews.llvm.org/D16947
>
> Files:
> lib/CodeGen/CGClass.cpp
> te
On 08/02/16 20:38, Richard Smith wrote:
On Mon, Feb 8, 2016 at 11:25 AM, Vassil Vassilev
mailto:v.g.vassi...@gmail.com>> wrote:
On 08/02/16 20:10, Richard Smith via cfe-commits wrote:
Author: rsmith
Date: Mon Feb 8 13:10:14 2016
New Revision: 260124
URL: h
1 - 100 of 188 matches
Mail list logo
