r259871 - [CMake] One more try to fix this.

2016-02-04 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Thu Feb 4 21:02:40 2016 New Revision: 259871 URL: http://llvm.org/viewvc/llvm-project?rev=259871&view=rev Log: [CMake] One more try to fix this. This change will catch any bots that generated the order file that GNU ld doesn't like and delete it before trying to generate

Re: r259862 - [CMake] Improve the clang order-file generation workflow

2016-02-04 Thread Chris Bieneman via cfe-commits
Actually r259871 includes the code to cleanup the “bad” order file… -Chris > On Feb 4, 2016, at 7:02 PM, Chris Bieneman wrote: > > I pushed a speculative fix for this in r259870. I’m unable to reproduce > locally. There are a few bots that hit the same issue, so I’m watching them. > > -Chris

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

2016-02-04 Thread Xiuli PAN via cfe-commits
pxli168 added a comment. Hi Pekka/Anastasia, I find that most of the attribute parses was done in ParseDecl.cpp, should this also be in there? Thanks Xiuli Comment at: lib/Parse/ParseStmt.cpp:2214 @@ +2213,3 @@ + +bool Parser::ParseOpenCLUnrollHintAttribute(ParsedAttributes &

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

2016-02-04 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r259872 - Revert "[CMake] Improve the clang order-file generation workflow"

2016-02-04 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Thu Feb 4 21:40:37 2016 New Revision: 259872 URL: http://llvm.org/viewvc/llvm-project?rev=259872&view=rev Log: Revert "[CMake] Improve the clang order-file generation workflow" This reverts commit r259862, and attempts to fix builder CMakeCaches. Will try this again some

r259873 - [CMake] One more try to make CMake clean up after itself

2016-02-04 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Thu Feb 4 21:59:08 2016 New Revision: 259873 URL: http://llvm.org/viewvc/llvm-project?rev=259873&view=rev Log: [CMake] One more try to make CMake clean up after itself Seriously... CMake... You're on my list... Modified: cfe/trunk/CMakeLists.txt cfe/trunk/tools/d

r259874 - CodeGen: correct Windows ARM C++ assertion

2016-02-04 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 4 22:12:40 2016 New Revision: 259874 URL: http://llvm.org/viewvc/llvm-project?rev=259874&view=rev Log: CodeGen: correct Windows ARM C++ assertion Because the Decl is explicitly passed as nullptr further up the call chain, it is possible to invoke isa on a nullptr,

r259875 - [analyzer] Suppress localization diagnostics in debug classes and methods.

2016-02-04 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Thu Feb 4 22:22:15 2016 New Revision: 259875 URL: http://llvm.org/viewvc/llvm-project?rev=259875&view=rev Log: [analyzer] Suppress localization diagnostics in debug classes and methods. If the class or method name case-insensitively contains the term "debug", suppress war

Re: r259862 - [CMake] Improve the clang order-file generation workflow

2016-02-04 Thread Richard Smith via cfe-commits
This build might be using gold, I don't recall how that machine is configured. I won't be able to test the fix until tomorrow, hopefully the bits will give you enough. On 4 Feb 2016 7:07 p.m., "Chris Bieneman" wrote: > Actually r259871 includes the code to cleanup the “bad” order file… > > -Chris

Re: [PATCH] D16906: [Parser] Perform CachedTokens update dependent on token consume request

2016-02-04 Thread Doug Gregor via cfe-commits
doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D16906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

2016-02-04 Thread Richard Trieu via cfe-commits
rtrieu added a comment. In http://reviews.llvm.org/D15636#343856, @AndyG wrote: > In your case, the first string would be highlighted only. Yes, I see what > you mean. Is it possible to have multiple ranges for the diagnostic? By > which I mean, to produce the following: > > test.cpp:x:y:

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

2016-02-04 Thread Xiuli PAN via cfe-commits
pxli168 added a comment. Hi Anastasia/Pekka, https://www.khronos.org/bugzilla/show_bug.cgi?id=1459 Bug report has been sent. Thanks Xiuli http://reviews.llvm.org/D15914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: r259862 - [CMake] Improve the clang order-file generation workflow

2016-02-04 Thread Nathan Wilson via cfe-commits
I'm using gold and it seems like it's been fixed for me. On Thu, Feb 4, 2016 at 10:33 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This build might be using gold, I don't recall how that machine is > configured. I won't be able to test the fix until tomorrow, hopefully

Re: r259862 - [CMake] Improve the clang order-file generation workflow

2016-02-04 Thread Chris Bieneman via cfe-commits
I reverted the patch and made a pile of other changes to fix up the CMake caches on bots. They should all recover now. -Chris > On Feb 4, 2016, at 8:33 PM, Richard Smith wrote: > > This build might be using gold, I don't recall how that machine is > configured. I won't be able to test the fix

<    1   2