wolfgangp added a comment.
> Clang (with patch)
> 3, 5, 4, 5, 7
> 9, 11, 10, 11, 14
>
> So that's somewhat problematic - we shouldn't visit 11 at all. (but we are
> today, as is GCC... so maybe NBD?)
Well, if op&& is overloaded, wouldn't we lose the short-circuit property? If so
it ma
Richard Smith: Is there a reasonable way to get the ')' of an "if ()"
expression in the AST? Is it just a matter of going down and playing games
with source locations/lexing to get the token after the end location of the
condition expression?
On Thu, Jan 28, 2016 at 4:57 PM, Wolfgang Pieb via cfe-
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, piotrdz,
aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This is fix for PR26295. I added configuration option to
readab
> On Jan 28, 2016, at 4:57 PM, David Blaikie wrote:
>
> +Adrian for Apple/LLDB perspective
>
> One way to merge the tests would be to add another command line argument into
> DwarfDebug (see the way the split-dwarf command line argument is used), just
> for testing purposes. The command line
Author: echristo
Date: Thu Jan 28 19:35:55 2016
New Revision: 259138
URL: http://llvm.org/viewvc/llvm-project?rev=259138&view=rev
Log:
Add the clang debug info test directory to .gitignore as it's managed
separately.
Modified:
cfe/trunk/.gitignore
Modified: cfe/trunk/.gitignore
URL:
http:/
Author: echristo
Date: Thu Jan 28 19:35:53 2016
New Revision: 259137
URL: http://llvm.org/viewvc/llvm-project?rev=259137&view=rev
Log:
Use a consistent spelling for vtables.
Modified:
cfe/trunk/include/clang/Basic/TargetCXXABI.h
cfe/trunk/lib/CodeGen/CGClass.cpp
cfe/trunk/lib/CodeGen/
pxli168 added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:698
@@ +697,3 @@
+// tgmath.h, time.h, wchar.h and wctype.h are not available and cannot
+// be included by a program.
+if (S.getLangOpts().OpenCL &&
I think the
> C99 sta
pxli168 added inline comments.
Comment at: include/clang/Basic/DiagnosticParseKinds.td:906
@@ +905,3 @@
+def err_opencl_unroll_hint_on_non_loop : Error<
+ "OpenCL only supports opencl_unroll_hint on for, while, and do statements">;
+
you can change it to opencl_u
LegalizeAdulthood updated this revision to Diff 46333.
LegalizeAdulthood marked 3 inline comments as done.
LegalizeAdulthood added a comment.
Herald added a subscriber: klimek.
Update from review comments.
Extend analysis of newlines to prevent pathological raw strings from being
introduced.
Exte
bruno updated this revision to Diff 46332.
bruno added a comment.
Update the patch to use ArrayRef and remove a misleading assertion.
Richard, any more comments regarding this approach?
Thanks,
http://reviews.llvm.org/D15173
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPCaching.cpp
l
probinson added a comment.
Ping. FWIW in today's DWARF meeting, we agreed that the Appendix D example of
an anonymous namespace should have an explicit import from the containing scope
(see DWARF v4, Figure 57 on p.233; it was essentially unchanged in the v5
draft).
http://reviews.llvm.org/D
LegalizeAdulthood marked 4 inline comments as done.
Comment at: clang-tidy/readability/RedundantControlFlowCheck.cpp:59
@@ +58,3 @@
+ CompoundStmt::const_reverse_body_iterator last = Block->body_rbegin();
+ if (const auto *Return = dyn_cast(*last)) {
+issueDiagnostic(Result,
LegalizeAdulthood updated this revision to Diff 46334.
LegalizeAdulthood marked an inline comment as done.
LegalizeAdulthood added a comment.
Update from review comments
http://reviews.llvm.org/D16259
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.
MatzeB created this revision.
MatzeB added reviewers: chandlerc, reames, echristo.
MatzeB added a subscriber: cfe-commits.
MatzeB set the repository for this revision to rL LLVM.
Herald added a subscriber: mcrosier.
These sets perform linear searching in small mode so it is never a good
idea to us
doug.gregor accepted this revision.
doug.gregor added a comment.
This approach looks great to me.
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood updated this revision to Diff 46341.
LegalizeAdulthood added a comment.
Update from review comments, add test case
http://reviews.llvm.org/D8149
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal
Author: ctopper
Date: Thu Jan 28 22:01:09 2016
New Revision: 259156
URL: http://llvm.org/viewvc/llvm-project?rev=259156&view=rev
Log:
Remove unnecessary forward declaration. NFC
Modified:
cfe/trunk/include/clang/Basic/SourceManager.h
Modified: cfe/trunk/include/clang/Basic/SourceManager.h
UR
Author: nwilson
Date: Thu Jan 28 22:43:59 2016
New Revision: 259159
URL: http://llvm.org/viewvc/llvm-project?rev=259159&view=rev
Log:
[Concepts] Implement a portion of Concepts TS[dcl.spec.concept]p5 and p6:
Diagnose if the return type of a function concept or declaration type of a
variable concep
This revision was automatically updated to reflect the committed changes.
nwilson marked an inline comment as done.
Closed by commit rL259159: [Concepts] Implement a portion of Concepts
TS[dcl.spec.concept]p5 and p6: (authored by nwilson).
Changed prior to commit:
http://reviews.llvm.org/D16163
I will merge this fix
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
28.01.2016 22:18, Hans Wennborg пишет:
> Alexey: you're the owner of openmp in Clang.
>
> Can you comment on what should be merged here?
>
> On Tue, Jan 26, 2016 at 3:43 PM, Jack Howarth
> wrote
rjmccall added a comment.
In http://reviews.llvm.org/D15120#337975, @hubert.reinterpretcast wrote:
> In http://reviews.llvm.org/D15120#337654, @rjmccall wrote:
>
> > In http://reviews.llvm.org/D15120#337552, @hubert.reinterpretcast wrote:
> >
> > > It remains that the present standardization effo
Committed revision 259160
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
29.01.2016 7:57, Bataev, Alexey пишет:
> I will merge this fix
>
> Best regards,
> Alexey Bataev
> =
> Software Engineer
> Intel Compiler Team
>
> 28.01.2016 22:18, Hans Wennborg
gottesmm updated this revision to Diff 46354.
gottesmm added a comment.
Added documentation.
http://reviews.llvm.org/D16708
Files:
include/clang/Basic/Attr.td
lib/Sema/SemaDeclAttr.cpp
test/SemaObjC/attr-cf_no_release.m
Index: test/SemaObjC/attr-cf_no_release.m
==
congliu updated this revision to Diff 46359.
congliu added a comment.
- Fixed bugs introduced by getCanonicalDecl. Has errs log.
- Cleared up logs.
- Added mathcers for static method and overloaded operator.
- Change key type of map from string to pointer to imporve performance.
- Change implement
congliu updated this revision to Diff 46360.
congliu added a comment.
- Fixed a nit in test file.
http://reviews.llvm.org/D16587
Files:
clang-tidy/misc/VirtualNearMissCheck.cpp
clang-tidy/misc/VirtualNearMissCheck.h
docs/clang-tidy/checks/misc-virtual-near-miss.rst
test/clang-tidy/misc-
Hi,
On 01/28/2016 09:25 PM, Hans Wennborg via cfe-commits wrote:
> I don't think we have a specific code owner for OpenCL in Clang, which
> means Richard is the owner.
FYI, in a separate thread, there's an attempt to elect Anastasia as one.
--
Pekka
_
101 - 126 of 126 matches
Mail list logo
