Re: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

2016-01-24 Thread Katya Romanova via cfe-commits
kromanova added a comment. I did some build time measurement on a big game code where the the intrisics are heavily used (PHC was enabled). The presence of comments didn't make any noticeable difference. Sean did similar measurements without PCH and didn't see any difference in performance neit

[PATCH] D16524: [clang-format-vs] Fix sort include main include: Use current path for the '-assume-filename'

2016-01-24 Thread Jean-Philippe Dufraigne via cfe-commits
jeanphilippeD created this revision. jeanphilippeD added a reviewer: djasper. jeanphilippeD added a subscriber: cfe-commits. clang-format sort include use the source file name to determine the "main include" that will be the 1st include (category 0). Because the clang-format visual studio extensi

Re: [PATCH] D8149: Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

2016-01-24 Thread Richard via cfe-commits
LegalizeAdulthood retitled this revision from "Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes" to "Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher

[PATCH] D16526: Add hasRetValue narrowing matcher for returnStmt

2016-01-24 Thread Richard via cfe-commits
LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: klimek. LegalizeAdulthood added a subscriber: cfe-commits. Herald added a subscriber: klimek. Add `hasRetValue` narrowing matcher for `returnStmt` so that you can match on the expression returned by a return stmt (or lac

Re: [PATCH] D16526: Add hasRetValue narrowing matcher for returnStmt

2016-01-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 45836. LegalizeAdulthood added a comment. Run clang-format http://reviews.llvm.org/D16526 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatche

Re: [PATCH] D16526: Add hasRetValue narrowing matcher for returnStmt

2016-01-24 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. I get the same behavior from the existing has() matcher -- how is this meant to differ? clang-query> match returnStmt(unless(has(expr( Match #1: E:\Desktop\test4.c

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

2016-01-24 Thread Felix Berger via cfe-commits
flx removed rL LLVM as the repository for this revision. flx updated this revision to Diff 45837. flx added a comment. Removed unused include and changed casing on Builder variable. http://reviews.llvm.org/D16517 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp cla

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

2016-01-24 Thread Felix Berger via cfe-commits
flx updated this revision to Diff 45838. http://reviews.llvm.org/D16517 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/UninitializedFieldCheck.cpp clang-tidy/misc/UninitializedFieldCheck.h docs/clang-tidy/checks/misc-uninitialized-field.rst te

[PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

2016-01-24 Thread Arpith Jacob via cfe-commits
arpith-jacob created this revision. arpith-jacob added reviewers: hfinkel, kkwli0, sfantao, carlo.bertolli, ABataev. arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin. This patch adds parsing + sema for the defaultmap clause associated with the target directive (among others). h

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

2016-01-24 Thread Xiuli PAN via cfe-commits
pxli168 added a comment. Hi pekka, What is your opinion about this patch? And how could we ask the release manager to squeeze this patch into LLVM release 3.8? The pipe in OpneCL can only be handled by builtin functions, and this patch is needed for the pipe support. Thanks Xiuli http://revie

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-01-24 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Alright, so this is looking really good. Once we land this would you be interested in applying the same optimization to `emplace` calls? Comment at: include/__hash_table:863 @@ -862,2 +862,3 @@ _LIBCPP_INLINE_VISIBILITY -pair __insert_unique_va

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-01-24 Thread Duncan P. N. Exon Smith via cfe-commits
dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. Great, I should have time to clean this up tomorrow afternoon. Regarding emplace, this patch as is has tests for emplace, but they depend on r258575 being in tree. You asked me to revert that... I'll wait for your response ov

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-01-24 Thread Duncan P. N. Exon Smith via cfe-commits
Great, I should have time to clean this up tomorrow afternoon. Regarding emplace, this patch as is has tests for emplace, but they depend on r258575 being in tree. You asked me to revert that... I'll wait for your response over in that thread: http://lists.llvm.org/pipermail/cfe-commits/Week-of-M

r258668 - Fixed processing of GNU extensions to C99 designated initializers

2016-01-24 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Sun Jan 24 23:14:03 2016 New Revision: 258668 URL: http://llvm.org/viewvc/llvm-project?rev=258668&view=rev Log: Fixed processing of GNU extensions to C99 designated initializers Clang did not handles correctly inner parts of arrays/structures initializers in GNU extensions t

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-01-24 Thread Eric Fiselier via cfe-commits
On Sun, Jan 24, 2016 at 9:46 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > Great, I should have time to clean this up tomorrow afternoon. > > Regarding emplace, this patch as is has tests for emplace, but > they depend on r258575 being in tree. You asked me to revert > that... I'll

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-01-24 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In http://reviews.llvm.org/D16360#334781, @dexonsmith wrote: > Great, I should have time to clean this up tomorrow afternoon. > > Regarding emplace, this patch as is has tests for emplace, but > they depend on r258575 being in tree. You asked me to revert > that... I'll

Re: [PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

2016-01-24 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:3408-3409 @@ +3407,4 @@ +Kind(Kind), KindLoc(KLoc) { +Modifier = M; +ModifierLoc = MLoc; + } Why these are not initialized in initializer list, along with Kind, KindLoc e

Re: [PATCH] D16526: Add hasRetValue narrowing matcher for returnStmt

2016-01-24 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. In http://reviews.llvm.org/D16526#334742, @aaron.ballman wrote: > I get the same behavior from the existing has() matcher -- how is this meant > to differ? Hmm! Good question. I suppose it doesn't do anything different. I was thinking how to write such mat

r258669 - Allow capture typedefs/type aliases for VLAs in lambdas/captured statements chain.

2016-01-24 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Jan 25 01:06:23 2016 New Revision: 258669 URL: http://llvm.org/viewvc/llvm-project?rev=258669&view=rev Log: Allow capture typedefs/type aliases for VLAs in lambdas/captured statements chain. Previous it was allowed to capture VLAs/types with arrays of runtime bounds onl

Re: [PATCH] D16259: Add clang-tidy readability-redundant-control-flow check

2016-01-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 45842. LegalizeAdulthood added a comment. Improve matcher to simplify callback http://reviews.llvm.org/D16259 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/RedundantContr

Re: r257947 - Avoid self-assignment of SmallString, trigger UB behavior down the road.

2016-01-24 Thread Richard Smith via cfe-commits
Approved for branch. On 23 Jan 2016 11:56 p.m., "Joerg Sonnenberger" wrote: > On Sat, Jan 16, 2016 at 03:51:11PM +0100, Joerg Sonnenberger via > cfe-commits wrote: > > Hello Richard, > > can this be merged into 3.8? It creates some trivial noise under > > valgrind. > > Ping? > > Joerg > _