r257863 - When copying whitespace flags from the token naming a macro argument onto the

2016-01-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jan 14 21:24:18 2016 New Revision: 257863 URL: http://llvm.org/viewvc/llvm-project?rev=257863&view=rev Log: When copying whitespace flags from the token naming a macro argument onto the first token of the expansion, don't forget to copy the "is at the start of a line" toke

Re: [PATCH] D15866: Warn when using `defined` in a macro definition.

2016-01-14 Thread Nico Weber via cfe-commits
Thanks for the review! I tweaked it a bit so that this only warns on function-type macros in -pedantic mode. That way, the warning can even be used in practice :-) On Thu, Jan 14, 2016 at 10:33 PM, Nico Weber wrote: > thakis updated this revision to Diff 44958. > thakis added a comment. > > For

r257865 - [CodeGen] Attach attributes to thread local wrapper function.

2016-01-14 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Thu Jan 14 21:34:06 2016 New Revision: 257865 URL: http://llvm.org/viewvc/llvm-project?rev=257865&view=rev Log: [CodeGen] Attach attributes to thread local wrapper function. This commit is a follow-up to r251734, r251476, and r249735, which fixes a bug where function attrib

Re: [PATCH] D15866: Warn when using `defined` in a macro definition.

2016-01-14 Thread Nico Weber via cfe-commits
thakis updated this revision to Diff 44959. thakis added a comment. Address review comment. http://reviews.llvm.org/D15866 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPExpressions.cpp test/Lexer/cxx-features.cpp test/Preprocessor/e

Re: [PATCH] D15866: Warn when using `defined` in a macro definition.

2016-01-14 Thread Nico Weber via cfe-commits
thakis marked an inline comment as done. thakis added a comment. Also addressed your comment and added a test for that. http://reviews.llvm.org/D15866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

r257867 - [X86] Support 'interrupt' attribute for x86

2016-01-14 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jan 14 22:06:31 2016 New Revision: 257867 URL: http://llvm.org/viewvc/llvm-project?rev=257867&view=rev Log: [X86] Support 'interrupt' attribute for x86 This attribute may be attached to a function definition and instructs the backend to generate appropriate function entr

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2016-01-14 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257867: [X86] Support 'interrupt' attribute for x86 (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D15709?vs=44754&id=44961#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

2016-01-14 Thread Xiuli PAN via cfe-commits
pxli168 marked 2 inline comments as done. Comment at: lib/Sema/SemaChecking.cpp:378 @@ +377,3 @@ + } + + return false; Anastasia wrote: > I am asking about setArg and not setType! Oh, I just mistook your meaning. It seems we don't need that as we have to covert

r257868 - PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration, by Denis Zobnin

2016-01-14 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jan 14 22:36:32 2016 New Revision: 257868 URL: http://llvm.org/viewvc/llvm-project?rev=257868&view=rev Log: PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration, by Denis Zobnin Allow "mode" attribute to be applied to VarDecl, not ValueDecl

Re: [PATCH] D16112: PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration

2016-01-14 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257868: PR26111: segmentation fault with __attribute__((mode(QI))) on function… (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D16112?vs=44859&id=44963#toc Repository: rL LLV

r257869 - Add new diff modes to template type diffing.

2016-01-14 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Thu Jan 14 23:01:53 2016 New Revision: 257869 URL: http://llvm.org/viewvc/llvm-project?rev=257869&view=rev Log: Add new diff modes to template type diffing. Remove an old assertion that does not hold. It is possible for a template argument to be a declaration in one instanti

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

2016-01-14 Thread Xiuli PAN via cfe-commits
pxli168 updated this revision to Diff 44965. pxli168 added a comment. Forget about get_pipe_num/max_packets builtin. http://reviews.llvm.org/D15914 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h include/clang/Basic/DiagnosticSemaKinds.td lib/Basic/Builtins.cpp

r257870 - Fixing more issues with template type diffing

2016-01-14 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Thu Jan 14 23:48:38 2016 New Revision: 257870 URL: http://llvm.org/viewvc/llvm-project?rev=257870&view=rev Log: Fixing more issues with template type diffing 1) Print qualifiers for templates with zero arguments 2) Add a few more tests for the template type diffing refactorin

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

2016-01-14 Thread Alexey Bataev via cfe-commits
ABataev added a comment. LG Repository: rL LLVM http://reviews.llvm.org/D15220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r257871 - Fix a -Wparentheses warning in ASTDiagnostic.cpp.

2016-01-14 Thread James Y Knight via cfe-commits
Author: jyknight Date: Thu Jan 14 23:57:41 2016 New Revision: 257871 URL: http://llvm.org/viewvc/llvm-project?rev=257871&view=rev Log: Fix a -Wparentheses warning in ASTDiagnostic.cpp. Modified: cfe/trunk/lib/AST/ASTDiagnostic.cpp Modified: cfe/trunk/lib/AST/ASTDiagnostic.cpp URL: http://ll

<    1   2