Re: [PATCH] D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973.

2016-01-12 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/iterator:442 @@ +441,3 @@ +struct __is_exactly_input_iterator +: public integral_constant::iterator_category, input_iterator_tag>::value> {}; + Sigh. Yes, `boost::input_output_iterator_tag` (and probably o

Re: [PATCH] D16115: [test-suite] Add ClangAnalyzerBenchmarks directory to test-suite repository

2016-01-12 Thread Matthias Braun via cfe-commits
MatzeB accepted this revision. MatzeB added a comment. This revision is now accepted and ready to land. LGTM, though you should wait a week or two for other opinions before committing. http://reviews.llvm.org/D16115 ___ cfe-commits mailing list cfe-

r257559 - [Bugfix] Fix ICE on constexpr vector splat.

2016-01-12 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Tue Jan 12 19:52:39 2016 New Revision: 257559 URL: http://llvm.org/viewvc/llvm-project?rev=257559&view=rev Log: [Bugfix] Fix ICE on constexpr vector splat. In {CG,}ExprConstant.cpp, we weren't treating vector splats properly. This patch makes us treat splats more properly. Add

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

2016-01-12 Thread George Burgess IV via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257559: [Bugfix] Fix ICE on constexpr vector splat. (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D14877?vs=44187&id=44701#toc Repository: rL LLVM http://reviews.llvm.org/D148

r257562 - Install scan-build and scan-view only if Static Analyzer was enabled.

2016-01-12 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Tue Jan 12 20:03:50 2016 New Revision: 257562 URL: http://llvm.org/viewvc/llvm-project?rev=257562&view=rev Log: Install scan-build and scan-view only if Static Analyzer was enabled. Modified: cfe/trunk/tools/CMakeLists.txt Modified: cfe/trunk/tools/CMakeLists.txt

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

2016-01-12 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: clang-tidy/ClangTidyOptions.h:216 @@ +215,3 @@ +/// HeaderFileExtensions. +bool endWithHeaderFileExtensions(llvm::StringRef FileName, + llvm::StringRef HeaderFileExtensions); aaron.ballman w

Re: [PATCH] D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973.

2016-01-12 Thread Marshall Clow via cfe-commits
mclow.lists updated this revision to Diff 44703. mclow.lists added a comment. Last change, I hope. I added some more tests to make sure that string was correctly identifying throwing vs. non-throwing iterators, and I discovered that I had an `#ifdef` backwards. Fixing that revealed a bug in `__

Re: [PATCH] D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973.

2016-01-12 Thread Marshall Clow via cfe-commits
mclow.lists marked 3 inline comments as done. mclow.lists added a comment. http://reviews.llvm.org/D15862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16087: Add some overview doxygen comments to lib/Format.

2016-01-12 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.h:35 @@ -34,1 +34,3 @@ +/// \brief Helper class for breaking a logical line into multiple physical +/// lines. Manages moving state from one physical line to the next. You are the first

<    1   2