Re: [PATCH] D15911: Move ownership of Action objects into Compilation.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks for doing this :) -eric http://reviews.llvm.org/D15911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D15960: Don't build jobs for the same Action + ToolChain twice.

echristo added a comment. So, how are you getting to the point where you're trying to create the same action twice? -eric http://reviews.llvm.org/D15960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D15960: Don't build jobs for the same Action + ToolChain twice.

jlebar added a comment. In http://reviews.llvm.org/D15960#324162, @echristo wrote: > So, how are you getting to the point where you're trying to create the same > action twice? > > -eric In the new CUDA world, we have the following graph, which I hope will render properly: foo.cu --> foo.s

Re: [PATCH] D15960: Don't build jobs for the same Action + ToolChain twice.

jlebar added a comment. In http://reviews.llvm.org/D15960#324162, @echristo wrote: > So, how are you getting to the point where you're trying to create the same > action twice? > > -eric In the new CUDA world, we have the following graph, which I hope will render properly: foo.cu --> foo.s

Re: [PATCH] D16065: Fix infinite recursion for invalid declaration

kcc accepted this revision. kcc added a reviewer: kcc. kcc added a comment. This revision is now accepted and ready to land. LGTM, and thanks! http://reviews.llvm.org/D16065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

r257406 - clang-format: [JS] Teach clang-format about "export interface".

Author: djasper Date: Mon Jan 11 16:57:40 2016 New Revision: 257406 URL: http://llvm.org/viewvc/llvm-project?rev=257406&view=rev Log: clang-format: [JS] Teach clang-format about "export interface". Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp cfe/trunk/unittests/Format/FormatTes

Re: [PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

jlebar updated this revision to Diff 44564. jlebar added a comment. Add missing change to DiagnosticDriverKinds.td. http://reviews.llvm.org/D16079 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Action.h lib/Driver/Action.cpp lib/Driver/Driver.cpp test/Driver/

Re: [PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

jlebar added a comment. Oops, I added the new error to the generated file in my objdir, rather than in the source tree. It worked fine until I rebuilt... Eric, please have a look at the change to DiagnosticDriverKinds.td. http://reviews.llvm.org/D16079 _

r257407 - Move ownership of Action objects into Compilation.

Author: jlebar Date: Mon Jan 11 17:07:27 2016 New Revision: 257407 URL: http://llvm.org/viewvc/llvm-project?rev=257407&view=rev Log: Move ownership of Action objects into Compilation. Summary: This makes constructing Action graphs which are DAGs much simpler. It also just simplifies in general t

Re: [PATCH] D15911: Move ownership of Action objects into Compilation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257407: Move ownership of Action objects into Compilation. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D15911?vs=44379&id=44566#toc Repository: rL LLVM http://reviews.llvm

Re: [PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

echristo added a comment. Yep it's fine. Thanks! -eric http://reviews.llvm.org/D16079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r257408 - Make Driver::BuildJobsForAction return an InputInfo, instead of using an outparam.

Author: jlebar Date: Mon Jan 11 17:09:32 2016 New Revision: 257408 URL: http://llvm.org/viewvc/llvm-project?rev=257408&view=rev Log: Make Driver::BuildJobsForAction return an InputInfo, instead of using an outparam. Summary: Explicit is better than implicit. Reviewers: echristo Subscribers: ll

r257411 - Add an Action* member to InputInfo.

Author: jlebar Date: Mon Jan 11 17:15:21 2016 New Revision: 257411 URL: http://llvm.org/viewvc/llvm-project?rev=257411&view=rev Log: Add an Action* member to InputInfo. Summary: The CUDA toolchain needs to know which Actions created which InputInfos, because it needs to attach GPU archs to the va

Re: [PATCH] D16078: Add an Action* member to InputInfo.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257411: Add an Action* member to InputInfo. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16078?vs=44539&id=44568#toc Repository: rL LLVM http://reviews.llvm.org/D16078 Fi

Buildbot numbers for week of 1/03/2016 - 1/09/2016

Hello everyone, Below are some buildbot numbers for the last week of 1/03/2016 - 01/09/2016. Thanks Galina Number of commits by project: project | commits ---+--- llvm | 266 cfe |9

r257413 - [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

Author: jlebar Date: Mon Jan 11 17:27:13 2016 New Revision: 257413 URL: http://llvm.org/viewvc/llvm-project?rev=257413&view=rev Log: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/. Reviewers: tra Subscribers: cfe-commits, jhen, echristo Differential Revision: http://

Re: [PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257413: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16079?vs=44564&id=44569#toc Repository: rL

Re: r257175 - Driver: Use the new ELF lld linker for AMDGPU

awesome! On 8 January 2016 at 10:14, Tom Stellard via cfe-commits wrote: > Author: tstellar > Date: Fri Jan 8 09:14:31 2016 > New Revision: 257175 > > URL: http://llvm.org/viewvc/llvm-project?rev=257175&view=rev > Log: > Driver: Use the new ELF lld linker for AMDGPU > > Summary: 'gnu-old' has be

Re: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

On 8 January 2016 at 19:50, Duncan P. N. Exon Smith via cfe-commits wrote: > [re-send to lists.llvm.org] > [necromancy] > > This is causing some strangeness for users of libc++ headers that > ship dylibs and build with -fno-rtti and -fvisibility=hidden. > > Strangely, -fno-rtti does *not* imply -f

Re: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

> On 2016-Jan-11, at 15:40, Rafael Espíndola wrote: > > On 8 January 2016 at 19:50, Duncan P. N. Exon Smith via cfe-commits > wrote: >> [re-send to lists.llvm.org] >> [necromancy] >> >> This is causing some strangeness for users of libc++ headers that >> ship dylibs and build with -fno-rtti an

[PATCH] D16094: Debugger tuning via gold plugin

probinson created this revision. probinson added a reviewer: echristo. probinson added a subscriber: cfe-commits. Herald added a subscriber: joker.eph. LTO via the gold plugin needs to be told about debugger tuning. http://reviews.llvm.org/D16094 Files: lib/Driver/Tools.cpp test/Driver/lto.c

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

samsonov added a comment. Sorry, lost track of this. Comment at: lib/Driver/ToolChains.cpp:368 @@ +367,3 @@ + StringRef OS = ""; + if (isTargetMacOS()) +OS = "osx"; zaks.anna wrote: > samsonov wrote: > > Wait, this looks horrible. Can we teach toolchain to

Re: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

> I'm not sure about GCC. Note that there is no linkage for -frtti, > since the type info is deferred to the TU with the vtable. Yes, that is what I mean. It is odd that -frtti changes us from "this is not available anywhere, use linkonce_odr" to "it is available elsewhere, use an external declar

Re: [PATCH] D15208: Patch for inline abort code generation

samsonov added a comment. Sorry for delay. Comment at: lib/CodeGen/CGExpr.cpp:2543 @@ +2542,3 @@ + // RE: Bug: 25682 + if(!CGM.getCodeGenOpts().MergeTraps || !CGM.getCodeGenOpts().OptimizationLevel || !TrapBB) { +// If we aren't merging traps, set the function to not be o

Re: [PATCH] D16056: [Gold] Pass -mllvm options to the gold plugin

Maybe. I would like a second opinion on this one. The potential issue I see is that we are using compiler options during linking. Normally they are just ignored. Is it surprising if LTO starts using them? Cheers, Rafael On 11 January 2016 at 06:47, James Molloy wrote: > jmolloy created this rev

Re: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

> On 2016-Jan-11, at 15:57, Rafael Espíndola wrote: > >> I'm not sure about GCC. Note that there is no linkage for -frtti, >> since the type info is deferred to the TU with the vtable. > > Yes, that is what I mean. It is odd that -frtti changes us from "this > is not available anywhere, use li

Re: [libcxx] [PATCH] unordered_map: Avoid unnecessary mallocs when no insert occurs

ping > On 2016-Jan-04, at 12:37, Duncan P. N. Exon Smith > wrote: > > ping > >> On 2015-Dec-17, at 13:56, Duncan P. N. Exon Smith >> wrote: >> >> >>> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith >>> wrote: >>> >>> This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert

[PATCH] D16097: [CUDA] Add explicit mapping from sm_XX to compute_YY.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: echristo, jhen, cfe-commits. This is used by D16082 when it invokes fatbinary. http://reviews.llvm.org/D16097 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp test/Driver/cuda-bad-arch.cu Index

[libcxx] r257422 - Put the definition of _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK in the right place.

Author: marshall Date: Mon Jan 11 18:38:04 2016 New Revision: 257422 URL: http://llvm.org/viewvc/llvm-project?rev=257422&view=rev Log: Put the definition of _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK in the right place. Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/includ

Re: [PATCH] D16056: [Gold] Pass -mllvm options to the gold plugin

I’d fear the same thing. On our platform you have to use explicitly -Wl,-mllvm (or -Xlinker -plugin-opt). — Mehdi > On Jan 11, 2016, at 4:11 PM, Rafael Espíndola > wrote: > > Maybe. I would like a second opinion on this one. The potential issue > I see is that we are using compiler options

Re: [PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

jlebar added a comment. In http://reviews.llvm.org/D16082#324138, @tra wrote: > Make sure it works with -save-temps and -fintegrated-as/-fno-integrated-as. > They tend to throw wrenches into pipeline construction. Thanks. All of them worked except -fintegrated-as, which was causing us not to

Re: [PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

jlebar updated this revision to Diff 44584. jlebar marked 8 inline comments as done. jlebar added a comment. Address tra, echristo's review comments. http://reviews.llvm.org/D16082 Files: include/clang/Driver/Action.h include/clang/Driver/Options.td include/clang/Driver/ToolChain.h incl

Re: [PATCH] D16097: [CUDA] Add explicit mapping from sm_XX to compute_YY.

jlebar updated this revision to Diff 44585. jlebar added a comment. Update to latest set of architectures, according to ptxas --help from cuda 7.5. http://reviews.llvm.org/D16097 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp test/Driver/cuda-bad-arch.cu Index: test/Driver/cu

Re: [PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

jlebar updated this revision to Diff 44586. jlebar added a comment. Add test checking that sm_XX gets translated to compute_YY correctly. http://reviews.llvm.org/D16082 Files: include/clang/Driver/Action.h include/clang/Driver/Options.td include/clang/Driver/ToolChain.h include/clang/Dr

Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

reames added a comment. Neither Sanjoy or I are qualified to review a clang patch. You'll need to find clang reviewers. Also, before this gets exposed through Clang, we really should formalize/document the attribute. In practice, it implies the lack of a safepoint poll site inside the calle

Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

majnemer added subscribers: aaron.ballman, majnemer. majnemer added a comment. This change looks fine modulo the documentation issue. Comment at: include/clang/Basic/Attr.td:2177 @@ +2176,3 @@ + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; +} -

Re: [PATCH] D9600: Add scan-build python implementation

zaks.anna accepted this revision. zaks.anna added a comment. Laszlo, I am very excited about having the new and much improved scan-build in tree! It will serve as a solid foundation for moving forward. Thank you for all your hard work! Anna. http://reviews.llvm.org/D9600 __

RE: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Duncan P. N. Exon Smith via cfe-commits > Sent: Monday, January 11, 2016 4:21 PM > To: Rafael Espíndola > Cc: Marshall Clow; CFE Commits > Subject: Re: [libcxx] r196411 - Give all members of

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pxli168 added inline comments. Comment at: include/clang/Basic/Builtins.def:1260 @@ +1259,3 @@ + +LANGBUILTIN(reserve_read_pipe, "i.", "tn", OCLC_LANG) +LANGBUILTIN(reserve_write_pipe, "i.", "tn", OCLC_LANG) Anastasia wrote: > Ok, this way it means variable number

Re: [PATCH] D15791: Disable generating movt on FreeBSD

davide closed this revision. davide added a comment. Close, this went in a while ago. Repository: rL LLVM http://reviews.llvm.org/D15791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

mjacob added a comment. In http://reviews.llvm.org/D15998#324354, @reames wrote: > Also, before this gets exposed through Clang, we really should > formalize/document the attribute. In practice, it implies the lack of a > safepoint poll site inside the called function. Annoyingly, it's not a

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

pxli168 added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5733 @@ +5732,3 @@ + +#if 0 + pekka.jaaskelainen wrote: > Is this intentionally included in the patch? My mistake, just want to check if this works. But find it is handled by something else. =

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

adek05 updated this revision to Diff 44598. adek05 added a comment. Adding testcases in unittest/AST/SourceLocationTest.cpp as suggested by @aaronballman Interestingly, without my change tests for function declarations pass. Only member functions fail: tools/clang/unittests/AST/ASTTests ..

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

pxli168 updated this revision to Diff 44599. pxli168 added a comment. Remove some unused codes and add inline comment. http://reviews.llvm.org/D16047 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaInit.cpp lib/Sema/SemaType.c

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4934 @@ +4933,3 @@ +const Type *DeclTy = PDecl->getType().getCanonicalType().getTypePtr(); +if (AccessAttr->isReadWrite()) { + if (DeclTy->isPipeType() || Anastasia wrote: > In the c

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 updated this revision to Diff 44600. pxli168 added a comment. Fix destruct problem and fix style in inline comment. http://reviews.llvm.org/D16040 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CodeGenFunction.cpp lib/Sema/SemaChecking.

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pxli168 updated this revision to Diff 44601. pxli168 added a comment. Add negative tests to hint all paths in the Semacheck. http://reviews.llvm.org/D15914 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h include/clang/Basic/DiagnosticSemaKinds.td lib/Basic/Builtin

Re: [PATCH] D15989: [OpenMP] Parsing + sema for "target enter data" and "target exit data" directives.

ABataev added a comment. You need to add the code/tests for nesting of regions. Comment at: include/clang-c/Index.h:2283 @@ +2282,3 @@ + */ + CXCursor_OMPTargetExitDataDirective= 262, + Target exit and target enter constructs must be implemented in differ

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

LegalizeAdulthood marked an inline comment as done. Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4994 @@ +4993,3 @@ + EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;", + typedefDecl(hasUnderlyingType(asString("int"); + EXPECT_TRUE(matche

r257451 - clang-format: [JS] Support exporting abstract classes.

Author: djasper Date: Tue Jan 12 00:24:38 2016 New Revision: 257451 URL: http://llvm.org/viewvc/llvm-project?rev=257451&view=rev Log: clang-format: [JS] Support exporting abstract classes. Before: export abstract class X {y: number;} (and all sorts of other havoc in more complicated cases). Af

Re: [PATCH] D16056: [Gold] Pass -mllvm options to the gold plugin

Ok, I'll abandon this. It wasn't meant to be contentious and this is a reasonable objection! James > On 12 Jan 2016, at 00:53, Mehdi Amini wrote: > > I’d fear the same thing. On our platform you have to use explicitly > -Wl,-mllvm (or -Xlinker -plugin-opt). > > — > Mehdi > > >> On Jan 11, 2

<    1   2