r257011 - Remove leading space added in r227312.

2016-01-06 Thread Eric Christopher via cfe-commits
Author: echristo Date: Wed Jan 6 19:23:21 2016 New Revision: 257011 URL: http://llvm.org/viewvc/llvm-project?rev=257011&view=rev Log: Remove leading space added in r227312. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaK

r257010 - Use an actual real architecture and massage a couple of comments.

2016-01-06 Thread Eric Christopher via cfe-commits
Author: echristo Date: Wed Jan 6 19:23:19 2016 New Revision: 257010 URL: http://llvm.org/viewvc/llvm-project?rev=257010&view=rev Log: Use an actual real architecture and massage a couple of comments. Modified: cfe/trunk/test/Driver/gcc_forward.c Modified: cfe/trunk/test/Driver/gcc_forward.c

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

2016-01-06 Thread Richard Smith via cfe-commits
rsmith added a comment. Maybe we could remove `CK_BooleanToSignedFloating` and model that conversion as a sequence of `CK_BooleanToSignedIntegral` followed by `CK_IntegralToFloating`? I don't imagine it's a common operation, so the simpler AST representation is probably worth more than the mino

r257014 - Replace a loop with the call that does the same thing.

2016-01-06 Thread Eric Christopher via cfe-commits
Author: echristo Date: Wed Jan 6 20:00:55 2016 New Revision: 257014 URL: http://llvm.org/viewvc/llvm-project?rev=257014&view=rev Log: Replace a loop with the call that does the same thing. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.or

r257016 - [Sema] Teach overload resolution about unaddressable functions.

2016-01-06 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Wed Jan 6 20:26:57 2016 New Revision: 257016 URL: http://llvm.org/viewvc/llvm-project?rev=257016&view=rev Log: [Sema] Teach overload resolution about unaddressable functions. Given an expression like `(&Foo)();`, we perform overload resolution as if we are calling `Foo` direct

Re: [PATCH] D15590: [Bugfix] Disqualify unaddressable overload candidates when a function is directly called indirectly.

2016-01-06 Thread George Burgess IV via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257016: [Sema] Teach overload resolution about unaddressable functions. (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D15590?vs=43900&id=44184#toc Repository: rL LLVM http://r

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

2016-01-06 Thread Richard via cfe-commits
LegalizeAdulthood added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4992 @@ +4991,3 @@ + EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;", + typedefDecl(hasUnderlyingType(asString("int"); + EXPECT_TRUE(matches("typedef

[libcxx] r257018 - [libcxx] Set LC_ALL rather than LC_COLLATE to override collation.

2016-01-06 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Wed Jan 6 20:36:09 2016 New Revision: 257018 URL: http://llvm.org/viewvc/llvm-project?rev=257018&view=rev Log: [libcxx] Set LC_ALL rather than LC_COLLATE to override collation. r251131 replaced LANG with LC_COLLATE. But LC_ALL has precedence over both, so the test still fails wh

Re: r257005 - [WebAssembly] Enable -ffunction-sections and -fdata-sections by default.

2016-01-06 Thread JF Bastien via cfe-commits
Hi Dan, I think this change (or one of the surrounding ones) broken compiling C code with WebAssembly. Errors look like: error at line 3: unknown section: .text.foobar See: https://build.chromium.org/p/client.wasm.llvm/builders/linux/builds/1507/steps/Link%20LLVM%20Torture%20with%20wasmate/logs

Re: [PATCH] D15858: Warn undeclared identifiers in CUDA kernel calls

2016-01-06 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: include/clang/AST/ExprCXX.h:180 @@ +179,3 @@ +assert( +!getConfig() && +"CUDAKernelCallExpr.setConfig can only be called once per instance."); My preference would be to pass the `CallExpr` constructor a

r257021 - [WebAssembly] Add -m:e to the target triple.

2016-01-06 Thread Dan Gohman via cfe-commits
Author: djg Date: Wed Jan 6 21:20:15 2016 New Revision: 257021 URL: http://llvm.org/viewvc/llvm-project?rev=257021&view=rev Log: [WebAssembly] Add -m:e to the target triple. Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/CodeGen/target-data.c Modified: cfe/trunk/lib/Basic/Targ

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

2016-01-06 Thread George Burgess IV via cfe-commits
george.burgess.iv added a comment. > Maybe we could remove CK_BooleanToSignedFloating and model that conversion as > a sequence of CK_BooleanToSignedIntegral followed by CK_IntegralToFloating? I > don't imagine it's a common operation, so the simpler AST representation is > probably worth more

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

2016-01-06 Thread George Burgess IV via cfe-commits
george.burgess.iv updated this revision to Diff 44187. george.burgess.iv marked an inline comment as done. george.burgess.iv added a comment. Addressed all feedback, and added tests for `bool` -> `[n x i128]` case. http://reviews.llvm.org/D14877 Files: include/clang/AST/ASTContext.h include

[PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

2016-01-06 Thread Kelvin Li via cfe-commits
kkwli0 created this revision. kkwli0 added reviewers: ABataev, rsmith, fraggamuffin, sfantao, hfinkel, carlo.bertolli. kkwli0 added a subscriber: cfe-commits. This patch is to add parsing and sema support for target update directive. It also includes the to and from clause as it is required to

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

2016-01-06 Thread Richard via cfe-commits
LegalizeAdulthood added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4992 @@ +4991,3 @@ + EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;", + typedefDecl(hasUnderlyingType(asString("int"); + EXPECT_TRUE(matches("typedef

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

2016-01-06 Thread Richard via cfe-commits
LegalizeAdulthood added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4992 @@ +4991,3 @@ + EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;", + typedefDecl(hasUnderlyingType(asString("int"); + EXPECT_TRUE(matches("typedef

Re: [PATCH] Add ObjCBoxable handling to ObjCMigrator

2016-01-06 Thread Alex Denisov via cfe-commits
Any updates? :) -- AlexDenisov Software Engineer, http://lowlevelbits.org > On 05 Dec 2015, at 22:19, John McCall wrote: > >> On Dec 5, 2015, at 7:58 AM, AlexDenisov <1101.deb...@gmail.com> wrote: >> Extend ObjCMigrator to cover automatic migration from message sending to >> boxable literals, e

Re: [PATCH] D9600: Add scan-build python implementation

2016-01-06 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki added a comment. I like the standalone bear tool. should it really be embedded into clang? Will the standalone tool still be maintained? Comment at: tools/scan-build-py/libear/ear.c:1 @@ +1,2 @@ +/* -*- coding: utf-8 -*- +// The LLVM Compiler

<    1   2