alexfh added inline comments.
Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:85
@@ +84,3 @@
+ }else {
+return false;
+ }
congliu wrote:
> alexfh wrote:
> > What if both return types are not references and are not pointers? Why do
> > you return `false
aaron.ballman updated this revision to Diff 43840.
aaron.ballman added a comment.
Changes in this revision:
- Added the redirecting checkers to the list, with additional information that
they will redirect to another page).
- Changed the auto-redirect time to 5 seconds.
- Added text and manual l
aaron.ballman marked 2 inline comments as done.
Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:6
@@ +5,3 @@
+cert-dcl54-cpp
+==
+
> We need to teach add_new_check.py to retain (or automatically generate) these
> comments then.
I have not touch
ABataev updated this revision to Diff 43843.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D15709
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp