EricWF added inline comments.
Comment at: cmake/config-ix.cmake:45
@@ -44,3 +44,3 @@
check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB)
-check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB)
+check_library_exists(gcc_s __gcc_personal
Author: xazax
Date: Sat Dec 12 05:31:25 2015
New Revision: 255431
URL: http://llvm.org/viewvc/llvm-project?rev=255431&view=rev
Log:
[clang-tidy] Fix PR25812.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
clang-tools-extra/trunk/test/clang-tidy/readab
jmolloy resigned from this revision.
jmolloy removed a reviewer: jmolloy.
jmolloy added a comment.
Eric is reviewing this; resigning myself.
http://reviews.llvm.org/D15223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Hi,
the attached patch changes
delete called on 'dnvd::B' that has virtual functions but non-virtual
destructor
to
delete called on non-final 'dnvd::B' that has virtual functions but
non-virtual destructor
I'm not sure if it should only do this for c++11 and newer – the new
message is true
shahms updated this revision to Diff 42608.
shahms added a comment.
Address comments and add CHECK for TypeRef as well
http://reviews.llvm.org/D15470
Files:
lib/Sema/SemaDeclCXX.cpp
test/Index/namespaced-base-ctor-init.cpp
Index: test/Index/namespaced-base-ctor-init.cpp
===
shahms marked 2 inline comments as done.
shahms added a comment.
Thanks for taking a look at this so quickly. I've updated the test to make
sure the TypeRef is correct as well, in light of the changes here.
http://reviews.llvm.org/D15470
___
cfe-c
omtcyf0 updated this revision to Diff 42636.
omtcyf0 added a comment.
Added tool description.
http://reviews.llvm.org/D15370
Files:
tools/scan-view/bin/scan-view
Index: tools/scan-view/bin/scan-view
===
--- tools/scan-view/bin/s
compnerd added inline comments.
Comment at: cmake/config-ix.cmake:45
@@ -44,3 +44,3 @@
check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB)
-check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB)
+check_library_exists(gcc_s __gcc_person
Author: davidxl
Date: Sat Dec 12 11:28:37 2015
New Revision: 255435
URL: http://llvm.org/viewvc/llvm-project?rev=255435&view=rev
Log:
[PGO] Stop using invalid char in instr variable names.
(This is part-2 of the patch of r255434 --
fixing test cases, second try)
Modified:
cfe/trunk/test/Co
Author: davidxl
Date: Sat Dec 12 11:39:38 2015
New Revision: 255436
URL: http://llvm.org/viewvc/llvm-project?rev=255436&view=rev
Log:
[PGO] add a test case with -no-integrated-as
Added:
cfe/trunk/test/Profile/cxx-static.cpp
Added: cfe/trunk/test/Profile/cxx-static.cpp
URL:
http://llvm.org/v
Author: davidxl
Date: Sat Dec 12 12:49:37 2015
New Revision: 255437
URL: http://llvm.org/viewvc/llvm-project?rev=255437&view=rev
Log:
Revert 255436 : remove test that needs to be refined
Removed:
cfe/trunk/test/Profile/cxx-static.cpp
Removed: cfe/trunk/test/Profile/cxx-static.cpp
URL:
http:
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
This is really old and should be closed.
http://reviews.llvm.org/D6712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
majnemer created this revision.
majnemer added a reviewer: rnk.
majnemer added a subscriber: cfe-commits.
We'd like to remove support for terminatepad from LLVM. To do this, we
need to move Clang off of it first. The intent behind terminatepad was
to carefully model exception specifications for
EricWF added inline comments.
Comment at: src/CMakeLists.txt:37
@@ +36,3 @@
+
+remove_flags(-Wl,-z,defs)
+
compnerd wrote:
> EricWF wrote:
> > compnerd wrote:
> > > EricWF wrote:
> > > > compnerd wrote:
> > > > > Do we need to worry about an alternative spelling o
dcoughlin added inline comments.
Comment at: tools/scan-build-py/libear/ear.c:142
@@ +141,3 @@
+#endif
+if (!initialized)
+initialized = bear_capture_env_t(&initial_env);
rizsotto.mailinglist wrote:
> rizsotto.mailinglist wrote:
> > to run the full tes
EricWF added inline comments.
Comment at: src/CMakeLists.txt:37
@@ +36,3 @@
+
+remove_flags(-Wl,-z,defs)
+
EricWF wrote:
> compnerd wrote:
> > EricWF wrote:
> > > compnerd wrote:
> > > > EricWF wrote:
> > > > > compnerd wrote:
> > > > > > Do we need to worry about
bruno updated this revision to Diff 42649.
bruno added a comment.
Thanks Duncan and Argyrios, updated a patch with the suggestions!
http://reviews.llvm.org/D15173
Files:
lib/Lex/PPCaching.cpp
test/Parser/objcxx11-protocol-in-template.mm
Index: test/Parser/objcxx11-protocol-in-template.mm
=
Author: davidxl
Date: Sat Dec 12 21:03:35 2015
New Revision: 255445
URL: http://llvm.org/viewvc/llvm-project?rev=255445&view=rev
Log:
Resubmit new test case after adding more constraint
Added:
cfe/trunk/test/Profile/cxx-static.cpp
Added: cfe/trunk/test/Profile/cxx-static.cpp
URL:
http://llv
Author: davidxl
Date: Sat Dec 12 22:45:49 2015
New Revision: 255447
URL: http://llvm.org/viewvc/llvm-project?rev=255447&view=rev
Log:
Revert r255445: adding a new test case
Removed:
cfe/trunk/test/Profile/cxx-static.cpp
Removed: cfe/trunk/test/Profile/cxx-static.cpp
URL:
http://llvm.org/vie
Author: ctopper
Date: Sat Dec 12 23:41:41 2015
New Revision: 255450
URL: http://llvm.org/viewvc/llvm-project?rev=255450&view=rev
Log:
[Sema] Add -Wparentheses warnings for '^' in '|' expressions and '&' in '^'
expressions to compliment '&' in '|' that is already present. Matches gcc
behavior.
M
Author: ctopper
Date: Sat Dec 12 23:41:37 2015
New Revision: 255449
URL: http://llvm.org/viewvc/llvm-project?rev=255449&view=rev
Log:
[Sema] Write some checks for groups of BinaryOperatorKinds in terms of the
predicates already available in BinaryOperator. NFC
Modified:
cfe/trunk/include/cla
21 matches
Mail list logo
