On Fri, Oct 2, 2015 at 3:09 AM, Richard Smith via cfe-commits
wrote:
> On Thu, Oct 1, 2015 at 6:01 AM, Renato Golin via cfe-commits
> wrote:
>>
>> Right, I reverted both commits on r249005. Please, let me know if you
>> need help testing on ARM before the next commit. This looks like it
>> could
loladiro created this revision.
loladiro added a reviewer: beanz.
loladiro added a subscriber: cfe-commits.
loladiro set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.
When LLVM/Clang is built without ARM support, the ios_kext runtime library is
not bui
mgehre updated this revision to Diff 36465.
mgehre marked 3 inline comments as done.
mgehre added a comment.
Fixed comments. Only show fixit for polymorphic classes. Ignore template
instantiations for now
http://reviews.llvm.org/D13368
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
cla
mgehre marked 2 inline comments as done.
mgehre added a comment.
Thank you for the detailed review.
I disabled checks in template instantiations for now.
Ideally, I would want to see something like:
warning: do not use static_cast to cast from base class to derived class.
note: in instantiati
> On Oct 3, 2015, at 4:33 PM, Eric Fiselier wrote:
>
> Hi Adrian,
>
> So the goal of this patch was to increase the coverage of the test
> suite by default.
> Previously we used C++11 as the default but this meant that new C++14
> and C++1z tests
> were never run. The failures you are seeing a
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks for catching this!
-Chris
Repository:
rL LLVM
http://reviews.llvm.org/D13421
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Author: compnerd
Date: Sun Oct 4 12:51:05 2015
New Revision: 249279
URL: http://llvm.org/viewvc/llvm-project?rev=249279&view=rev
Log:
Add -f[no-]declspec to control recognition of __declspec as a keyword
In versions of clang prior to r238238, __declspec was recognized as a keyword in
all modes.
compnerd closed this revision.
compnerd added a comment.
Committed as SVN r249279 (as per your request in the initial revision).
http://reviews.llvm.org/D13322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249281: Fix makefile build on OSX when ARM targets are not
enabled (authored by kfischer).
Changed prior to commit:
http://reviews.llvm.org/D13421?vs=36462&id=36473#toc
Repository:
rL LLVM
http://re
Author: kfischer
Date: Sun Oct 4 13:51:04 2015
New Revision: 249281
URL: http://llvm.org/viewvc/llvm-project?rev=249281&view=rev
Log:
Fix makefile build on OSX when ARM targets are not enabled
Summary: When LLVM/Clang is built without ARM support, the ios_kext runtime
library is not built, but w
labrinea added inline comments.
Comment at: lib/Basic/Targets.cpp:4456
@@ -4455,3 +4455,1 @@
-if (ArchVersion < 6 ||
- (ArchVersion == 6 && ArchProfile == llvm::ARM::PK_M))
rengolin wrote:
> labrinea wrote:
> > rengolin wrote:
> > > Why is this not n
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Absolutely agree. If we miss some other target, we should add it there, too,
not cover later. LGTM. Thanks!
http://reviews.llvm.org/D13217
_
Author: adrian
Date: Sun Oct 4 18:23:04 2015
New Revision: 249282
URL: http://llvm.org/viewvc/llvm-project?rev=249282&view=rev
Log:
Module Debugging: Emit (ObjC) function declarations in the module scope
when building a module.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/te
Hi Adrian,
The point of this commit was to flush out hidden failures and it's clearly
working as intended. I don't want to revert this because it did it's
job. There are better
ways to handle expected test failures. If I can't put a fix together
tonight I will mark the tests
as XFAIL.
/Eric
_
loladiro updated this revision to Diff 36476.
loladiro added a comment.
Also set the correct linkage on vtables of classes with the new attribute.
http://reviews.llvm.org/D13330
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/cla
loladiro added a comment.
Ok, I have tested this more extensively now. I'm happy with the results. Here's
a patch that applies this to LLVM for example:
https://gist.github.com/Keno/79b08a4b187c4d950dd0
Before:
$llvm-objdump -weak-bind libLLVM-3.8svn.dylib | wc -l
300
After:
$llvm
Author: chapuni
Date: Sun Oct 4 21:04:49 2015
New Revision: 249283
URL: http://llvm.org/viewvc/llvm-project?rev=249283&view=rev
Log:
[CMake] Move CLANG_INCLUDE_TESTS in advance of add_subdirectory(tools).
The target "check-clang-tools" is affected by CLANG_INCLUDE_TESTS but it was
undefined in
17 matches
Mail list logo
