berenm updated this revision to Diff 35818.
berenm added a comment.
Added comments and reformated NamingCheckIdentifer.h with clang-format.
http://reviews.llvm.org/D13079
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
clang-tidy/readability/IdentifierNamingCheck.h
test/clang-tidy
berenm marked 3 inline comments as done.
berenm added a comment.
In http://reviews.llvm.org/D13079#253512, @alexfh wrote:
> Please tell me, if you need me to commit the patch for you after you address
> the comments.
Yes please, I cannot commit it myself.
http://reviews.llvm.org/D13079
__
berenm updated this revision to Diff 35819.
berenm added a comment.
Reworked the patches a little bit, addressing the comments and adding
better handling of checks in header files with corresponding unit test cases.
http://reviews.llvm.org/D13081
Files:
clang-tidy/readability/IdentifierNaming
berenm marked 3 inline comments as done.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:141
@@ +140,3 @@
+ Finder->addMatcher(usingDecl().bind("using"), this);
+ Finder->addMatcher(declRefExpr().bind("declRef"), this);
+ Finder->addMatcher(cxxConstructorDecl().bin
berenm marked an inline comment as done.
berenm added a comment.
I think the latest version also addresses http://reviews.llvm.org/D13079 in a
better way. The check will now let clang-tidy decide whether warnings and fixes
are displayed, whether it is in or from system/user header files or in ma
berenm marked an inline comment as done.
berenm added a comment.
http://reviews.llvm.org/D13081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
berenm abandoned this revision.
berenm added a comment.
Actually I believe it's better fixed by http://reviews.llvm.org/D13081.
http://reviews.llvm.org/D13090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Hi,
it seems moderation didn't approve the phabricator mails for D12834.
(I have no intention to be subscribed to the list just to get
phabricator mails through. For now I am subscribed but disabled
mail delivery -.-)
So the patch is available at http://reviews.llvm.org/D12834
I also added a tes
stbuehler added a comment.
Just for the record: substitution doesn't work yet (it should add available
tags from the substitution, but doesn't).
This example shows the difference: my patch mangles `T::F()` as
`N::Name(N::__test::Result)::T::F[abi:test](N::__test::Result)`, but actually
shouldn
mzolotukhin added a comment.
FWIW, I'm really interested in seeing this patch in!
Thanks,
Michael
http://reviews.llvm.org/D12821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
flx updated this revision to Diff 35826.
flx marked 7 inline comments as done.
flx added a comment.
I changed the check to also produce a fix that wraps the argument in
std::move().
When I modified the test include -isystem %S/Inputs/Headers it broke and only
produces warnings but no fixes anym
DavidEGrayson updated this revision to Diff 35825.
DavidEGrayson added a comment.
I have incorporated John McCall's feedback about variable naming. I was able
to remove most of the *QTy variables, but ResultQTy is used in several places
and the expression to compute it is pretty long, so I kept
sanjoy resigned from this revision.
sanjoy removed a reviewer: sanjoy.
sanjoy added a comment.
This revision hasn't changed for a while, removing myself from reviewers so
that it does not show up in my 'waiting on others' list.
Feel free to re-add my as a reviewer later if needed.
http://revie
On Tue, Sep 08, 2015 at 08:06:00AM -, John McCall via cfe-commits wrote:
> Author: rjmccall
> Date: Tue Sep 8 03:05:57 2015
> New Revision: 246985
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246985&view=rev
> Log:
> Compute and preserve alignment more faithfully in IR-generation.
This s
majnemer added a comment.
Adding John, Richard and Reid as reviewers.
Repository:
rL LLVM
http://reviews.llvm.org/D12834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Mon Sep 28 01:39:35 2015
New Revision: 248696
URL: http://llvm.org/viewvc/llvm-project?rev=248696&view=rev
Log:
[OPENMP 4.1] Add 'simd' clause for 'ordered' directive.
Parsing and sema analysis for 'simd' clause in 'ordered' directive.
Description
If the simd clause is specif
16 matches
Mail list logo
