dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:198
@@ +197,3 @@
+
+ // Return true if the destination buffer of the copy function must/may be in
+ // bound.
Since this returns true on unknown, it should be "may".
===
xazax.hun added a comment.
I can see two very differen directions on the two version of this patch. I
think this is bad and we should pick one.
In the other version we started to exclude some of the stuff (like filename)
from the hash, since it is available already in the plist and gives the
p
xazax.hun added a comment.
I was thinking a bit more, what would be the best way to determine what should
we include in the hash.
In order to determine that first we need to define the scope of the hash
itself. There are several sensible choices such as:
- identify bugs that were generated by
honggyu.kim added a comment.
Just to make it simpler to understand, original strings of issue_hash are as
below with this patch:
BUG 1
3$returna;$Garbage return value
BUG 2
3$intb=a;$Assigned value is garbage or undefined
BUG 3
3$returna;$Garbage return value
This consists of the 3 f
honggyu.kim added a comment.
You made a comment while I was writing other comment :)
In http://reviews.llvm.org/D12906#248392, @zaks.anna wrote:
> This new patch does not seem to build on top of
> http://reviews.llvm.org/D10305 but is an alternative way of generating the
> hash that reuses a l
Author: nwilson
Date: Thu Sep 17 21:50:53 2015
New Revision: 247966
URL: http://llvm.org/viewvc/llvm-project?rev=247966&view=rev
Log:
[Concepts] Moving tests to match the corresponding section of the TS
Added:
cfe/trunk/test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.concept/p1.cpp
- copied u
xazax.hun added a comment.
In http://reviews.llvm.org/D12906#248418, @honggyu.kim wrote:
> (3) bug type (bug message)
As far as I remember the other version of this patch exclude any message that
is displayed to the user deliberately, to make the hash more resilient to
changes to those string
compnerd added a comment.
Do you know if GCC requires the = or can you do -fplugin name.so ?
Repository:
rL LLVM
http://reviews.llvm.org/D12903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
dcoughlin added a comment.
Here is a reduced test case:
class B {
public:
B &operator= (const B &v) {
return *this;
}
};
class A {
int a[1];
B b;
};
typedef long int ptrdiff_t;
void copyInto(A *first, A *last, A *result) {
ptrdiff_t n;
for
ikudrin added a comment.
Please, can someone commit the changes as I don't have write permissions?
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Fri Sep 18 00:32:23 2015
New Revision: 247967
URL: http://llvm.org/viewvc/llvm-project?rev=247967&view=rev
Log:
Driver: avoid unnecessary string based operations
Use an enumeration and change the use of the FloatABI from a string to the
enumeration. This avoids the use of
101 - 111 of 111 matches
Mail list logo
