vsk added a subscriber: vsk.
vsk added a comment.
Could you handle the error code coming out of make_absolute? It looks like it
calls current_path(), which can fail in interesting ways.
http://reviews.llvm.org/D12774
___
cfe-commits mailing list
cf
MyDeveloperDay added a subscriber: MyDeveloperDay.
MyDeveloperDay added a comment.
This looks like a good small change.
What is interesting to me is that even the twiki page about template is
inconsistent in its style (https://en.wikipedia.org/wiki/Template_(C%2B%2B)),
so its not like there is
MyDeveloperDay added a comment.
Oh and we might want to run clang-format by the guys at http://cppreference.com
seems they don't like the space either! just saying
http://reviews.llvm.org/D12921
___
cfe-commits mailing list
cfe-commits@lists.
Prazek created this revision.
Prazek added reviewers: rsmith, nlewycky, majnemer.
Prazek added a subscriber: cfe-commits.
Using changes from http://reviews.llvm.org/D12926
http://reviews.llvm.org/D12927
Files:
lib/CodeGen/CodeGenModule.cpp
Index: lib/CodeGen/CodeGenModule.cpp
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+
+ if (auto *VAT = dyn_cast(ElementType.getTypePtr())) {
+auto VATInfo = CGF.getVLASize(VAT);
+Size = llvm::ConstantInt::get(
+CGM.SizeTy,
+
The most important costs are: Maintenance and discoverability of options.
The point here that it this space is utterly irrelevant, it doesn't make a
readability difference ever. Most codebases are inconsistent about it
anyway and I haven't seen a style guide even talking about this.
We never inte
djasper added inline comments.
Comment at: docs/ClangFormatStyleOptions.rst:221-235
@@ -220,3 +220,17 @@
-**AlwaysBreakAfterDefinitionReturnType**
(``DefinitionReturnTypeBreakingStyle``)
+**AlwaysBreakAfterDeclarationReturnType** (``ReturnTypeBreakingStyle``)
+ The function de
djasper added a comment.
Please upload a patch with full file context.
Comment at: docs/ClangFormatStyleOptions.rst:247
@@ -246,1 +246,3 @@
+**AlwaysBreakBeforeElse** (``bool``)
+ If ``true``, always break before ``else``.
Hm, I think these should be grouped
pgousseau added a comment.
Ping !
http://reviews.llvm.org/D12571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MyDeveloperDay updated this revision to Diff 34971.
MyDeveloperDay added a comment.
full file diff
http://reviews.llvm.org/D12492
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineParser.cpp
tools/CMakeLists.txt
unitt
MyDeveloperDay added inline comments.
Comment at: docs/ClangFormatStyleOptions.rst:247
@@ -246,1 +246,3 @@
+**AlwaysBreakBeforeElse** (``bool``)
+ If ``true``, always break before ``else``.
djasper wrote:
> Hm, I think these should be grouped in some way and in
eastig updated this revision to Diff 34973.
eastig added a comment.
Added tests
http://reviews.llvm.org/D12689
Files:
include/ios
src/iostream.cpp
test/std/input.output/iostream.objects/narrow.stream.objects/cerr_init.pass.cpp
test/std/input.output/iostream.objects/narrow.stream.object
djasper added a subscriber: djasper.
djasper added a comment.
The question is how all the other options should be called and how we can
group them nicely so that we don't flood the options configuration page too
much. Maybe it's time for nesting in the configuration class?
http://reviews.llvm.or
The question is how all the other options should be called and how we can
group them nicely so that we don't flood the options configuration page too
much. Maybe it's time for nesting in the configuration class?
On Sep 17, 2015 11:50 AM, "Paul Hoad" wrote:
> MyDeveloperDay added inline comments.
MyDeveloperDay added a comment.
> The point here that it this space is utterly irrelevant
So I totally take the point but if it doesn't matter then why does clang-format
automatically add one to my "template<>" why not simply leave it alone?
> We never intended clang-format to provide control
john.brawn updated this revision to Diff 34977.
john.brawn added a comment.
Add a test.
Repository:
rL LLVM
http://reviews.llvm.org/D12903
Files:
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
test/Driver/load.c
Index: test/Driver/load.c
Author: abadouh
Date: Thu Sep 17 06:56:04 2015
New Revision: 247881
URL: http://llvm.org/viewvc/llvm-project?rev=247881&view=rev
Log:
[X86][AVX512DQ] add new intrinsics
convert i64 to FP and vice versa
reduceps & reducepd
rangeps & rangepd
all in their 512bit versions
Differential Revision: http
rengolin added a comment.
Hi John,
Looks all right to me, but I don't want to approve without someone more
familiar with the -load option to agree that this is not an exclusively
internal option.
Other than that, I'm happy with it.
cheers,
--renato
Repository:
rL LLVM
http://reviews.llvm
Author: chapuni
Date: Thu Sep 17 07:33:34 2015
New Revision: 247882
URL: http://llvm.org/viewvc/llvm-project?rev=247882&view=rev
Log:
Appease clang/test/CodeGen/avx512dq-builtins.c for -Asserts, for now.
Modified:
cfe/trunk/test/CodeGen/avx512dq-builtins.c
Modified: cfe/trunk/test/CodeGen/av
richard.barton.arm added a comment.
Hi all
I am uncomfortable with this patch for a number of reasons. These macros seem
to me to be defined by the ACLE as describing the behaviour of the combination
of library and compiler. For example, the __STDC_IEC_599__ macro would need
some standards com
Alexander_Droste marked 9 inline comments as done.
Alexander_Droste added a comment.
Thanks for the review!
Comment at: tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td:524
@@ +523,3 @@
+def MPIChecker : Checker<"MPI-Checker">,
+ HelpText<"Checks MPI code written in C">,
+
-Asserts was not culprit.
On Thu, Sep 17, 2015 at 9:35 PM NAKAMURA Takumi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chapuni
> Date: Thu Sep 17 07:33:34 2015
> New Revision: 247882
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247882&view=rev
> Log:
> Appease clang/test/Cod
I’m working on revert the patch and fix it.
Will take a moment.
From: NAKAMURA Takumi [mailto:geek4ci...@gmail.com]
Sent: Thursday, September 17, 2015 16:04
To: cfe-commits@lists.llvm.org
Cc: Badouh, Asaf
Subject: Re: r247882 - Appease clang/test/CodeGen/avx512dq-builtins.c for
-Asserts, for now.
Author: abadouh
Date: Thu Sep 17 08:09:33 2015
New Revision: 247883
URL: http://llvm.org/viewvc/llvm-project?rev=247883&view=rev
Log:
revert r.247881 due to tests failures
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cfe/trunk/lib/Headers/avx512dqintrin.h
cfe/trunk/test/Cod
angelgarcia marked 9 inline comments as done.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:494-495
@@ -493,4 +502,2 @@
} else {
- if (Descriptor.DerefByConstRef)
-AutoRefType = Context->getConstType(AutoRefType);
AutoRefType = Context->getLValueRe
angelgarcia updated this revision to Diff 34985.
angelgarcia added a comment.
Split a function and several other small changes.
http://reviews.llvm.org/D12797
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/modernize/LoopConvertCheck.h
test/clang-tidy/modernize-loop-convert-ba
I've commit in r247885 and r247886. I will add something to the
release notes, and watch the bots to see if any tests got missed
(since I did my development on Windows).
Thank you!
~Aaron
On Wed, Sep 16, 2015 at 7:49 PM, Manuel Klimek wrote:
> LG, ship it.
>
> On Wed, Sep 16, 2015 at 2:03 PM Aa
Author: aaronballman
Date: Thu Sep 17 08:31:25 2015
New Revision: 247886
URL: http://llvm.org/viewvc/llvm-project?rev=247886&view=rev
Log:
Refactors AST matching code to use the new AST matcher names. This patch
correlates to r247885 which performs the AST matcher rename in Clang.
Modified:
Author: aaronballman
Date: Thu Sep 17 08:47:22 2015
New Revision: 247887
URL: http://llvm.org/viewvc/llvm-project?rev=247887&view=rev
Log:
Update the 3.8 release notes with the breaking change information regarding AST
matchers.
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/
On Thu, Sep 17, 2015 at 12:17 PM, Paul Hoad
wrote:
> MyDeveloperDay added a comment.
>
> > The point here that it this space is utterly irrelevant
>
>
> So I totally take the point but if it doesn't matter then why does
> clang-format automatically add one to my "template<>" why not simply leave
Sorry to resurrect an ancient commit, but...
On Tue, Jan 8, 2013 at 2:29 PM, Jordan Rose wrote:
> Author: jrose
> Date: Tue Jan 8 13:29:37 2013
> New Revision: 171885
>
> URL: http://llvm.org/viewvc/llvm-project?rev=171885&view=rev
> Log:
> Various tweaks and updates to the analyzer website.
>
>
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: klimek, cfe-commits.
Add the test about replacements in several arguments of the same macro call,
now that the problem has been fixed.
http://reviews.llvm.org/D12933
Files:
test/clang-tidy/
amusman updated this revision to Diff 34987.
amusman added a comment.
Hi Aaron,
Thank you for review. I've updated the warning for such cases.
Regards,
Alexander
http://reviews.llvm.org/D12904
Files:
lib/Sema/Sema.cpp
lib/Sema/SemaDecl.cpp
test/CodeGen/pragma-weak.c
Index: lib/Sema/Sem
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a comment.
Comment at: test/clang-tidy/modernize-loop-convert-extra.cpp:705
@@ -704,16 +704,3 @@
- // FIXME: Right now, clang-tidy does not allow to make insertions
angelgarcia updated this revision to Diff 34993.
angelgarcia added a comment.
Done.
http://reviews.llvm.org/D12933
Files:
test/clang-tidy/modernize-loop-convert-extra.cpp
Index: test/clang-tidy/modernize-loop-convert-extra.cpp
=
Author: angelgarcia
Date: Thu Sep 17 09:25:39 2015
New Revision: 247889
URL: http://llvm.org/viewvc/llvm-project?rev=247889&view=rev
Log:
Add a test to modernize-loop-convert.
Summary: Add the test about replacements in several arguments of the same macro
call, now that the problem has been fixe
jpienaar added a comment.
Nice, so this will allow parsing/AST construction with builtins from 2
architectures but will fail to compile if a builtin for the host/device is
called from device/host.
You mention this is not generally possible. Can you give some examples?
Comment
Author: alexfh
Date: Thu Sep 17 09:37:26 2015
New Revision: 247890
URL: http://llvm.org/viewvc/llvm-project?rev=247890&view=rev
Log:
[clang-tidy] install helper scripts
Scripts are installed in same location as clang-fromat ones, so I think will be
good idea to not create dedicated directory.
I
alexfh added a comment.
LG. Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D12700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247890: [clang-tidy] install helper scripts (authored by
alexfh).
Changed prior to commit:
http://reviews.llvm.org/D12700?vs=34953&id=34997#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12700
Fi
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with one minor nit.
Comment at: lib/Sema/Sema.cpp:729
@@ +728,3 @@
+ Diag(WeakID.second.getLocation(), d
Author: abadouh
Date: Thu Sep 17 09:53:37 2015
New Revision: 247892
URL: http://llvm.org/viewvc/llvm-project?rev=247892&view=rev
Log:
re-apply r.247881
fixed the tests.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cfe/trunk/lib/Headers/avx512dqintrin.h
cfe/trunk/test/CodeGe
dougk updated this revision to Diff 34998.
dougk marked 3 inline comments as done.
dougk added a comment.
Use the same logic as Solaris::Solaris to die in the toolchain constructor if
getArch() is unexpected.
Also don't hardcode -EL in linker.
http://reviews.llvm.org/D12541
Files:
lib/Driver
ksuther added a comment.
Adding another comment in hopes of getting some visibility on this. Do I need
to add other people as reviewers?
http://reviews.llvm.org/D12501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
ksuther added a comment.
Adding another comment in hopes of getting some visibility on this. Do I need
to add other people as reviewers?
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
tyomitch created this revision.
tyomitch added reviewers: labrinea, rengolin.
tyomitch added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
Currently, the availability of DSP instructions (ACLE 6.4.7) is handled in a
hand-rolled tricky condition block in lib/Basic/Target
compnerd added a subscriber: compnerd.
compnerd added a comment.
While I agree that this makes the option much nicer to use, it collides with
the -l flag. Since it was an internal only option until this point, we should
rename it before exposing it at the driver level.
Repository:
rL LLVM
Author: adrian
Date: Thu Sep 17 10:58:54 2015
New Revision: 247895
URL: http://llvm.org/viewvc/llvm-project?rev=247895&view=rev
Log:
Fix a typo.
Modified:
cfe/trunk/docs/Modules.rst
Modified: cfe/trunk/docs/Modules.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/Modules.rst?rev=
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks like I forgot to submit the comments I wrote. Anyway, looks good.
Comment at: cfe/trunk/lib/Driver/MSVCToolChain.cpp:238
@@ +237,3 @@
+ continue;
+const StringRef Can
john.brawn added a comment.
In http://reviews.llvm.org/D12903#247934, @compnerd wrote:
> While I agree that this makes the option much nicer to use, it collides with
> the -l flag. Since it was an internal only option until this point, we
> should rename it before exposing it at the driver lev
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:377
@@ -376,1 +376,3 @@
+(!Contexts.back().ColonIsDictLiteral ||
+ Style.Language != FormatStyle::LK_Cpp)) ||
Style.Language == FormatStyle::LK_Proto) &&
--
ikudrin added a comment.
I found a new problem, after install WDK. I'll submit a new version in a moment.
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
I wonder if 'notailcall' be better, since it contains a verb (like 'noinline').
I don't have a strong opinion; just putting the alternative out there.
> On 2015-Sep-16, at 19:21, Akira Hatanaka via cfe-commits
> wrote:
>
> ahatanak created this revision.
> ahatanak added a reviewer: aaron.bal
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
I wonder if 'notailcall' be better, since it contains a verb (like 'noinline').
I don't have a strong opinion; just putting the alternative out there.
http://reviews.llvm.org/D12922
__
jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.
Other than minor comments, lgtm.
Comment at: lib/Driver/ToolChains.cpp:3937
@@ +3936,3 @@
+ default:
+llvm_unreachable("Unsupported architecture");
+ case llvm::Trip
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:1060-1061
@@ +1059,4 @@
+ nextToken();
+ while (!eof()) {
+// FIXME: Once we have an expression parser in the UnwrappedLineParser,
+// replace this by using parseAssigmentExpres
Author: dougk
Date: Thu Sep 17 11:45:12 2015
New Revision: 247900
URL: http://llvm.org/viewvc/llvm-project?rev=247900&view=rev
Log:
createOutputFile should set Error to something if it returns null.
This is not portably unit-testable because the only visible
effect is a change from one random mes
ikudrin marked an inline comment as done.
ikudrin added a comment.
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ikudrin updated this revision to Diff 35013.
ikudrin added a comment.
Skip directories like C:\Program Files (x86)\Windows Kits\10\Include\wdf, which
come from WDK installation, when looking for SDK version. Now, we detect
directories even better than vsvars32.bat in that situation.
http://rev
Author: rnk
Date: Thu Sep 17 12:04:13 2015
New Revision: 247902
URL: http://llvm.org/viewvc/llvm-project?rev=247902&view=rev
Log:
Use the MSVC SEH personalities on Mingw
Mingw generally wraps an old copy of msvcrt.dll which has these
personalities, so things should work out, or so I hear. I haven
john.brawn retitled this revision from "Allow the -load option in the driver
and pass it through to -cc1" to "Add -fplugin=name.so option to the driver".
john.brawn updated the summary for this revision.
john.brawn updated this revision to Diff 35014.
john.brawn added a comment.
Rename option fro
tra updated this revision to Diff 35015.
tra marked an inline comment as done.
tra added a comment.
cosmetic fixes.
http://reviews.llvm.org/D12917
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/Builtins.h
include/clang/Driver/CC1Options.td
include/clang/Frontend/CompilerInsta
tra marked an inline comment as done.
tra added a comment.
In http://reviews.llvm.org/D12917#247868, @jpienaar wrote:
> Nice, so this will allow parsing/AST construction with builtins from 2
> architectures but will fail to compile if a builtin for the host/device is
> called from device/host.
ksuther added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:377
@@ -376,1 +376,3 @@
+(!Contexts.back().ColonIsDictLiteral ||
+ Style.Language != FormatStyle::LK_Cpp)) ||
Style.Language == FormatStyle::LK_Proto) &&
--
Author: cbieneman
Date: Thu Sep 17 13:30:20 2015
New Revision: 247912
URL: http://llvm.org/viewvc/llvm-project?rev=247912&view=rev
Log:
[CMake] Add install-clang target to install just the clang executable
For the llvm-tools we're generating install-${tool} targets which are very
useful. We shou
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:871
@@ +870,3 @@
+ if (RetRegion) {
+State = setDynamicTypeInfo(State, RetRegion, ResultType,
+ /*CanBeSubclass=*/true);
Would it
xazax.hun updated this revision to Diff 35027.
xazax.hun added a comment.
Addressed the comments.
http://reviews.llvm.org/D12916
Files:
lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp
test/Analysis/DynamicTypePropagation.m
Index: test/Analysis/DynamicTypePropagation.m
==
xazax.hun marked an inline comment as done.
Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:871
@@ +870,3 @@
+ if (RetRegion && !State->get(RetRegion)) {
+// TODO: we have duplicated information in DynamicTypeMap and
+// MostSpecializedTypeArgsMap. We s
strager added a comment.
Should we remove `ObjCSpaceBeforeProtocolList`? It has the same problem as the
`SpaceAfterTemplateKeyword` I am introducing.
http://reviews.llvm.org/D12921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
Lets says this: I am not happy about it and wouldn't allow it if it was
added now. However, *removing* it actually has additional costs, so I am
not inclined to do so now.
On Thu, Sep 17, 2015 at 9:52 PM, strager wrote:
> strager added a comment.
>
> Should we remove `ObjCSpaceBeforeProtocolList
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D12927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: dougk
Date: Thu Sep 17 14:56:40 2015
New Revision: 247924
URL: http://llvm.org/viewvc/llvm-project?rev=247924&view=rev
Log:
[Shave]: Drive sparc-myriad-elf-ld directly rather than via gcc.
Differential Revision: http://reviews.llvm.org/D12541
Added:
cfe/trunk/test/Driver/Inputs/basic
This revision was automatically updated to reflect the committed changes.
dougk marked 2 inline comments as done.
Closed by commit rL247924: [Shave]: Drive sparc-myriad-elf-ld directly rather
than via gcc. (authored by dougk).
Changed prior to commit:
http://reviews.llvm.org/D12541?vs=34998&id=
echristo added a comment.
One inline request and one inline comment, otherwise looks pretty good!
Thanks :)
-eric
Comment at: include/clang/Frontend/CompilerInstance.h:355
@@ -350,3 +354,3 @@
- /// Replace the current diagnostics engine.
+ /// Replace the current Target.
strager marked 2 inline comments as done.
Comment at: lib/Format/UnwrappedLineParser.cpp:1060-1061
@@ +1059,4 @@
+ nextToken();
+ while (!eof()) {
+// FIXME: Once we have an expression parser in the UnwrappedLineParser,
+// replace this by using parseAssi
Author: dougk
Date: Thu Sep 17 15:00:09 2015
New Revision: 247926
URL: http://llvm.org/viewvc/llvm-project?rev=247926&view=rev
Log:
[Shave]: Rename test file from 'shave-' to 'myriad-'
Added:
cfe/trunk/test/Driver/myriad-toolchain.c
- copied, changed from r247924, cfe/trunk/test/Driver/
Author: tra
Date: Thu Sep 17 15:19:33 2015
New Revision: 247930
URL: http://llvm.org/viewvc/llvm-project?rev=247930&view=rev
Log:
Fixed the comment to match reality.
Modified:
cfe/trunk/include/clang/Frontend/CompilerInstance.h
Modified: cfe/trunk/include/clang/Frontend/CompilerInstance.h
UR
Author: dougk
Date: Thu Sep 17 15:25:09 2015
New Revision: 247932
URL: http://llvm.org/viewvc/llvm-project?rev=247932&view=rev
Log:
Try to unbreak windows compiler after r247926.
It might not like {} implicitly cast to an Arrayref.
That's the theory, since I can't test it.
Modified:
cfe/trun
Author: prazek
Date: Thu Sep 17 15:25:46 2015
New Revision: 247933
URL: http://llvm.org/viewvc/llvm-project?rev=247933&view=rev
Log:
Using MD_invariant_group
http://reviews.llvm.org/D12927
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
UR
On Thu, Sep 17, 2015 at 1:25 PM, Douglas Katzman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dougk
> Date: Thu Sep 17 15:25:09 2015
> New Revision: 247932
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247932&view=rev
> Log:
> Try to unbreak windows compiler after r247926.
>
>
cdavis5x added a comment.
Ping...
http://reviews.llvm.org/D1623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra updated this revision to Diff 35031.
tra marked an inline comment as done.
tra added a comment.
Updated to address Eric's comments.
http://reviews.llvm.org/D12917
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/Builtins.h
include/clang/Driver/CC1Options.td
include/clang/Fr
tra marked 2 inline comments as done.
Comment at: lib/Frontend/CompilerInstance.cpp:82-87
@@ -84,6 +81,8 @@
+void CompilerInstance::setTarget(TargetInfo *Value) { Target = Value; }
+void CompilerInstance::setAuxTarget(TargetInfo *Value) { AuxTarget = Value; }
void CompilerInsta
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
I think this is ready.
http://reviews.llvm.org/D1623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Works for me. Thanks!
-eric
http://reviews.llvm.org/D12917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: cdavis
Date: Thu Sep 17 15:55:33 2015
New Revision: 247941
URL: http://llvm.org/viewvc/llvm-project?rev=247941&view=rev
Log:
Support __builtin_ms_va_list.
Summary:
This change adds support for `__builtin_ms_va_list`, a GCC extension for
variadic `ms_abi` functions. The existing `__builtin
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, klimek.
aaron.ballman added a subscriber: cfe-commits.
Some object types are not meant to be used as a value type in all
circumstances, but the language (mainly C) does not provide facilities for
marking these types as n
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247941: Support __builtin_ms_va_list. (authored by cdavis).
Changed prior to commit:
http://reviews.llvm.org/D1623?vs=34728&id=35036#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1623
Files:
cf
Author: dougk
Date: Thu Sep 17 16:20:16 2015
New Revision: 247948
URL: http://llvm.org/viewvc/llvm-project?rev=247948&view=rev
Log:
[Myriad]: add "/include" to standard search path
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/ToolChains.h
cfe/trunk/test/Driver/my
strager added inline comments.
Comment at: docs/ClangFormatStyleOptions.rst:221-235
@@ -220,3 +220,17 @@
-**AlwaysBreakAfterDefinitionReturnType**
(``DefinitionReturnTypeBreakingStyle``)
+**AlwaysBreakAfterDeclarationReturnType** (``ReturnTypeBreakingStyle``)
+ The function de
strager updated this revision to Diff 35038.
strager added a comment.
Fix missing IsDefinition check in ContinuationIndenter::canBreak.
http://reviews.llvm.org/D10370
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/For
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zhengkai marked 2 inline comments as done.
Comment at: lib/Frontend/DiagnosticRenderer.cpp:455
@@ -419,1 +454,3 @@
+static bool checkLocForMacroArgExpansion(SourceLocation Loc,
+ const SourceManager &SM,
Because the functi
cynecx added a comment.
Hi :),
First of all, I would like to say that I am new into all the clang stuff
(software architecture/internal concepts) but I wanted to start hacking clang
so I went here to check out some ##trivial## clang bugs to fix so I can learn
internal stuff about clang, with i
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:871
@@ +870,3 @@
+ if (RetRegion && !State->get(RetRegion)) {
+// TODO: we have duplicated information in DynamicTypeMap and
+// MostSpecializedTypeArgsMap. We should only
Author: chapuni
Date: Thu Sep 17 20:02:50 2015
New Revision: 247959
URL: http://llvm.org/viewvc/llvm-project?rev=247959&view=rev
Log:
clang/test/Driver/myriad-toolchain.c: Tweak for DOSish path.
Modified:
cfe/trunk/test/Driver/myriad-toolchain.c
Modified: cfe/trunk/test/Driver/myriad-toolcha
zaks.anna added a comment.
> > It's more user friendly to report this issue at the last point where the
> > request is available rather than the last line of the function.
>
> > This looks similar to leak report checking. Is it?
>
>
> Yes, that's not very common but possible.
> Does th
zaks.anna added a comment.
This new patch does not seem to build on top of http://reviews.llvm.org/D10305
but is an alternative way of generating the hash that reuses a lot of the
building blocks from the other patch. What is the reason for that?
(It also addresses your comment to this patch an
zaks.anna added a comment.
I see, Maybe we should add a new test file to test this instead of adding it to
an existing test.
http://reviews.llvm.org/D12119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Otherwise, LGTM.
http://reviews.llvm.org/D12119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
1 - 100 of 111 matches
Mail list logo
