Re: PATCH: Expose the 'file' that is associated with a compile database command

On Thu, Sep 10, 2015 at 8:36 PM Argyrios Kyrtzidis wrote: > On Sep 10, 2015, at 1:48 AM, Manuel Klimek wrote: > > @@ -179,11 +185,13 @@ public: >/// \param Directory The base directory used in the > FixedCompilationDatabase. >static FixedCompilationDatabase *loadFromCommandLine(int &Argc

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

seaneveson added a comment. In http://reviews.llvm.org/D12358#241631, @cfe-commits wrote: > Hi Sean, > > Ted provided more details off-list. He suspects that the problem is that we > likely don't add MemSpaceRegions to the worklist because every region is a > subregion of a MemSpaceRegion, and

r247392 - Fix \param in r247251. [-Wdocumentation]

Author: chapuni Date: Fri Sep 11 03:13:32 2015 New Revision: 247392 URL: http://llvm.org/viewvc/llvm-project?rev=247392&view=rev Log: Fix \param in r247251. [-Wdocumentation] Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h URL: http://llvm

[clang-tools-extra] r247394 - clang-tidy/misc-sizeof-container.cpp: Add explicit triple.

Author: chapuni Date: Fri Sep 11 03:16:30 2015 New Revision: 247394 URL: http://llvm.org/viewvc/llvm-project?rev=247394&view=rev Log: clang-tidy/misc-sizeof-container.cpp: Add explicit triple. For targeting LLP64, like Windows x86, size_t is not unsigned long. tools/clang/tools/extra/test/cla

[clang-tools-extra] r247393 - clang-tidy/readability-inconsistent-declaration-parameter-name.cpp: Appease MS-incompatibility [-fno-delayed-template-parsing]

Author: chapuni Date: Fri Sep 11 03:16:22 2015 New Revision: 247393 URL: http://llvm.org/viewvc/llvm-project?rev=247393&view=rev Log: clang-tidy/readability-inconsistent-declaration-parameter-name.cpp: Appease MS-incompatibility [-fno-delayed-template-parsing] Modified: clang-tools-extra/tr

r247396 - clang/test/Modules/ExtDebugInfo.cpp: Use [[@LINE]].

Author: chapuni Date: Fri Sep 11 03:53:29 2015 New Revision: 247396 URL: http://llvm.org/viewvc/llvm-project?rev=247396&view=rev Log: clang/test/Modules/ExtDebugInfo.cpp: Use [[@LINE]]. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp URL:

r247397 - clang/test/Modules/ExtDebugInfo.cpp: Use %itanium_abi_triple.

Author: chapuni Date: Fri Sep 11 03:56:12 2015 New Revision: 247397 URL: http://llvm.org/viewvc/llvm-project?rev=247397&view=rev Log: clang/test/Modules/ExtDebugInfo.cpp: Use %itanium_abi_triple. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.

Re: [PATCH] D12734: Another patch for modernize-loop-convert.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D12734#243157, @angelgarcia wrote: > Comment the enumerators. > > > Do we need default? > > > I think so. We need to set the cases that do not fall in any of these >

Re: [PATCH] D12734: Another patch for modernize-loop-convert.

angelgarcia updated this revision to Diff 34535. angelgarcia added a comment. Add examples of 'default' usages. http://reviews.llvm.org/D12734 Files: clang-tidy/modernize/LoopConvertCheck.cpp clang-tidy/modernize/LoopConvertCheck.h clang-tidy/modernize/LoopConvertUtils.cpp clang-tidy/mo

[clang-tools-extra] r247399 - Another patch for modernize-loop-convert.

Author: angelgarcia Date: Fri Sep 11 05:02:07 2015 New Revision: 247399 URL: http://llvm.org/viewvc/llvm-project?rev=247399&view=rev Log: Another patch for modernize-loop-convert. Summary: 1. Avoid converting loops that iterate over the size of a container and don't use its elements, as this wou

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev added a comment. Richard, any comments about latest version? http://reviews.llvm.org/D10599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev added a comment. Richard? http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r247401 - [OPENMP] Preserve alignment of the original variables for the captured references.

Author: abataev Date: Fri Sep 11 05:29:41 2015 New Revision: 247401 URL: http://llvm.org/viewvc/llvm-project?rev=247401&view=rev Log: [OPENMP] Preserve alignment of the original variables for the captured references. Patch makes codegen to preserve alignment of the shared variables captured and

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

eastig added a comment. In http://reviews.llvm.org/D12689#243592, @rsmith wrote: > Can we instead fix this in Clang by ensuring that libc++ is put at the right > position in the static link order so that its initializers run first? > libc++'s avoidance of running iostreams init code from every

[PATCH] D12797: Refactor LoopConvertCheck.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: alexfh, cfe-commits. Reorder the code in a more logical and understandable way. http://reviews.llvm.org/D12797 Files: clang-tidy/modernize/LoopConvertCheck.cpp clang-tidy/modernize/LoopCon

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

This doesn't seem to work here, VS 2015 on Win 10 x64: C:\Users\ismail\Desktop>clang-cl.exe -fms-compatibility-version=19 foo.cpp LINK : fatal error LNK1104: cannot open file 'kernel32.lib' clang-cl.exe: error: linker command failed with exit code 1104 (use -v to see invocation) Works fine after

r247404 - Fixed HasDeclarationMatcher to properly convert all types into decls where possible. Added objcObjectPointerType(), objcInterfaceDecl(), templateTypeParmType(), injectedClassNameType(), and

Author: aaronballman Date: Fri Sep 11 06:51:24 2015 New Revision: 247404 URL: http://llvm.org/viewvc/llvm-project?rev=247404&view=rev Log: Fixed HasDeclarationMatcher to properly convert all types into decls where possible. Added objcObjectPointerType(), objcInterfaceDecl(), templateTypeParmType

Re: [PATCH] D12736: [PATCH] AST traversal from types to decls

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r247404. http://reviews.llvm.org/D12736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

eastig added a comment. In http://reviews.llvm.org/D12689#243674, @jroelofs wrote: > A testcase would be good, regardless of which of the proposed fixes ends up > being chosen. I will write it. http://reviews.llvm.org/D12689 ___ cfe-commits mail

Re: recordDecl() AST matcher

Ping? On Tue, Sep 8, 2015 at 9:26 AM, Manuel Klimek wrote: > On Tue, Sep 8, 2015 at 3:23 PM Aaron Ballman wrote: >> >> On Tue, Sep 8, 2015 at 9:18 AM, Manuel Klimek wrote: >> > On Tue, Sep 8, 2015 at 2:23 PM Aaron Ballman >> > wrote: >> >> >> >> On Tue, Sep 8, 2015 at 5:40 AM, Manuel Klimek >

Re: [clang-tools-extra] r247393 - clang-tidy/readability-inconsistent-declaration-parameter-name.cpp: Appease MS-incompatibility [-fno-delayed-template-parsing]

Thank you for the fix and sorry for breaking this again. I wonder what's the reason windows-targeting enables -fdelayed-template-parsing? Would it be the right thing to always turn this off in clang-tidy? On Fri, Sep 11, 2015 at 10:16 AM, NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.or

Re: [clang-tools-extra] r247393 - clang-tidy/readability-inconsistent-declaration-parameter-name.cpp: Appease MS-incompatibility [-fno-delayed-template-parsing]

On Fri, Sep 11, 2015 at 9:27 AM, Alexander Kornienko via cfe-commits wrote: > Thank you for the fix and sorry for breaking this again. I wonder what's the > reason windows-targeting enables -fdelayed-template-parsing? Because that's required for MSVC compatibility. > Would it be the right thing

Re: recordDecl() AST matcher

Richard! We need an informed opinion :D On Fri, Sep 11, 2015 at 3:07 PM Aaron Ballman wrote: > Ping? > > On Tue, Sep 8, 2015 at 9:26 AM, Manuel Klimek wrote: > > On Tue, Sep 8, 2015 at 3:23 PM Aaron Ballman > wrote: > >> > >> On Tue, Sep 8, 2015 at 9:18 AM, Manuel Klimek > wrote: > >> > On Tu

r247410 - This test requires UTF-8 output to print the UT-8 characters.

Author: yrnkrn Date: Fri Sep 11 08:29:12 2015 New Revision: 247410 URL: http://llvm.org/viewvc/llvm-project?rev=247410&view=rev Log: This test requires UTF-8 output to print the UT-8 characters. Modified: cfe/trunk/test/Frontend/source-col-map.c Modified: cfe/trunk/test/Frontend/source-col-

Re: r247410 - This test requires UTF-8 output to print the UT-8 characters.

Thank you for this! I wasn't certain of what the right way to fix it was. :-) ~Aaron On Fri, Sep 11, 2015 at 9:29 AM, Yaron Keren via cfe-commits wrote: > Author: yrnkrn > Date: Fri Sep 11 08:29:12 2015 > New Revision: 247410 > > URL: http://llvm.org/viewvc/llvm-project?rev=247410&view=rev > Log

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

Please, can you show the output of the following commands: 1) set include 2) set lib 3) clang-cl.exe -### -fms-compatibility-version=19 foo.cpp On 11.09.2015 17:44, İsmail Dönmez wrote: This doesn't seem to work here, VS 2015 on Win 10 x64: C:\Users\ismail\Desktop>clang-cl.exe -fms-compatibili

Re: r247410 - This test requires UTF-8 output to print the UT-8 characters.

The test was passing before r247253 without LLVM_ON_WIN32 defined in lib/Support/Locale.cpp, so the llvm::sys::unicode::* functions were used, which may mean that the LLVM_ON_WIN32 functions are overly restrictive. For example, Windows can output the UTF-8 character from source-col-map.c correctly.

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

Hi, C:\Users\ismail\Desktop>set include INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE;C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\ucrt;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6\inc

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

Hi İsmail, Clang tries to detect pathes automatically only if corresponding environment variables are not set. In your case, you have these variables set, so clang honors them. You have only set pathes for VC libraries and Universal CRT, but the kernel32.lib library is shipped with Windows S

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

Hi, On Fri, Sep 11, 2015 at 5:03 PM, Igor Kudrin wrote: > Hi İsmail, > > Clang tries to detect pathes automatically only if corresponding environment > variables are not set. In your case, you have these variables set, so clang > honors them. In the original case no variable was set, I thought y

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

Hi İsmail, It looks like we need a new logic to detect a Windows 10 SDK installation folder. I'll fill the bug about that. Thank you. On 11.09.2015 20:11, İsmail Dönmez wrote: Hi, On Fri, Sep 11, 2015 at 5:03 PM, Igor Kudrin wrote: Hi İsmail, Clang tries to detect pathes automatically on

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

dcoughlin added a comment. I'll look at this today. Thanks for your patience! http://reviews.llvm.org/D12358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

rnk added inline comments. Comment at: lib/Sema/SemaType.cpp:5876 @@ +5875,3 @@ + +if (!IsCtorOrDtor) { + if (CurCC != DefaultCC || DefaultCC == ToCC) This looks like the !IsCtorOrDtor check that affects Itanium. Isn't it already handled for MS C++ above

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

> On Sep 10, 2015, at 6:56 PM, David Blaikie wrote: > > > > On Thu, Sep 10, 2015 at 6:40 PM, David Blaikie > wrote: > > > On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Thu Sep

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

On Fri, Sep 11, 2015 at 8:18 AM, Adrian Prantl wrote: > > On Sep 10, 2015, at 6:56 PM, David Blaikie wrote: > > > > On Thu, Sep 10, 2015 at 6:40 PM, David Blaikie wrote: > >> >> >> On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Auth

r247421 - [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

Author: vedantk Date: Fri Sep 11 10:40:05 2015 New Revision: 247421 URL: http://llvm.org/viewvc/llvm-project?rev=247421&view=rev Log: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst When uses of personality functions were moved from LandingPadInst to Function, we forgot to up

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk accepted this revision. vsk added a reviewer: vsk. vsk marked an inline comment as done. vsk added a comment. This revision is now accepted and ready to land. Committed r247421 http://reviews.llvm.org/D12743 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

xazax.hun added inline comments. Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517 @@ -511,1 +514,5 @@ + /// Returns true if lambdas should be inlined. Otherwise a sink node will be + /// generated each time a LambdaExpr is visited. + bool shouldInlineLa

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rnk added a subscriber: rnk. rnk added a comment. I'm confused. I thought SimplifyPersonalityFunction was an optimization, but somehow it caused link failures? Why do you think this was an ABI break? Comment at: test/CodeGenObjCXX/exception-cxx.mm:8 @@ +7,3 @@ + throw 0; +

r247423 - [Static Analyzer] Minor cleanups for the nullability checker.

Author: xazax Date: Fri Sep 11 11:29:05 2015 New Revision: 247423 URL: http://llvm.org/viewvc/llvm-project?rev=247423&view=rev Log: [Static Analyzer] Minor cleanups for the nullability checker. Differential Revision: http://reviews.llvm.org/D12619 Modified: cfe/trunk/lib/StaticAnalyzer/Chec

Re: [PATCH] D12619: [Static Analyzer] Minor cleanups for the nullability checker.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247423: [Static Analyzer] Minor cleanups for the nullability checker. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12619?vs=34458&id=34553#toc Repository: rL LLVM http://re

r247424 - [SEH] Port __try / __leave test to new IR

Author: rnk Date: Fri Sep 11 11:29:27 2015 New Revision: 247424 URL: http://llvm.org/viewvc/llvm-project?rev=247424&view=rev Log: [SEH] Port __try / __leave test to new IR It turns out that the IR we already generate for __leave is fine, so no code changes were needed. Added: cfe/trunk/test/

Re: PATCH: Expose the 'file' that is associated with a compile database command

> On Sep 11, 2015, at 12:21 AM, Manuel Klimek wrote: > > On Thu, Sep 10, 2015 at 8:36 PM Argyrios Kyrtzidis > wrote: >> On Sep 10, 2015, at 1:48 AM, Manuel Klimek > > wrote: >> >> @@ -179,11 +185,13 @@ public: >>/// \param Directory The

Re: [PATCH] D12767: [Static Analyzer] Properly clean up the dynamic type information for dead regions.

xazax.hun updated this revision to Diff 34554. xazax.hun added a comment. - Addressed the comments. http://reviews.llvm.org/D12767 Files: include/clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeMap.h include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h lib/StaticAnalyzer/Chec

Re: [PATCH] D12767: [Static Analyzer] Properly clean up the dynamic type information for dead regions.

xazax.hun marked 2 inline comments as done. xazax.hun added a comment. http://reviews.llvm.org/D12767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r247426 - [Static Analyzer] Lambda support.

Author: xazax Date: Fri Sep 11 11:55:01 2015 New Revision: 247426 URL: http://llvm.org/viewvc/llvm-project?rev=247426&view=rev Log: [Static Analyzer] Lambda support. Differential Revision: http://reviews.llvm.org/D12652 Added: cfe/trunk/test/Analysis/lambda-notes.cpp Modified: cfe/trunk

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247426: [Static Analyzer] Lambda support. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12652?vs=34498&id=34555#toc Repository: rL LLVM http://reviews.llvm.org/D12652 Files

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

xazax.hun added inline comments. Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517 @@ -511,1 +514,5 @@ + /// Returns true if lambdas should be inlined. Otherwise a sink node will be + /// generated each time a LambdaExpr is visited. + bool shouldInlineLa

r247430 - [Static Analyzer] Properly clean up the dynamic type information for dead regions.

Author: xazax Date: Fri Sep 11 12:19:57 2015 New Revision: 247430 URL: http://llvm.org/viewvc/llvm-project?rev=247430&view=rev Log: [Static Analyzer] Properly clean up the dynamic type information for dead regions. Differential Revision: http://reviews.llvm.org/D12767 Added: cfe/trunk/incl

Re: [PATCH] D12767: [Static Analyzer] Properly clean up the dynamic type information for dead regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247430: [Static Analyzer] Properly clean up the dynamic type information for dead… (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12767?vs=34554&id=34559#toc Repository: rL LL

r247432 - Module Debugging: Emit forward declarations for types that are defined in

Author: adrian Date: Fri Sep 11 12:23:08 2015 New Revision: 247432 URL: http://llvm.org/viewvc/llvm-project?rev=247432&view=rev Log: Module Debugging: Emit forward declarations for types that are defined in clang modules, if -dwarf-ext-refs (DebugTypesExtRefs) is specified. This reimplements r247

Re: PATCH: Expose the 'file' that is associated with a compile database command

Ok, looked at the original patch again, and if we're fixing the FixedCompilationDatabase to only insert the file when it actually produces a CompileCommand it seems to be fine. On Fri, Sep 11, 2015 at 6:32 PM Argyrios Kyrtzidis wrote: > On Sep 11, 2015, at 12:21 AM, Manuel Klimek wrote: > > On

r247431 - Revert "Module Debugging: Emit forward declarations for types that are defined in"

Author: adrian Date: Fri Sep 11 12:23:03 2015 New Revision: 247431 URL: http://llvm.org/viewvc/llvm-project?rev=247431&view=rev Log: Revert "Module Debugging: Emit forward declarations for types that are defined in" This reverts commit r247369 to facilitate reviewing of the following patch. Rem

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

> On Sep 11, 2015, at 8:27 AM, David Blaikie wrote: > > > > On Fri, Sep 11, 2015 at 8:18 AM, Adrian Prantl > wrote: > >> On Sep 10, 2015, at 6:56 PM, David Blaikie > > wrote: >> >> >> >> On Thu, Sep 10, 2015 at 6:40 PM, David Blaikie >

r247434 - Update test expectations for LLVM asm printing change

Author: rnk Date: Fri Sep 11 12:27:53 2015 New Revision: 247434 URL: http://llvm.org/viewvc/llvm-project?rev=247434&view=rev Log: Update test expectations for LLVM asm printing change Modified: cfe/trunk/test/CodeGen/exceptions-seh-new.c Modified: cfe/trunk/test/CodeGen/exceptions-seh-new.c

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk added a comment. I think 'optimization' is a bit of a misnomer. There's a comment in this code that reads: "Can't do the optimization if it has non-C++ uses", so that's why I picked up the word. Without SimplifyPersonality(), some objective c++ code can no longer link against c++ libraries.

r247436 - [CMake] Making the bootstrap-clear target always delete the boostrap build directories.

Author: cbieneman Date: Fri Sep 11 12:38:38 2015 New Revision: 247436 URL: http://llvm.org/viewvc/llvm-project?rev=247436&view=rev Log: [CMake] Making the bootstrap-clear target always delete the boostrap build directories. Modified: cfe/trunk/CMakeLists.txt Modified: cfe/trunk/CMakeLists.t

r247437 - [test] Specify exception object type in two tests

Author: vedantk Date: Fri Sep 11 12:39:34 2015 New Revision: 247437 URL: http://llvm.org/viewvc/llvm-project?rev=247437&view=rev Log: [test] Specify exception object type in two tests Replace: 'try { throw 0; } catch (...)' with 'try { throw 0; } catch (int e)' in two test cases. Differ

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

This revision was automatically updated to reflect the committed changes. Closed by commit rL247437: [test] Specify exception object type in two tests (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D12743?vs=34408&id=34560#toc Repository: rL LLVM http://reviews.llvm

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk marked an inline comment as done. vsk added a comment. Addressed Reid's comment w.r.t exception object type. Repository: rL LLVM http://reviews.llvm.org/D12743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rnk added a comment. Right, I understand the behavior change, I'm just wondering why it results in link failures. There isn't a ton of public info about how ObjC++ EH interacts with C++ EH. Repository: rL LLVM http://reviews.llvm.org/D12743 ___

r247438 - Use Itanium C++ ABI triple for new modules+debug test

Author: rnk Date: Fri Sep 11 12:50:14 2015 New Revision: 247438 URL: http://llvm.org/viewvc/llvm-project?rev=247438&view=rev Log: Use Itanium C++ ABI triple for new modules+debug test Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp URL: ht

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

This made the Chromium build sad. For example: http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/3092/steps/compile/logs/stdio Reduction: $ clang -cc1 -triple i686-pc-windows-msvc18.0.0 -w -fms-extensions -fms-compatibility -fms-compatibility-version=18.0 -std=c++11 -fdelayed-t

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk added a comment. Ah, ok. We have some objective-c++ code which calls into a boost routine which throws an exception. That results in an undefined reference to ___objc_personality_v0, because the boost library we linked against doesn't have ___objc_personality_v0. Should the compiler have f

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

Taking a look, would appreciate it if we didn't revert this until I give it a fair shot. Shouldn't take too long. On Fri, Sep 11, 2015 at 10:58 AM, Hans Wennborg wrote: > This made the Chromium build sad. For example: > > http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/3092

[PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

mspertus created this revision. mspertus added a subscriber: cfe-commits. The Token visualizer in clang.natvis makes debugging Clang in Visual Studio much easier for keywords (because a given keyword is always the same), but it doesn't work very well for identifiers (because they are all differe

Re: [PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank for you this (I think it's going to help me out quite a bit)! http://r

Re: r247432 - Module Debugging: Emit forward declarations for types that are defined in

On Fri, Sep 11, 2015 at 10:23 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Fri Sep 11 12:23:08 2015 > New Revision: 247432 > > URL: http://llvm.org/viewvc/llvm-project?rev=247432&view=rev > Log: > Module Debugging: Emit forward declarations for ty

r247442 - Extend the Token visualizer used by MSVC to display the identifier text for tok::identifier tokens.

Author: aaronballman Date: Fri Sep 11 13:35:18 2015 New Revision: 247442 URL: http://llvm.org/viewvc/llvm-project?rev=247442&view=rev Log: Extend the Token visualizer used by MSVC to display the identifier text for tok::identifier tokens. Patch by Mike Spertus. Modified: cfe/trunk/utils/cla

Re: [PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r247442, thank you for the patch! http://reviews.llvm.org/D12807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

mspertus added a comment. Thanks, Aaron! Hal mentioned that I might need to ask you to commit on my behalf as I don't have commit access as of now. http://reviews.llvm.org/D12807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

r247444 - [Static Analyzer] Fixed a typo in a diagnostic message.

Author: xazax Date: Fri Sep 11 13:41:50 2015 New Revision: 247444 URL: http://llvm.org/viewvc/llvm-project?rev=247444&view=rev Log: [Static Analyzer] Fixed a typo in a diagnostic message. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp Modified: cfe/trunk/lib/StaticAna

r247445 - Cleanup: Get rid of a bunch of unnecessary invocations of internString()

Author: adrian Date: Fri Sep 11 13:45:02 2015 New Revision: 247445 URL: http://llvm.org/viewvc/llvm-project?rev=247445&view=rev Log: Cleanup: Get rid of a bunch of unnecessary invocations of internString() in CGDebugInfo.cpp: MDString::get() copies its arguments. Modified: cfe/trunk/lib/CodeG

r247447 - Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC).

Author: adrian Date: Fri Sep 11 13:54:28 2015 New Revision: 247447 URL: http://llvm.org/viewvc/llvm-project?rev=247447&view=rev Log: Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC). Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebu

Re: r247432 - Module Debugging: Emit forward declarations for types that are defined in

> On Sep 11, 2015, at 11:21 AM, David Blaikie wrote: > > > > On Fri, Sep 11, 2015 at 10:23 AM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Fri Sep 11 12:23:08 2015 > New Revision: 247432 > > URL: http://llvm.org/viewvc/llvm-project?rev=

r247448 - Remove an unnecessary check. NFC

Author: adrian Date: Fri Sep 11 13:54:31 2015 New Revision: 247448 URL: http://llvm.org/viewvc/llvm-project?rev=247448&view=rev Log: Remove an unnecessary check. NFC Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/l

r247449 - Fix a typo and make this test stricter.

Author: adrian Date: Fri Sep 11 13:54:34 2015 New Revision: 247449 URL: http://llvm.org/viewvc/llvm-project?rev=247449&view=rev Log: Fix a typo and make this test stricter. Modified: cfe/trunk/test/Modules/ExtDebugInfo.m Modified: cfe/trunk/test/Modules/ExtDebugInfo.m URL: http://llvm.org/v

r247451 - Record function attribute "stackrealign" instead of using backend option

Author: ahatanak Date: Fri Sep 11 13:55:09 2015 New Revision: 247451 URL: http://llvm.org/viewvc/llvm-project?rev=247451&view=rev Log: Record function attribute "stackrealign" instead of using backend option -force-align-stack. Also, make changes to the driver so that -mno-stack-realign is no lon

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

This revision was automatically updated to reflect the committed changes. Closed by commit rL247451: Record function attribute "stackrealign" instead of using backend option (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D11815?vs=33456&id=34569#toc Repository: rL L

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

xazax.hun added a comment. In general I like this change, the node handling of the checkers are more readable and reflects the intent in a clearer way. I have some comments inline. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:244 @@ +243,3 @@ +

Re: r246877 - Increase accuracy of __builtin_object_size.

Hi George, After this commit we started to trap on the following case: #include typedef struct { int n; char key[1]; } obj_t; char *str = "hello"; int main() { obj_t* p = (obj_t*)malloc(strlen(str) + 1 + sizeof(int)); strcpy(p->key, str); free(p); return 0; } As far as I understan

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

jordan_rose added inline comments. Comment at: lib/StaticAnalyzer/Checkers/FixedAddressChecker.cpp:53 @@ -52,3 +52,3 @@ - if (ExplodedNode *N = C.addTransition()) { + if (ExplodedNode *N = C.generateNonFatalErrorNode()) { if (!BT) zaks.anna wrote: > Can t

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

Reduced it a bit: template void JSMethod(); class A { int printd(int); void printd(); }; void A::printd() { JSMethod(); } This test case will crash clang at the revision before this commit which means that something more mysterious/horrific is going on... On Fri, Sep 11, 2015 at 11:10 AM, Da

Re: r247432 - Module Debugging: Emit forward declarations for types that are defined in

On Fri, Sep 11, 2015 at 11:55 AM, Adrian Prantl wrote: > > On Sep 11, 2015, at 11:21 AM, David Blaikie wrote: > > > > On Fri, Sep 11, 2015 at 10:23 AM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: adrian >> Date: Fri Sep 11 12:23:08 2015 >> New Revision: 2474

Re: r247447 - Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC).

On Fri, Sep 11, 2015 at 11:54 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Fri Sep 11 13:54:28 2015 > New Revision: 247447 > > URL: http://llvm.org/viewvc/llvm-project?rev=247447&view=rev > Log: > Remove a redundant check from CGDebugInfo::shouldO

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rcraik updated the summary for this revision. rcraik updated this revision to Diff 34571. rcraik added a comment. switched to using getIntWidth instead of getTypeSize and updated the error and warning messages accordingly, as have the necessary test cases. The separate check for _Bool bitfields

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rcraik marked 3 inline comments as done. rcraik added a comment. http://reviews.llvm.org/D10018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r247462 - [Edit] Fix issue with tracking what macro argument inputs have been edited.

Author: akirtzidis Date: Fri Sep 11 15:09:11 2015 New Revision: 247462 URL: http://llvm.org/viewvc/llvm-project?rev=247462&view=rev Log: [Edit] Fix issue with tracking what macro argument inputs have been edited. This was not working correctly, leading to erroneously rejecting valid edits. Modif

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks great, please go ahead. Sorry it's taken so long to get this reviewed. http://reviews.llvm.org/D10018 ___ cfe-commits mailing list cfe-comm

r247463 - [analyzer] Add -analyzer-config option for function size the inliner considers as large

Author: dcoughlin Date: Fri Sep 11 15:14:05 2015 New Revision: 247463 URL: http://llvm.org/viewvc/llvm-project?rev=247463&view=rev Log: [analyzer] Add -analyzer-config option for function size the inliner considers as large Add an option (-analyzer-config min-blocks-for-inline-large=14) to contr

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rjmccall added a comment. In http://reviews.llvm.org/D12743#244375, @vsk wrote: > Ah, ok. We have some objective-c++ code which calls into a boost routine > which throws an exception. That results in an undefined reference to > ___objc_personality_v0, because the boost library we linked against

Re: [PATCH] D12406: [Analyzer] Add -analyzer-config option for function size the inliner considers as large

This revision was automatically updated to reflect the committed changes. Closed by commit rL247463: [analyzer] Add -analyzer-config option for function size the inliner… (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D12406?vs=34196&id=34574#toc Repository: rL LLV

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

On Fri, Sep 11, 2015 at 12:46 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Reduced it a bit: > template > void JSMethod(); > class A { > int printd(int); > void printd(); > }; > void A::printd() { JSMethod(); } > > This test case will crash clang at the revision b

r247464 - [MS ABI] Select an inheritance model in template arguments

Author: majnemer Date: Fri Sep 11 15:18:09 2015 New Revision: 247464 URL: http://llvm.org/viewvc/llvm-project?rev=247464&view=rev Log: [MS ABI] Select an inheritance model in template arguments We used to only select an inheritance model if the pointer to member was nullptr. Instead, select a mo

Re: r246877 - Increase accuracy of __builtin_object_size.

On Fri, Sep 11, 2015 at 12:15 PM, Mikhail Zolotukhin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi George, > > After this commit we started to trap on the following case: > > #include > typedef struct { > int n; > char key[1]; > } obj_t; > > char *str = "hello"; > > int main() { >

Re: r247464 - [MS ABI] Select an inheritance model in template arguments

On Fri, Sep 11, 2015 at 1:18 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: majnemer > Date: Fri Sep 11 15:18:09 2015 > New Revision: 247464 > > URL: http://llvm.org/viewvc/llvm-project?rev=247464&view=rev > Log: > [MS ABI] Select an inheritance model in template

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

On Fri, Sep 11, 2015 at 1:16 PM, Richard Smith wrote: > On Fri, Sep 11, 2015 at 12:46 PM, David Majnemer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Reduced it a bit: >> template >> void JSMethod(); >> class A { >> int printd(int); >> void printd(); >> }; >> void A::printd()

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis updated this revision to Diff 34578. eugenis added a comment. rebase, fix a merge conflict Repository: rL LLVM http://reviews.llvm.org/D12087 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeG

r247465 - Always_inline codegen rewrite.

Author: eugenis Date: Fri Sep 11 15:29:07 2015 New Revision: 247465 URL: http://llvm.org/viewvc/llvm-project?rev=247465&view=rev Log: Always_inline codegen rewrite. Current implementation may end up emitting an undefined reference for an "inline __attribute__((always_inline))" function by generat

Re: recordDecl() AST matcher

I don't think CXXRecordDecl is an anachronism, so much as an implementation detail; it makes sense to use a smaller class when in C mode, as we don't need most of the features and complexity that CXXRecordDecl brings with it. But... as a user of clang matchers, I don't think I'd want to care about

  1   2   >