On Tue, Sep 8, 2015 at 3:51 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> rsmith added inline comments.
>
>
> Comment at: lib/CodeGen/CGDebugInfo.cpp:3263-3264
> @@ +3262,4 @@
> + const NamespaceDecl *NSDecl = UD.getNominatedNamespace();
> + if (!NSDec
Prazek created this revision.
Prazek added reviewers: rsmith, nlewycky.
Prazek added a subscriber: cfe-commits.
Herald added a subscriber: sanjoy.
http://reviews.llvm.org/D12719
Files:
lib/Analysis/ScalarEvolution.cpp
test/Analysis/ScalarEvolution/avoid-assume-hang.ll
Index: test/Analysis/Sc
hiraditya added a comment.
Please review my patch. Thanks.
http://reviews.llvm.org/D9924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nlewycky added inline comments.
Comment at: lib/Analysis/ScalarEvolution.cpp:6980
@@ -6991,1 +6979,3 @@
+ // Check conditions due to any @llvm.assume intrinsics.
+ for (auto &AssumeVH : AC.assumptions()) {
What is it about this check which is a problem? Or put
On Tue, Sep 8, 2015 at 12:20 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Tue Sep 8 14:20:27 2015
> New Revision: 247049
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247049&view=rev
> Log:
> Module Debugging: Emit debug type information into
On Tue, Sep 8, 2015 at 1:41 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Tue Sep 8 15:41:52 2015
> New Revision: 247068
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247068&view=rev
> Log:
> Module Debugging: Emit debug type information into c
Prazek added inline comments.
Comment at: lib/Analysis/ScalarEvolution.cpp:6980
@@ -6991,1 +6979,3 @@
+ // Check conditions due to any @llvm.assume intrinsics.
+ for (auto &AssumeVH : AC.assumptions()) {
nlewycky wrote:
> What is it about this check which is a
nlewycky added inline comments.
Comment at: lib/Analysis/ScalarEvolution.cpp:6980
@@ -6991,1 +6979,3 @@
+ // Check conditions due to any @llvm.assume intrinsics.
+ for (auto &AssumeVH : AC.assumptions()) {
Prazek wrote:
> nlewycky wrote:
> > What is it about t
On 8 September 2015 at 20:27, Sanjoy Das
wrote:
> sanjoy added a comment.
>
> I don't think this is an infinite loop (Piotr, can you please verify
> this?), it is probably an O(n!) recursion where n == number of the
> assumptions.
>
> ScalarEvolution::isImpliedCond already guards for infinite loo
Prazek added a comment.
I checked it, it is of course not infinite. I am not sure about n! in case of
assumes. I having 10 or 20 assumes will not make it slow. @rsmith was helping
me with it, and he thinks that for assumes it is O(n^2), because results are
memorized.
So it this case, 1000 assu
Prazek added a comment.
I used "hanging out" in the meaning of being very slow, not sure if it is right
word for it.
http://reviews.llvm.org/D12719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
On Mon, Sep 07, 2015 at 02:44:23PM -0700, Saleem Abdulrasool wrote:
> > Right. Tried to explain a bit what's going on in the commit message,
> > with a reference to the original commit that removed the flag.
>
>
> Thanks. Would you like me to commit this on your behalf as well?
Yes please. Than
comex created this revision.
comex added a subscriber: cfe-commits.
Herald added subscribers: aemerson, klimek.
Add support for GCC's '__auto_type' extension.
As per the GCC manual: https://gcc.gnu.org/onlinedocs/gcc/Typeof.html
Implemented in GCC 4.9, __auto_type is similar to C++11 auto but wo
seaneveson updated this revision to Diff 34196.
seaneveson added a comment.
I changed the name to min-cfg-size-treat-functions-as-large, thanks for the
suggestion.
If the patch is acceptable can someone commit it for me?
http://reviews.llvm.org/D12406
Files:
include/clang/StaticAnalyzer/Cor
Author: rjmccall
Date: Tue Sep 8 03:21:11 2015
New Revision: 246986
URL: http://llvm.org/viewvc/llvm-project?rev=246986&view=rev
Log:
Move BlockByrefHelpers back to CodeGenModule.h to placate MSVC.
Modified:
cfe/trunk/lib/CodeGen/CGBlocks.h
cfe/trunk/lib/CodeGen/CodeGenModule.h
Modified
Author: rjmccall
Date: Tue Sep 8 03:57:00 2015
New Revision: 246988
URL: http://llvm.org/viewvc/llvm-project?rev=246988&view=rev
Log:
Remove unnecessary braces; this resolves against a
single-pointer overload instead of the ArrayRef one.
Modified:
cfe/trunk/lib/CodeGen/CGBuilder.h
Modified:
klimek accepted this revision.
klimek added a comment.
LG
http://reviews.llvm.org/D12675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246989: Avoid using rvalue references with trivially
copyable types. (authored by angelgarcia).
Changed prior to commit:
http://reviews.llvm.org/D12675?vs=34162&id=34201#toc
Repository:
rL LLVM
http
Author: angelgarcia
Date: Tue Sep 8 04:01:21 2015
New Revision: 246989
URL: http://llvm.org/viewvc/llvm-project?rev=246989&view=rev
Log:
Avoid using rvalue references with trivially copyable types.
Summary:
When the dereference operator returns a value that is trivially
copyable (like a pointer)
101 - 119 of 119 matches
Mail list logo
