r246375 - Update for several APIs in LLVM that now use StringRefs rather than

Author: chandlerc Date: Sun Aug 30 02:51:18 2015 New Revision: 246375 URL: http://llvm.org/viewvc/llvm-project?rev=246375&view=rev Log: Update for several APIs in LLVM that now use StringRefs rather than const char pointers. In turn, push this through Clang APIs as well, simplifying a number of bi

Re: r246375 - Update for several APIs in LLVM that now use StringRefs rather than

On 30 August 2015 at 08:51, Chandler Carruth via cfe-commits wrote: > Author: chandlerc > Date: Sun Aug 30 02:51:18 2015 > New Revision: 246375 > > URL: http://llvm.org/viewvc/llvm-project?rev=246375&view=rev > Log: > Update for several APIs in LLVM that now use StringRefs rather than > const char

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

klimek added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:2140-2153 @@ -2139,16 +2139,16 @@ /// \brief Matches when the selector has the specified number of arguments /// -/// matcher = objCMessageExpr(numSelectorArgs(1)); +/// matcher = objCMessageEx

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

piotrdz removed rL LLVM as the repository for this revision. piotrdz updated this revision to Diff 33527. piotrdz added a comment. I noticed a few things I should have done better: - use std::set instead of std::unordered_set (it doesn't seem to be used elsewhere) - move checking set of reported

r246384 - [OpenMP] Make the filetered clause iterator a real iterator and type safe.

Author: d0k Date: Sun Aug 30 10:12:28 2015 New Revision: 246384 URL: http://llvm.org/viewvc/llvm-project?rev=246384&view=rev Log: [OpenMP] Make the filetered clause iterator a real iterator and type safe. This replaces the filtered generic iterator with a type-specfic one based on dyn_cast instea

[PATCH] D12473: [clang-tidy] Add old style function check

piotrdz created this revision. piotrdz added a subscriber: cfe-commits. This is another patch from my tool colobot-lint. This adds a new check misc-old-style-function, which checks for instances of functions written in legacy C style. As before, I hope I did everything according to LLVM style,

r246385 - Make test resistant to false matches of numbered (unnamed) labels inside other numbers.

Author: yrnkrn Date: Sun Aug 30 10:24:46 2015 New Revision: 246385 URL: http://llvm.org/viewvc/llvm-project?rev=246385&view=rev Log: Make test resistant to false matches of numbered (unnamed) labels inside other numbers. In release builds labels are numbers. Matching just the number may result i

[PATCH] D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr

ismailp created this revision. ismailp added reviewers: zaks.anna, dcoughlin, krememek. ismailp added a subscriber: cfe-commits. `TypeTraitExpr`s are not supported by the ExprEngine today. Analyzer creates a sink, and aborts the block. Therefore, certain bugs that involve type traits intrinsics ca

r246391 - Fix test for Release builds, the label form is :14, not 14.

Author: yrnkrn Date: Sun Aug 30 12:46:43 2015 New Revision: 246391 URL: http://llvm.org/viewvc/llvm-project?rev=246391&view=rev Log: Fix test for Release builds, the label form is :14, not 14. Modified: cfe/trunk/test/CodeGen/sanitize-trap.c Modified: cfe/trunk/test/CodeGen/sanitize-trap.c

[libcxx] r246392 - Remove task to get C++03 tests passing from TODO.txt

Author: ericwf Date: Sun Aug 30 12:58:50 2015 New Revision: 246392 URL: http://llvm.org/viewvc/llvm-project?rev=246392&view=rev Log: Remove task to get C++03 tests passing from TODO.txt Modified: libcxx/trunk/TODO.TXT libcxx/trunk/test/std/re/re.alg/re.alg.search/grep.pass.cpp Modified:

r246393 - [OpenCL] Improve diagnostics detecting implicit vector conversion.

Author: bader Date: Sun Aug 30 13:06:39 2015 New Revision: 246393 URL: http://llvm.org/viewvc/llvm-project?rev=246393&view=rev Log: [OpenCL] Improve diagnostics detecting implicit vector conversion. Reviewers: pekka.jaaskelainen Differential Revision: http://reviews.llvm.org/D12470 Modified:

Re: [PATCH] D12378: [OpenCL] Improve diagnostics detecting implicit vector conversion.

bader closed this revision. bader added a comment. Thanks! Committed at rev. 246393. http://reviews.llvm.org/D12378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF added a comment. In http://reviews.llvm.org/D11963#235148, @jroelofs wrote: > In http://reviews.llvm.org/D11963#234789, @EricWF wrote: > > > Copy the headers to the build directory during every build instead of just > > during CMake configuration. > > > Sounds like this would cause every

Re: [PATCH] D12473: [clang-tidy] Add old style function check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think extern "C" functions should be kept with (void). I may be mistaken, but looks like code doesn't check for in C++ mode. http://reviews.llvm.org/D12473 ___ cfe

Re: [PATCH] D12473: [clang-tidy] Add old style function check

Eugene.Zelenko added a comment. Just for reference: - Previous attempt: http://reviews.llvm.org/D7639. - Bugzilla request . http://reviews.llvm.org/D12473 ___ cfe-commits mailing list cfe-commits@lists.

Re: [PATCH] D11976: [libclang] Return deduced type for auto type, not the one written in the source.

klimek added a subscriber: klimek. klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. This revision is now accepted and ready to land. As this doesn't break any old tests, and fixes a significant number of issues, LG. Do you need me to submit? http://reviews

Re: [PATCH] D12473: [clang-tidy] Add old style function check

piotrdz added a comment. @Eugene: I don't understand, what does declaring function with "void" argument have in common with this review? I only check here variable declarations inside functions. Maybe you meant my other review for inconsistent declaration parameter names? If so, this is how it

Re: [PATCH] D12473: [clang-tidy] Add old style function check

On Sun, Aug 30, 2015 at 4:39 PM, Piotr Dziwinski via cfe-commits wrote: > piotrdz added a comment. > > @Eugene: I don't understand, what does declaring function with "void" > argument have in common with this review? I only check here variable > declarations inside functions. > > Maybe you meant

Re: [PATCH] D12473: [clang-tidy] Add old style function check

@Aaron: Yes, I'm aware of that. I wanted to show that my check does not take this into account. In C++ this code is equivalent, so I think nothing should be reported, unless we really want to get rid of that void, but I suppose this other check does it already. And when it comes to C, in wel

Re: [PATCH] D12473: [clang-tidy] Add old style function check

On Sun, Aug 30, 2015 at 4:53 PM, Piotr Dziwinski wrote: > @Aaron: Yes, I'm aware of that. I wanted to show that my check does not take > this into account. > > In C++ this code is equivalent, so I think nothing should be reported, > unless we really want to get rid of that void, but I suppose this

[libcxx] r246399 - Suppress clang warnings in some tests

Author: ericwf Date: Sun Aug 30 17:04:20 2015 New Revision: 246399 URL: http://llvm.org/viewvc/llvm-project?rev=246399&view=rev Log: Suppress clang warnings in some tests Modified: libcxx/trunk/test/libcxx/double_include.sh.cpp libcxx/trunk/test/libcxx/test/config.py libcxx/trunk/tes

Re: [PATCH] D12473: [clang-tidy] Add old style function check

gcc has -Wstrict-prototypes which will catch this, but clang doesn't implement it. however, both gcc and clang have -Wmissing-prototypes which should catch these if users enable it. On Sun, Aug 30, 2015 at 5:32 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Sun, Aug

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

alexfh added a comment. Thanks for contributing the new check! This check seems pretty similar to the check implemented in clang-tidy/readability/NamedParameterCheck.h/.cpp. Having both doesn't make much sense, so one of them will have to die (probably, the other one). Nothing should be done

Re: [PATCH] D8178: [libcxx] Fix PR22806 - Tuple incorrectly selects copy/move constructor when storing nested tuple-like types.

EricWF added a comment. I think this patch is actually pretty close to correct but thinking about tuple hurts my brain. @mclow.lists can you start reviewing this when you have time. http://reviews.llvm.org/D8178 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D12473: [clang-tidy] Add old style function check

Eugene.Zelenko added a comment. Sorry, I was mislead by check name. http://reviews.llvm.org/D12473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r246408 - Move __lazy_* metafunctions to type traits and add tests

Author: ericwf Date: Sun Aug 30 22:50:31 2015 New Revision: 246408 URL: http://llvm.org/viewvc/llvm-project?rev=246408&view=rev Log: Move __lazy_* metafunctions to type traits and add tests Added: libcxx/trunk/test/libcxx/type_traits/lazy_metafunctions.pass.cpp Modified: libcxx/trunk/incl