alexfh added a comment.
A few more comments.
Comment at: test/clang-tidy/move-const-arg.cpp:1
@@ +1,2 @@
+// RUN: $(dirname %s)/check_clang_tidy.sh %s move-const-arg %t
+// REQUIRES: shell
Please use check_clang_tidy.py instead:
// RUN: %python %S/check_clan
The testcase from r245459 was not reverted and still in SVN.
2015-08-21 2:05 GMT+03:00 Martell Malone :
> I feel very silly now.
> After testing the testcase again on svn it still works.
> It appears the OP was looking for this patch to go onto the 3.6 branch and
> was applying my patch to that.
Author: yrnkrn
Date: Fri Aug 21 03:26:31 2015
New Revision: 245679
URL: http://llvm.org/viewvc/llvm-project?rev=245679&view=rev
Log:
Expand mingw-long-double.c to test for long double alignment.
Added:
cfe/trunk/test/CodeGen/mingw-long-double.c
Removed:
cfe/trunk/test/CodeGen/mingw-long-
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2887
@@ +2886,3 @@
+llvm::Value *
+CGOpenMPRuntime::emitTargetOutlinedFunction(CodeGenFunction &CGF,
+const OMPExecutableDirective &D,
I don't th
ABataev added a comment.
Another one thing I forget to mention. Current implementation of
CGOpenMPRuntime is libomp-specific. You're trying to add functionality that is
libtarget-specific. Maybe it is a good idea to separate support for libomp and
libtarget runtime libraries?
http://reviews.l
Author: yrnkrn
Date: Fri Aug 21 04:27:24 2015
New Revision: 245683
URL: http://llvm.org/viewvc/llvm-project?rev=245683&view=rev
Log:
Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.
Modified:
clang-tools-extra/trunk/clang-tidy/tool/clang-tidy-diff.py
Modified: clang-tool
Author: chapuni
Date: Fri Aug 21 04:37:53 2015
New Revision: 245684
URL: http://llvm.org/viewvc/llvm-project?rev=245684&view=rev
Log:
Untabify.
Modified:
cfe/trunk/CMakeLists.txt
Modified: cfe/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=245684&
Author: chapuni
Date: Fri Aug 21 04:38:46 2015
New Revision: 245685
URL: http://llvm.org/viewvc/llvm-project?rev=245685&view=rev
Log:
[CMake][Standalone] Detect Python. Python is used for Lit testing.
Modified:
cfe/trunk/CMakeLists.txt
Modified: cfe/trunk/CMakeLists.txt
URL:
http://llvm.org
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: cfe-commits, klimek.
angelgarcia changed the visibility of this Differential Revision from "Public
(No Login Required)" to "All Users".
Migrate UseAuto from clang-modernize to clang-tidy.
http
On Fri, Aug 21, 2015 at 11:27 AM, Yaron Keren via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: yrnkrn
> Date: Fri Aug 21 04:27:24 2015
> New Revision: 245683
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245683&view=rev
> Log:
> Tweak clang-tidy-diff.py to recognize "filename" in
Author: yrnkrn
Date: Fri Aug 21 05:46:46 2015
New Revision: 245688
URL: http://llvm.org/viewvc/llvm-project?rev=245688&view=rev
Log:
Make test EOL tolerant by moving the symbol ot the first line
before any EOL changes the byte offset count and enable it on Windows.
Modified:
clang-tools-extr
Whenever is any special character in the filename, such as space or
backslash (Windows), some examples:
On Windows:
--- ".\\a.cpp" 2015-08-21 00:22:57.885370200 +0300
+++ b.cpp 2015-08-21 01:05:28.726269900 +0300
--- ./a.cpp 2015-08-21 00:22:57.885370200 +0300
+++ b.cpp 2015-08-2
Author: abataev
Date: Fri Aug 21 06:14:16 2015
New Revision: 245692
URL: http://llvm.org/viewvc/llvm-project?rev=245692&view=rev
Log:
[OPENMP 4.1] Initial support for 'simdlen' clause.
Add parsing/sema analysis for 'simdlen' clause in simd directives. Also add
check that if both 'safelen' and 'si
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:45
@@ +44,3 @@
+
+ // The following test is based on DeclPrinter::VisitVarDecl() o find if an
+ // initializer is implicit o not.
s/o find/to find/?
s/o not/or not/?
==
Author: abataev
Date: Fri Aug 21 06:32:42 2015
New Revision: 245693
URL: http://llvm.org/viewvc/llvm-project?rev=245693&view=rev
Log:
[OPENMP 4.1] Add ast-print tests for 'val', 'uval' and 'ref' modifiers.
Modified:
cfe/trunk/test/OpenMP/simd_ast_print.cpp
Modified: cfe/trunk/test/OpenMP/sim
Author: djasper
Date: Fri Aug 21 06:44:57 2015
New Revision: 245694
URL: http://llvm.org/viewvc/llvm-project?rev=245694&view=rev
Log:
clang-format: Be more conservative about specially indenting blocks in C++.
This is a bit of a step back of what we did in r222531, as there are
some corner cases
angelgarcia updated this revision to Diff 32815.
angelgarcia marked 10 inline comments as done.
angelgarcia added a comment.
Fix comments.
I did not include the 'hasDeclaration()" call in the 'standardIterator'
function because its return type is
internal::PolymorphicMatcherWithParam1< internal:
angelgarcia updated this revision to Diff 32816.
angelgarcia added a comment.
Apply clang-format to the code.
http://reviews.llvm.org/D12231
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseAutoCheck.cpp
clang-tidy/modernize
Author: abataev
Date: Fri Aug 21 07:19:04 2015
New Revision: 245697
URL: http://llvm.org/viewvc/llvm-project?rev=245697&view=rev
Log:
[OPENMP 4.1] Add codegen for 'simdlen' clause.
Add emission of metadata for simd loops in presence of 'simdlen' clause.
If 'simdlen' clause is provided without 'saf
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:45
@@ +44,3 @@
+
+ // The following test is based on DeclPrinter::VisitVarDecl() or find if an
+ // initializer is implicit or not.
I can't parse it with 'or'. Did you mean something
dsanders created this revision.
dsanders added reviewers: vkalintiris, atanasyan.
dsanders added a subscriber: cfe-commits.
dsanders added a dependency: D12193: [mips][p5600] Added P5600 processor and
initial scheduler..
Depends on D12193
http://reviews.llvm.org/D12234
Files:
lib/Basic/Target
angelgarcia updated this revision to Diff 32818.
angelgarcia added a comment.
Fix comments: change warning message and minor fixes.
http://reviews.llvm.org/D12231
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseAutoCheck.cpp
Author: alexfh
Date: Fri Aug 21 07:41:14 2015
New Revision: 245699
URL: http://llvm.org/viewvc/llvm-project?rev=245699&view=rev
Log:
[clang-tidy] Remove check_clang_tidy.sh that has been replaced with
check_clang_tidy.py.
Removed:
clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.sh
Author: d0k
Date: Fri Aug 21 07:51:01 2015
New Revision: 245700
URL: http://llvm.org/viewvc/llvm-project?rev=245700&view=rev
Log:
[RecordLayoutBuilder] Remove duplicated diagnostic argument. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/AST/RecordLayout
Author: d0k
Date: Fri Aug 21 07:29:47 2015
New Revision: 245698
URL: http://llvm.org/viewvc/llvm-project?rev=245698&view=rev
Log:
Remove unused diagnostic.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL:
http
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D12234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: angelgarcia
Date: Fri Aug 21 08:55:16 2015
New Revision: 245701
URL: http://llvm.org/viewvc/llvm-project?rev=245701&view=rev
Log:
Test commit!
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp
Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrC
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D12231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: angelgarcia
Date: Fri Aug 21 10:08:51 2015
New Revision: 245703
URL: http://llvm.org/viewvc/llvm-project?rev=245703&view=rev
Log:
[clang-tidy] Migrate UseAuto from clang-modernize to clang-tidy.
http://reviews.llvm.org/D12231
Added:
clang-tools-extra/trunk/clang-tidy/modernize/UseAut
angelgarcia closed this revision.
angelgarcia added a comment.
Committed revision 245703.
http://reviews.llvm.org/D12231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JosephTremoulet updated this revision to Diff 32831.
JosephTremoulet added a comment.
rebase
http://reviews.llvm.org/D12109
Files:
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGException.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
Index: lib/CodeGen/MicrosoftCXXABI.cpp
keith.walker.arm created this revision.
keith.walker.arm added reviewers: olista01, rengolin, cfe-commits.
Herald added subscribers: rengolin, aemerson.
The ACLE (ARM C Language Extensions) 2.0 defines that the predefined macro
__ARM_FP16_ARGS should be defined if __fp16 can be used as an argument
sbenza added inline comments.
Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:20
@@ +19,3 @@
+ const auto* CallMove = result.Nodes.getNodeAs("call-move");
+ if (CallMove->getNumArgs() != 1) return;
+ const Expr* Arg = CallMove->getArg(0);
You can move
blackjack added a subscriber: blackjack.
blackjack added a comment.
With this patch applied, class variables type is printed as :
http://i.imgur.com/CXHnjwJ.png
http://reviews.llvm.org/D11976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: echristo
Date: Fri Aug 21 11:24:01 2015
New Revision: 245706
URL: http://llvm.org/viewvc/llvm-project?rev=245706&view=rev
Log:
Fix typo - symetric -> symmetric.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
Modified: cfe/trunk/lib/Sema/SemaOverload.cpp
URL:
http://llvm.org/viewvc/ll
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This doesn't seem like a fundamental property of a type, to me. If I understand
properly, this has more to do with specific instances of memory access. By
making it part
jmgao updated this revision to Diff 32833.
jmgao added a comment.
Remove more `\brief`s
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/Fronten
jmgao marked an inline comment as done.
Comment at: lib/CodeGen/CGExpr.cpp:2303
@@ -2302,4 +2302,3 @@
- if (TrapCond)
-EmitTrapCheck(TrapCond);
+ if (TrapCond) EmitSanitizeTrapCheck(TrapCond);
if (!FatalCond && !RecoverableCond)
Yes
http://reviews.llv
jmgao marked 4 inline comments as done.
jmgao added a comment.
http://reviews.llvm.org/D12181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D12109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyknight created this revision.
jyknight added a reviewer: majnemer.
jyknight added a subscriber: cfe-commits.
This is important in the case that the LLVM-inferred llvm-struct
alignment is not the same as the clang-known C-struct alignment.
http://reviews.llvm.org/D12243
Files:
lib/CodeGen/CGC
labrinea created this revision.
labrinea added subscribers: cfe-commits, llvm-commits.
Herald added subscribers: rengolin, aemerson.
Implementation and testing of ACLE 2.0 macros, for details see the above
document:
[[
http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053c/IHI0053C_acle_2_0.p
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D12243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
ab added a subscriber: ab.
ab accepted this revision.
ab added a reviewer: ab.
ab added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D12240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mzolotukhin added a comment.
Hi all,
Thanks for the feedback, please find my answers below:
> What does it mean to have the attribute applied to non-pointer types like int
> __attribute__((nontemporal)) i; ? The ACLE doesn't say but making it
> erroneous might make sense. Perhaps it would be g
sfantao updated this revision to Diff 32843.
sfantao added a comment.
Address reviewer concerns.
http://reviews.llvm.org/D11361
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_codegen.cpp
Index: test/OpenMP/target_cod
sfantao added a comment.
In http://reviews.llvm.org/D11361#229744, @ABataev wrote:
> Another one thing I forget to mention. Current implementation of
> CGOpenMPRuntime is libomp-specific. You're trying to add functionality that
> is libtarget-specific. Maybe it is a good idea to separate suppor
On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool
wrote:
> On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg wrote:
>>
>> +Saleem and Renato; maybe you can take a look?
>
>
> Thanks for pointing this out!
>
> The patch is correct and pretty safe to apply for 3.7 I think since its a
> simple bug fi
aaron.ballman added a comment.
In http://reviews.llvm.org/D12221#230187, @mzolotukhin wrote:
> **Aaron**,
> As far as I understand, type attributes doesn't result in such complications
> (as opposed to type qualifiers, e.g. `__restrict__`). That is, it doesn't
> change the canonical type, it o
yiranwang created this revision.
yiranwang added a subscriber: cfe-commits.
In libc++, there are some usage of aligned_storage which uses "sizeof" bytes of
raw data. This is problematic a bit, as the trailing padding area will be
counted by "sizeof", and it leads to out of bound access. For exam
Author: jyknight
Date: Fri Aug 21 13:19:06 2015
New Revision: 245719
URL: http://llvm.org/viewvc/llvm-project?rev=245719&view=rev
Log:
Properly provide alignment of 'byval' arguments down to llvm.
This is important in the case that the LLVM-inferred llvm-struct
alignment is not the same as the cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245719: Properly provide alignment of 'byval' arguments down
to llvm. (authored by jyknight).
Changed prior to commit:
http://reviews.llvm.org/D12243?vs=32839&id=32847#toc
Repository:
rL LLVM
http:/
danalbert added reviewers: mclow.lists, EricWF.
danalbert added a comment.
FYI this was found because it can cause issues when used with GCC.
http://reviews.llvm.org/D12247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: prazek
Date: Fri Aug 21 13:28:00 2015
New Revision: 245721
URL: http://llvm.org/viewvc/llvm-project?rev=245721&view=rev
Log:
Generating assumption loads of vptr after ctor call (fixed)
Generating call assume(icmp %vtable, %global_vtable) after constructor
call for devirtualization purpose
mzolotukhin added a comment.
Oh, I see. So, you meant something like this?
void foo(std::vector av, float * b, int
N) {
for (auto a: av) // << `a` doesn't have nontemporal attribute here
for (int i = 0; i < N; i++)
a[i] = b[i]+1;
}
One can easily work around it by usi
xazax.hun updated this revision to Diff 32854.
xazax.hun added a comment.
Only send implicit dereference events, when the null pointer was bound to a
reference.
http://reviews.llvm.org/D11433
Files:
lib/StaticAnalyzer/Checkers/NonNullParamChecker.cpp
Index: lib/StaticAnalyzer/Checkers/NonNu
rsmith added a comment.
Thanks for the rework, the general approach here seems reasonable.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7680
@@ +7679,3 @@
+def err_omp_section_length_undefined : Error<
+ "section length is unspecified, but subscripted value is not an
Author: prazek
Date: Fri Aug 21 14:49:41 2015
New Revision: 245727
URL: http://llvm.org/viewvc/llvm-project?rev=245727&view=rev
Log:
Revert "Generating assumption loads of vptr after ctor call (fixed)"
Reverting because of 245721
This reverts commit 552658e2b60543c928030b09cc9b5dfcb40c3f28.
Remo
aaron.ballman added a comment.
In http://reviews.llvm.org/D12221#230263, @mzolotukhin wrote:
> Oh, I see. So, you meant something like this?
>
> void foo(std::vector av, float * b,
> int N) {
> for (auto a: av) // << `a` doesn't have nontemporal attribute here
> for (int i = 0;
On Fri, Aug 21, 2015 at 12:14 PM, Michael Zolotukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> mzolotukhin added a comment.
>
> Oh, I see. So, you meant something like this?
>
> void foo(std::vector av, float *
> b, int N) {
> for (auto a: av) // << `a` doesn't have nontemp
Author: alexdenisov
Date: Fri Aug 21 15:28:16 2015
New Revision: 245731
URL: http://llvm.org/viewvc/llvm-project?rev=245731&view=rev
Log:
[SemaObjC] Remove unused code from test.
Patch by modocache (Brian Gesiak).
Modified:
cfe/trunk/test/SemaObjC/access-property-getter.m
Modified: cfe/trun
zaks.anna added a comment.
Please, commit this after committing the nullability checker so that this could
have tests. Two tests need to be added:
1. the reference case
2. the attribute nonnull case
Also, I'd suggest adding a field to ImplicitNullDerefEvent instead of creating
a new event.
h
AlexDenisov accepted this revision.
AlexDenisov added a reviewer: AlexDenisov.
AlexDenisov added a comment.
This revision is now accepted and ready to land.
Committed, r245731.
http://reviews.llvm.org/D12047
___
cfe-commits mailing list
cfe-commits@
dcoughlin updated this revision to Diff 32864.
dcoughlin added a comment.
Update comments to correct nil/non-nil mistakes.
http://reviews.llvm.org/D12123
Files:
include/clang/StaticAnalyzer/Core/Checker.h
include/clang/StaticAnalyzer/Core/CheckerManager.h
lib/StaticAnalyzer/Checkers/CallA
dcoughlin marked an inline comment as done.
dcoughlin added a comment.
http://reviews.llvm.org/D12123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Aug 21, 2015 at 10:35 AM, Michael Zolotukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Yes, I've considered a builitin as an alternative. In fact, I started with
> it as it was easier to implement, but then decided to switch to type
> attribute due to the following reasons:
>
silvas added inline comments.
Comment at: test/Modules/auto-module-import.m:89
@@ +88,3 @@
+ expected-error {{import of module 'NoUmbrella.A'
appears within function 'includeNotAtTopLevel'}} \
+ expected-note {{consider ma
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun updated this revision to Diff 32869.
xazax.hun added a comment.
- Updated to the latest trunk.
- Relaxed an assert in ExprEngine which turned out to be unsound.
- The individual checks can be turned on or off.
- Added some framework specific heuristic to reduce the number of false
posit
ismailp created this revision.
ismailp added reviewers: krememek, zaks.anna.
ismailp added a subscriber: cfe-commits.
`StoreManager::getLValueFieldOrIvar` should return loc as
base + field-offset, instead of just base.
http://reviews.llvm.org/D12251
Files:
lib/StaticAnalyzer/Core/Store.cpp
t
nmusgrave updated this revision to Diff 32873.
nmusgrave marked 2 inline comments as done.
nmusgrave added a comment.
- Poisoning on field-by-field basis, with collective poisoning of trivial
members when possible.
- Cleaned up implementation of calculating region to poison in dtor.
http://revi
eugenis added inline comments.
Comment at: lib/CodeGen/CGCXX.cpp:41
@@ +40,3 @@
+ if (getCodeGenOpts().SanitizeMemoryUseAfterDtor && Layout.getFieldCount() > 0
+ && HasTrivialDestructorBody(Context, D->getParent(), D->getParent())) {
+return true;
I'
Hi,
I’ve been working on the vectorization diagnostics a little more. The first
patch makes sure the analysis diagnostics are printed unless a disabling hint
is provided. And the two pairs of LLVM and Clang patches make the diagnostic
messages easier to understand and extend the vectorize(enabl
Author: ab
Date: Fri Aug 21 18:24:18 2015
New Revision: 245761
URL: http://llvm.org/viewvc/llvm-project?rev=245761&view=rev
Log:
[ARM NEON] Factor out FP-prototype checking. NFC.
Modified:
cfe/trunk/utils/TableGen/NeonEmitter.cpp
Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp
URL:
http:
nmusgrave added inline comments.
Comment at: lib/CodeGen/CGCXX.cpp:41
@@ +40,3 @@
+ if (getCodeGenOpts().SanitizeMemoryUseAfterDtor && Layout.getFieldCount() > 0
+ && HasTrivialDestructorBody(Context, D->getParent(), D->getParent())) {
+return true;
Author: ab
Date: Fri Aug 21 18:34:20 2015
New Revision: 245763
URL: http://llvm.org/viewvc/llvm-project?rev=245763&view=rev
Log:
[ARM NEON] Use the common naming scheme for vcvt f16 builtins. NFC.
We had "vcvt_f16" and "VCVT_HIGH_F16": for other FP types, this naming
is used for intrinsics with i
nmusgrave added inline comments.
Comment at: lib/CodeGen/CGCXX.cpp:41
@@ +40,3 @@
+ if (getCodeGenOpts().SanitizeMemoryUseAfterDtor && Layout.getFieldCount() > 0
+ && HasTrivialDestructorBody(Context, D->getParent(), D->getParent())) {
+return true;
mzolotukhin added a comment.
Thanks for the feedback everyone!
I think at this point I'll try to return to builtins then. In my original patch
I didn't have type overloading, so I'll need some time to add this. We can
return back to type attributes later if we'd like to.
And do I understand it
On Fri, Aug 21, 2015 at 4:59 PM, Michael Zolotukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> mzolotukhin added a comment.
>
> Thanks for the feedback everyone!
> I think at this point I'll try to return to builtins then. In my original
> patch I didn't have type overloading, so I'll
eugenis added inline comments.
Comment at: lib/CodeGen/CGClass.cpp:1578
@@ +1577,3 @@
+if (CGF.CGM.FieldHasTrivialDestructorBody(Context, Field) ||
+Field->getType()->isPointerType()) {
+ // Start sanitizing at this field
Why do you ne
nmusgrave added inline comments.
Comment at: lib/CodeGen/CGClass.cpp:1578
@@ +1577,3 @@
+if (CGF.CGM.FieldHasTrivialDestructorBody(Context, Field) ||
+Field->getType()->isPointerType()) {
+ // Start sanitizing at this field
eugenis wro
Author: rjmccall
Date: Fri Aug 21 19:35:27 2015
New Revision: 245771
URL: http://llvm.org/viewvc/llvm-project?rev=245771&view=rev
Log:
When building a pseudo-object assignment, and the RHS is
a contextually-typed expression that semantic analysis will
probably need to invasively rewrite, don't inc
zaks.anna added a comment.
Partial review...
Comment at: lib/StaticAnalyzer/Checkers/Checkers.td:137
@@ +136,3 @@
+def NullPassedToNonnullChecker : Checker<"NullPassedToNonnull">,
+ HelpText<"Warns when a null pointer is passed to a nonnull pointer.">,
+ DescFile<"NullabilityC
Author: ab
Date: Fri Aug 21 20:30:13 2015
New Revision: 245778
URL: http://llvm.org/viewvc/llvm-project?rev=245778&view=rev
Log:
[ARM NEON] Remove special-case for f16 vcvt handling. NFCI.
We can use the 'H' typespec modifier to use 128-bit vectors directly
in the only two users of this special-c
On Fri, Aug 21, 2015 at 11:02 AM, Hans Wennborg wrote:
> On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool
> wrote:
> > On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg
> wrote:
> >>
> >> +Saleem and Renato; maybe you can take a look?
> >
> >
> > Thanks for pointing this out!
> >
> > The patch
Author: rsmith
Date: Fri Aug 21 20:47:18 2015
New Revision: 245779
URL: http://llvm.org/viewvc/llvm-project?rev=245779&view=rev
Log:
[modules] Rearrange how redeclaration chains are loaded, to remove a walk over
all modules and reduce the number of declarations we load when loading a
redeclaration
Author: rsmith
Date: Fri Aug 21 21:09:38 2015
New Revision: 245780
URL: http://llvm.org/viewvc/llvm-project?rev=245780&view=rev
Log:
[modules] Remove some dead code after r245779.
Modified:
cfe/trunk/include/clang/Serialization/ASTReader.h
cfe/trunk/lib/Serialization/ASTReader.cpp
cfe
sfantao created this revision.
sfantao added reviewers: ABataev, rjmccall, hfinkel.
sfantao added a subscriber: cfe-commits.
All global variables that are not enclosed in a declare target region must be
captured in the target region as local variables do. Currently, there is no
support for decla
krememek added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:778
@@ -780,3 +777,3 @@
-UbigraphViz::UbigraphViz(std::unique_ptr Out, StringRef Filename)
-: Out(std::move(Out)), Filename(Filename), Cntr(0) {
+UbigraphViz::UbigraphViz(std::unique
krememek added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749
@@ -748,3 @@
-
- assert (Src != Dst && "Self-edges are not allowed.");
-
Did you look at the test case that causes this assertion to fail? I think it
would be good
Author: jingyue
Date: Sat Aug 22 00:49:28 2015
New Revision: 245786
URL: http://llvm.org/viewvc/llvm-project?rev=245786&view=rev
Log:
[CUDA] Change initializer for CUDA device code based on CUDA documentation.
Summary:
According to CUDA documentation, global variables declared with __device__,
__
91 matches
Mail list logo
