jmgao marked 8 inline comments as done.
Comment at: tools/clang/lib/CodeGen/CGExpr.cpp:2388
@@ +2387,3 @@
+ }
+ return EmitTrapCheck(Checked);
+}
samsonov wrote:
> This is confusing. So, you have the following behavior whenever you need to
> emit a check for `-
OK, so here's the problem:
The right way to fix this seems to be to delete the assignments to
LongDouble* from the MinGWX86_32TargetInfo constructor; the
X86_32TargetInfo and X86TargetInfo base classes already set them to the
right values. Likewise we can delete the assignments to LongDouble* from
Author: yrnkrn
Date: Thu Aug 20 16:51:46 2015
New Revision: 245620
URL: http://llvm.org/viewvc/llvm-project?rev=245620&view=rev
Log:
Revert the 64bit part of r245084; long double values were not changed by
it as they are already set correctly by X86_64TargetInfo and X86TargetInfo.
Modified:
Author: ayartsev
Date: Thu Aug 20 16:52:39 2015
New Revision: 245621
URL: http://llvm.org/viewvc/llvm-project?rev=245621&view=rev
Log:
[analyzer] Fix for PR24112 (scan-build doesn't work with --use-analyzer="path
to clang++.exe").
Don't derive the path_to_clang++ from the path_to_clang if the pa
The cumulative effect of all the patches so far has been to revert this
change from trunk. Hans, can you revert it on the branch too?
Thanks.
On Wed, Aug 19, 2015 at 1:51 PM, Martell Malone
wrote:
> Thanks for the spot yaron.
> I had only tested x64 at the time as that's what the original bug r
jmgao updated this revision to Diff 32755.
jmgao marked 2 inline comments as done.
jmgao added a comment.
Address comments
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/Code
Hans, it looked like you might have wanted PR24483 fixed for 3.7. If so,
this patch is safe for branch.
On Thu, Aug 20, 2015 at 1:45 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Aug 20 15:45:25 2015
> New Revision: 245609
>
> URL: http://llvm
jmgao updated this revision to Diff 32756.
jmgao added a comment.
Improve comment
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/Frontend/Comp
Can't we just use the --driver-mode flag instead of trying to mangle the
executable name?
Peter
On Thu, Aug 20, 2015 at 09:52:39PM -, Anton Yartsev via cfe-commits wrote:
> Author: ayartsev
> Date: Thu Aug 20 16:52:39 2015
> New Revision: 245621
>
> URL: http://llvm.org/viewvc/llvm-project?r
I've reverted r245456 in r245623.
Thanks,
Hans
On Thu, Aug 20, 2015 at 2:56 PM, Richard Smith wrote:
> The cumulative effect of all the patches so far has been to revert this
> change from trunk. Hans, can you revert it on the branch too?
>
> Thanks.
>
> On Wed, Aug 19, 2015 at 1:51 PM, Martell
Hi, I've just done this exactly this in r245618 (32 bit) and r245620 (64
bits).
mingw i686 long double values were correct before r245084 and wrong after
it.
mingw x86_64 long double values were not modified at all by r245084 for the
reason you stated, so I agree and do not see how this non-chang
samsonov added a comment.
Overall, this looks reasonable to me, but I'd like Richard to confirm he's fine
with this change as well.
Comment at: docs/UsersManual.rst:1121
@@ +1120,3 @@
+ Instruct code generator to emit a function call to the specified
+ function name instead
It looks like the answer is no, paths to clang and clang++ executables are used
to initialize CLANG and CLANG_CXX environment variables.
Can't we just use the --driver-mode flag instead of trying to mangle the
executable name?
Peter
On Thu, Aug 20, 2015 at 09:52:39PM -, Anton Yartsev via
filcab added a subscriber: filcab.
filcab added a comment.
Looks good.
Comment at: lib/ubsan/ubsan_flags.inc:26
@@ +25,2 @@
+UBSAN_FLAG(bool, report_error_type, false,
+"Print specific error type instead of 'undefined-behavior' in
summary.")
Do we care
>
> There is no testcase for PR24398 nor the OP reporting the problem was
> actually solved. Martell?
I'm just re-looking through it now.
X86TargetInfo sets LongDoubleFormat = &llvm::APFloat::x87DoubleExtended;
X86_64TargetInfo then sets LongDoubleWidth = LongDoubleAlign = 128;
X86_32TargetInfo t
rsmith added a comment.
In http://reviews.llvm.org/D12181#229358, @rsmith wrote:
> Can you please give a brief description of the motivation for this change?
> When would it be appropriate to use this rather than `-ftrap-function`?
I'd still like an answer to this. It's not clear to me what th
samsonov added inline comments.
Comment at: lib/ubsan/ubsan_flags.inc:26
@@ +25,2 @@
+UBSAN_FLAG(bool, report_error_type, false,
+"Print specific error type instead of 'undefined-behavior' in
summary.")
filcab wrote:
> Do we care that much about keeping t
Author: xazax
Date: Thu Aug 20 17:59:49 2015
New Revision: 245637
URL: http://llvm.org/viewvc/llvm-project?rev=245637&view=rev
Log:
[Static Analyzer] Made it easier to test new checkers using the test suite.
Modified:
cfe/trunk/utils/analyzer/SATestBuild.py
Modified: cfe/trunk/utils/analyzer
rsmith added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, "%0 null pointer of type %1")
<< TypeCheckKinds[Data->TypeCheckKind] << Data->Type;
I feel very silly now.
After testing the testcase again on svn it still works.
It appears the OP was looking for this patch to go onto the 3.6 branch and
was applying my patch to that.
I'll know in future to recheck the testcase afterwards myself in future.
Apologies for the noise guys.
Yaron I
samsonov added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, "%0 null pointer of type %1")
<< TypeCheckKinds[Data->TypeCheckKind] << Data->Type;
--
jmgao added a comment.
In http://reviews.llvm.org/D12181#229467, @rsmith wrote:
> In http://reviews.llvm.org/D12181#229358, @rsmith wrote:
>
> > Can you please give a brief description of the motivation for this change?
> > When would it be appropriate to use this rather than `-ftrap-function`?
rsmith added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, "%0 null pointer of type %1")
<< TypeCheckKinds[Data->TypeCheckKind] << Data->Type;
jmgao updated this revision to Diff 32768.
jmgao added a comment.
Make option fit in 80 cols
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/Fr
jmgao updated this revision to Diff 32769.
jmgao added a comment.
Doc fix, 80 col
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/Frontend/Comp
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
lgtm
http://reviews.llvm.org/D12164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, "%0 null pointer of type %1")
<< TypeCheckKinds[Data->TypeCheckKind] << Data->Type;
--
tra added a comment.
Reverted in r245592 due to breaking internal tests.
Repository:
rL LLVM
http://reviews.llvm.org/D12122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4763
@@ +4762,3 @@
+ /// arithmetic.
+ bool UseStrictCastingRules;
+
This should be handled as an `EvaluationMode`.
Comment at: lib/AST/ExprConstant.cpp:4879-4907
@@ +4878,31 @@
jmgao updated this revision to Diff 32776.
jmgao marked 2 inline comments as done.
jmgao added a comment.
Make methods private
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/
petarj added a comment.
This patch can now be abandoned, as an updated version is available at
http://reviews.llvm.org/D12200 .
http://reviews.llvm.org/D4724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
filcab added a subscriber: filcab.
filcab added a comment.
Looks good, thanks for working on this.
I added some code style comments.
Comment at: lib/CodeGen/CGExpr.cpp:2399
@@ -2385,1 +2398,3 @@
+
+void CodeGenFunction::EmitTrapCheck(llvm::Value *Checked, const std::string
&Tra
Author: hans
Date: Thu Aug 20 19:49:32 2015
New Revision: 245653
URL: http://llvm.org/viewvc/llvm-project?rev=245653&view=rev
Log:
Creating release candidate rc3 from release_370 branch
Added:
libcxx/tags/RELEASE_370/rc3/ (props changed)
- copied from r245652, libcxx/branches/release_
Author: hans
Date: Thu Aug 20 19:49:35 2015
New Revision: 245654
URL: http://llvm.org/viewvc/llvm-project?rev=245654&view=rev
Log:
Creating release candidate rc3 from release_370 branch
Added:
libcxxabi/tags/RELEASE_370/rc3/ (props changed)
- copied from r245653, libcxxabi/branches/re
Author: hans
Date: Thu Aug 20 19:49:55 2015
New Revision: 245660
URL: http://llvm.org/viewvc/llvm-project?rev=245660&view=rev
Log:
Creating release candidate rc3 from release_370 branch
Added:
libunwind/tags/RELEASE_370/rc3/ (props changed)
- copied from r245659, libunwind/branches/re
mzolotukhin created this revision.
mzolotukhin added reviewers: hfinkel, doug.gregor, t.p.northover, ab, mcrosier.
mzolotukhin added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
Currently there is no way to generate nontemporal memory accesses for some
architectures, e.g. for AA
majnemer added a subscriber: majnemer.
majnemer added a comment.
What does it mean to have the attribute applied to non-pointer types like `int
__attribute__((nontemporal)) i;` ? The ACLE doesn't say but making it
erroneous might make sense. Perhaps it would be good to have a semantic test
wh
george.burgess.iv added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4763
@@ +4762,3 @@
+ /// arithmetic.
+ bool UseStrictCastingRules;
+
rsmith wrote:
> This should be handled as an `EvaluationMode`.
Works for me.
Comment at: lib/AST/
On Thu, Aug 20, 2015 at 6:39 PM, Michael Zolotukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> mzolotukhin created this revision.
> mzolotukhin added reviewers: hfinkel, doug.gregor, t.p.northover, ab,
> mcrosier.
> mzolotukhin added a subscriber: cfe-commits.
> Herald added a subscrib
jmgao updated this revision to Diff 32788.
jmgao marked 7 inline comments as done.
jmgao added a comment.
clang-format, remove \brief from modified doxygen comments.
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOp
Author: rsmith
Date: Thu Aug 20 22:04:33 2015
New Revision: 245664
URL: http://llvm.org/viewvc/llvm-project?rev=245664&view=rev
Log:
[modules] When we see a definition of a function for which we already have a
non-visible definition, skip the new definition to avoid ending up with a
function with
ABataev updated this revision to Diff 32790.
ABataev added a comment.
Update after review from Kelvin
http://reviews.llvm.org/D12152
Files:
docs/UsersManual.rst
Index: docs/UsersManual.rst
===
--- docs/UsersManual.rst
+++ docs/U
ABataev added a subscriber: ABataev.
ABataev added a comment.
I'll update patch, Michael
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
20.08.2015 18:40, Michael Wong пишет:
> fraggamuffin added a comment.
>
>
> Comment at: lib/Parse/Pars
I'll update patch, Michael
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
20.08.2015 18:40, Michael Wong пишет:
fraggamuffin added a comment.
Comment at: lib/Parse/ParseDeclCXX.cpp:3011
@@ -3010,3 +3010,3 @@
if (Tok.is(tok::annot_pra
Author: compnerd
Date: Thu Aug 20 22:21:31 2015
New Revision: 245665
URL: http://llvm.org/viewvc/llvm-project?rev=245665&view=rev
Log:
unwind: fix invalid memory access
Fix out-of-bounds array access when setting arm float registers.
Patch by Leandro Graciá Gil!
Modified:
libunwind/trunk/sr
On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg wrote:
> +Saleem and Renato; maybe you can take a look?
Thanks for pointing this out!
The patch is correct and pretty safe to apply for 3.7 I think since its a
simple bug fix, and can result in VFP state corruption (the invalid memory
access in th
Author: rtrieu
Date: Thu Aug 20 22:43:09 2015
New Revision: 245666
URL: http://llvm.org/viewvc/llvm-project?rev=245666&view=rev
Log:
Fix a few things with -Winfinite-recursion. NFC
Now that -Winfinite-recursion no longer uses recursive calls to before path
analysis, several bits of the code can
Author: jyknight
Date: Thu Aug 20 23:14:55 2015
New Revision: 245667
URL: http://llvm.org/viewvc/llvm-project?rev=245667&view=rev
Log:
Stop treating -static as overriding -fPIC: they are distinct.
For some reason, clang had been treating a command like:
clang -static -fPIC foo.c
as if it should
filcab added a comment.
It seems you missed some `\brief`. Other than that, no complaints on this side.
Comment at: lib/CodeGen/CGExpr.cpp:2303
@@ -2302,4 +2302,3 @@
- if (TrapCond)
-EmitTrapCheck(TrapCond);
+ if (TrapCond) EmitSanitizeTrapCheck(TrapCond);
if (!FatalC
ABataev updated this revision to Diff 32792.
ABataev added a comment.
Updated to latest version.
http://reviews.llvm.org/D11182
Files:
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclBase.h
include/clang/AST/DeclOpenMP.h
include/clang/AST/RecursiveASTVisitor.h
includ
sfantao updated this revision to Diff 32796.
sfantao added a comment.
Implement proxy function for target directive.
Move the creation of the target region parameters from
`CGOpenMPRuntime::emitTargetCall` to CodeGenFunction::EmitTargetDirective
because we need to access the VLA Maps of the tar
sfantao added a comment.
Thanks for review. The new diff now uses a proxy function. See other comments
inlined.
Thanks again!
Samuel
Comment at: lib/CodeGen/CGExpr.cpp:1969-1970
@@ -1945,4 +1968,4 @@
else
- return EmitCapturedFieldLValue(*this, CapturedStmtIn
Author: abataev
Date: Fri Aug 21 01:41:23 2015
New Revision: 245674
URL: http://llvm.org/viewvc/llvm-project?rev=245674&view=rev
Log:
[OPENMP 4.1] Improved codegen for 'uval' qualifier of 'linear' clause.
According to standard the 'uval' modifier declares the address of the original
list item to
Author: majnemer
Date: Fri Aug 21 01:44:10 2015
New Revision: 245675
URL: http://llvm.org/viewvc/llvm-project?rev=245675&view=rev
Log:
[Sema] Don't crash when diagnosing hack in libstdc++
While working around a bug in certain standard library implementations,
we would try to diagnose the issue so
alexfh added a comment.
Thank you for tackling this!
A high-level comment: the check needs to be somewhat more general.
Const-qualified variables are just a specific case of an rvalue. The check
should warn on all usages of std::move with an rvalue argument (except in
templates with arguments
101 - 155 of 155 matches
Mail list logo
