rsmith added inline comments.
Comment at: include/clang/Basic/Diagnostic.h:936-937
@@ -935,3 +935,4 @@
public:
/// Copy constructor. When copied, this "takes" the diagnostic info from the
/// input and neuters it.
+ DiagnosticBuilder(DiagnosticBuilder &&D) {
-
silvas added a subscriber: silvas.
silvas added a comment.
From a Sphinx perspective, this looks fine to me. You may want to consider
using `html_theme = 'haiku'` for consistency with clang, but reusing LLVM's is
fine. (the reason I had clang use 'haiku' is that it is a bit better put
together
EricWF added a comment.
In http://reviews.llvm.org/D12129#227320, @silvas wrote:
> From a Sphinx perspective, this looks fine to me. You may want to consider
> using `html_theme = 'haiku'` for consistency with clang, but reusing LLVM's
> is fine. (the reason I had clang use 'haiku' is that it i
EricWF added a comment.
I've uploaded a version of the docs built with the "haiku" theme to
http://efcs.ca/libcxx-haiku-docs. I would like other's input on which style
they prefer (Note: The LLVM themed docs are here http://efcs.ca/libcxx-docs).
http://reviews.llvm.org/D12129
__
EricWF added a comment.
Is this going to break this test with older versions of compiler-rt?
http://reviews.llvm.org/D12117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
I don't think the tricky part of this patch is actually implementing the ABI
macros. The tricky part is defining how libc++ should use the macros. Some
questions I would like to see answered:
1. How long is a major and minor ABI version supported?
2. When is the major a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245401: Insert override at the same line as the end of the
function declaration (authored by ehsan).
Changed prior to commit:
http://reviews.llvm.org/D9286?vs=24449&id=32492#toc
Repository:
rL LLVM
Author: ehsan
Date: Tue Aug 18 21:05:37 2015
New Revision: 245401
URL: http://llvm.org/viewvc/llvm-project?rev=245401&view=rev
Log:
Insert override at the same line as the end of the function declaration
Summary:
The existing check converts the code pattern below:
void f()
{
}
to:
void
Author: gbiv
Date: Tue Aug 18 21:19:07 2015
New Revision: 245403
URL: http://llvm.org/viewvc/llvm-project?rev=245403&view=rev
Log:
Make __builtin_object_size always answer correctly
__builtin_object_size would return incorrect answers for many uses where
type=3. This fixes the inaccuracy by makin
Author: davide
Date: Tue Aug 18 21:21:12 2015
New Revision: 245404
URL: http://llvm.org/viewvc/llvm-project?rev=245404&view=rev
Log:
[SemaExpr] Re-enable missing assertion.
This has been disabled for a long time, but:
1) Initializers work (and apparently they're re reason why this was disabled).
Author: echristo
Date: Tue Aug 18 21:24:21 2015
New Revision: 245405
URL: http://llvm.org/viewvc/llvm-project?rev=245405&view=rev
Log:
Rename getDefaultFeatures -> initDefaultFeatures and update comment
with the current behavior as the name seems to match what's going on.
Modified:
cfe/trunk/
Author: rsmith
Date: Tue Aug 18 21:30:28 2015
New Revision: 245406
URL: http://llvm.org/viewvc/llvm-project?rev=245406&view=rev
Log:
[modules] Don't eagerly deserialize so many ImportDecls. CodeGen basically
ignores ImportDecls imported from modules, so only eagerly deserialize the ones
from a P
Hi,
This is my first patch for clang. It fixes 4 typos:
"targetted" -> "targeted"
"becuase" -> "because"
"staically" -> "statically"
"vitual" -> "virtual"
The svn diff file is attached. Thanks for your advice!
Author: Kai Zhao
Date: Wed Aug 19 10:10:08 2015
New Revision:
Log:
Fix 4 typos:
samsonov added a comment.
Yes. Is this is an issue?
http://reviews.llvm.org/D12117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Not really but I would add a `// UNSUPPORTED: clang-3.5, clang-3.6, clang-3.7`
line to prevent the failures from appearing.
http://reviews.llvm.org/D12117
_
dblaikie updated this revision to Diff 32495.
dblaikie marked 2 inline comments as done.
dblaikie added a comment.
Addressed Richard's code review feedback
http://reviews.llvm.org/D12131
Files:
include/clang/Basic/Diagnostic.h
include/clang/Sema/Sema.h
lib/ARCMigrate/TransformActions.cpp
dblaikie added inline comments.
Comment at: include/clang/Basic/Diagnostic.h:936-937
@@ -935,3 +935,4 @@
public:
/// Copy constructor. When copied, this "takes" the diagnostic info from the
/// input and neuters it.
+ DiagnosticBuilder(DiagnosticBuilder &&D) {
---
On Tue, Aug 18, 2015 at 8:28 PM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> dblaikie added inline comments.
>
>
> Comment at: include/clang/Basic/Diagnostic.h:936-937
> @@ -935,3 +935,4 @@
> public:
>/// Copy constructor. When copied, this "takes" t
Author: ericwf
Date: Tue Aug 18 22:38:41 2015
New Revision: 245410
URL: http://llvm.org/viewvc/llvm-project?rev=245410&view=rev
Log:
Fix use of static_assert macro with nested commas
Modified:
libcxx/trunk/include/thread
Modified: libcxx/trunk/include/thread
URL:
http://llvm.org/viewvc/llvm
Author: ericwf
Date: Tue Aug 18 22:48:08 2015
New Revision: 245411
URL: http://llvm.org/viewvc/llvm-project?rev=245411&view=rev
Log:
Remove commented out TODOs. They defined unneeded methods.
Modified:
libcxx/trunk/include/experimental/any
libcxx/trunk/src/any.cpp
Modified: libcxx/trunk/
ABataev created this revision.
ABataev added reviewers: echristo, rjmccall, rsmith.
ABataev added a subscriber: cfe-commits.
When variables are implicitly captured in lambdas, debug info generated for
captured variables points to location where they are used first. This patch
makes debug info t
Author: ericwf
Date: Tue Aug 18 23:10:15 2015
New Revision: 245413
URL: http://llvm.org/viewvc/llvm-project?rev=245413&view=rev
Log:
Mark std::packaged_task tests as unsupported in C++03.
std::packaged_task requires variadic templates and is #ifdef out in C++03.
This patch silences the tests in C
Author: abataev
Date: Tue Aug 18 23:49:01 2015
New Revision: 245414
URL: http://llvm.org/viewvc/llvm-project?rev=245414&view=rev
Log:
[OPENMP] Link libomp.lib on Windows
Adds libomp.lib for -fopenmp=libomp and libiomp5md.lib for -fopenmp=libiomp5 on
Windows
Differential Revision: http://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245414: [OPENMP] Link libomp.lib on Windows (authored by
ABataev).
Changed prior to commit:
http://reviews.llvm.org/D11932?vs=32275&id=32502#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11932
F
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added subscribers: cfe-commits, mclow.lists.
This patch marks *most* tests for `std::promise`, `std::future` and
`std::shared_future` as unsupported in C++03. These tests fail in C++03 mode
because they attempt to copy a
Author: ericwf
Date: Wed Aug 19 00:00:36 2015
New Revision: 245415
URL: http://llvm.org/viewvc/llvm-project?rev=245415&view=rev
Log:
Use TestAtomic instead of std::atomic so the test can run in C++03
Modified:
libcxx/trunk/test/std/thread/thread.threads/thread.thread.class/thread.thread.memb
EricWF added a comment.
@dim Has this been committed or is there something holding you back?
http://reviews.llvm.org/D11394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
I think we can avoid requiring the need to rebuild every time the headers
change but it's not the cleanest. We could
1. Have an empty `__config_site` file in `libcxx/include`. This `__config_site`
file does not get copied into the build directory.
2. Generate `__config_s
EricWF added a comment.
@mclow.lists: Do other containers need this update as well? If so it might be
worth while writing noexcept traits that handle the `#ifdef` hell in one spot
instead of repeating it throughout.
http://reviews.llvm.org/D10963
EricWF added a comment.
I also just realized that this change will currently likely play havoc with how
libc++ and libc++abi build together. In order to build libc++ and libc++abi
together we would need to
1. Configure libc++ pointing to the libc++abi headers in order to generate the
__config_
EricWF added a reviewer: EricWF.
EricWF added a comment.
This patch has a long way to go but it has also come a long way. Here are a
couple of problems I see with it.
1. There are still plenty of ABI breaks. I'll try and point them all out.
2. This patch adds a lot of headers. libc++ has histori
loverszhaokai created this revision.
loverszhaokai added a reviewer: cfe-commits.
Fix 4 typos:
"targetted" -> "targeted"
"becuase" -> "because"
"staically" -> "statically"
"vitual" -> "virtual"
http://reviews.llvm.org/D12137
Files:
test/CodeGenCXX/ctor-globalopt.cpp
test/Code
dim added a comment.
@ericwf, no, this just dropped off my radar, sorry. I will commit it now. :)
http://reviews.llvm.org/D11394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
Added more inline comments.
Comment at: include/__mutex_base:36
@@ -35,3 +37,3 @@
#else
- mutex() _NOEXCEPT {__m_ = (pthread_mutex_t)PTHREAD_MUTEX_INITIALIZER;}
#endif
Why was the cast insignificant?
Comment at: in
Author: dim
Date: Wed Aug 19 01:43:33 2015
New Revision: 245421
URL: http://llvm.org/viewvc/llvm-project?rev=245421&view=rev
Log:
Fix warnings about pessimizing return moves for C++11 and higher
Summary:
Throughout the libc++ headers, there are a few instances where
_VSTD::move() is used to retur
Prazek updated this revision to Diff 32509.
Prazek added a comment.
Added tests, and changed the VTableComponent code which was wrong on so many
levels. Sorry
http://reviews.llvm.org/D12128
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-avai
101 - 136 of 136 matches
Mail list logo
