Re: [PATCH] D11797: [libclang] Expose the ElaboratedType

2015-08-08 Thread Sergey Kalinichev via cfe-commits
skalinichev updated this revision to Diff 31576. skalinichev marked 6 inline comments as done. skalinichev added a comment. Address raised issues. modocache, great review btw, thanks! http://reviews.llvm.org/D11797 Files: bindings/python/clang/cindex.py include/clang-c/Index.h test/Index

r244400 - [Static Analyzer] Add --analyzer-target option to scan-build.

2015-08-08 Thread Ted Kremenek via cfe-commits
Author: kremenek Date: Sat Aug 8 12:58:47 2015 New Revision: 244400 URL: http://llvm.org/viewvc/llvm-project?rev=244400&view=rev Log: [Static Analyzer] Add --analyzer-target option to scan-build. When interposing on a compiler doing cross-compilation, scan-build does not infer the target triple

Re: [PATCH] D10356: scan-build: Add --analyzer-target option

2015-08-08 Thread Ted Kremenek via cfe-commits
krememek added a comment. Committed r244400 http://reviews.llvm.org/D10356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11781: Refactored pthread usage in libcxx

2015-08-08 Thread David Chisnall via cfe-commits
theraven added a comment. This version looks much better (well, the previous one is cleaner, but this one looks like it shouldn't break the ABI - did you test this? It looks like it should work, but I've not actually tried it). Comment at: include/__config:742 @@ +741,3 @@ +#

Re: [PATCH] D11781: Refactored pthread usage in libcxx

2015-08-08 Thread Fulvio Esposito via cfe-commits
espositofulvio added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__linux__) || defined(__APPLE__) +# define _LIBCPP_THREAD_API _LIBCPP_PTHREAD therave

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

2015-08-08 Thread Richard Smith via cfe-commits
rsmith added a comment. This seems to have a lot of overlap with the function sanitizer. The documentation would probably benefit from some advice about when to use each and how they compare. Comment at: lib/AST/ItaniumMangle.cpp:4119-4126 @@ +4118,10 @@ +

r244409 - [modules] When loading a template specialization, re-canonicalize its template

2015-08-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Aug 8 20:05:31 2015 New Revision: 244409 URL: http://llvm.org/viewvc/llvm-project?rev=244409&view=rev Log: [modules] When loading a template specialization, re-canonicalize its template arguments because the reloaded form might have become non-canonical across the seriali

r244410 - Add file missed from r244409.

2015-08-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Aug 8 20:50:14 2015 New Revision: 244410 URL: http://llvm.org/viewvc/llvm-project?rev=244410&view=rev Log: Add file missed from r244409. Added: cfe/trunk/test/Modules/Inputs/stress1/merge_no_reexport.h Added: cfe/trunk/test/Modules/Inputs/stress1/merge_no_reexport.h

r244411 - [modules] Attach dependency listeners to the module manager once when it's

2015-08-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Aug 8 21:28:42 2015 New Revision: 244411 URL: http://llvm.org/viewvc/llvm-project?rev=244411&view=rev Log: [modules] Attach dependency listeners to the module manager once when it's created, rather than creating and attaching a new listener each time we load a module file

r244412 - [modules] Don't leak -M flags for dependency file generation into the module

2015-08-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Aug 8 21:44:20 2015 New Revision: 244412 URL: http://llvm.org/viewvc/llvm-project?rev=244412&view=rev Log: [modules] Don't leak -M flags for dependency file generation into the module build process when we implicitly build a module. Previously, we'd create the specified .

r244414 - Revert "[modules] Don't leak -M flags for dependency file generation into the module"

2015-08-08 Thread Justin Bogner via cfe-commits
Author: bogner Date: Sun Aug 9 00:40:38 2015 New Revision: 244414 URL: http://llvm.org/viewvc/llvm-project?rev=244414&view=rev Log: Revert "[modules] Don't leak -M flags for dependency file generation into the module" This was failing tests on a bunch of bots: http://lab.llvm.org:8011/builders

Re: r244412 - [modules] Don't leak -M flags for dependency file generation into the module

2015-08-08 Thread Justin Bogner via cfe-commits
Richard Smith via cfe-commits writes: > Author: rsmith > Date: Sat Aug 8 21:44:20 2015 > New Revision: 244412 > > URL: http://llvm.org/viewvc/llvm-project?rev=244412&view=rev > Log: > [modules] Don't leak -M flags for dependency file generation into the module > build process when we implicitly b