Re: r366449 - [CrossTU] Add a function to retrieve original source location.

2019-07-18 Thread Ilya Biryukov via cfe-commits
Reverted in r366453 On Thu, Jul 18, 2019 at 5:38 PM Ilya Biryukov wrote: > Hi Balazs, > > Your commit introduces a layering violation: ASTImporter (which is inside > clangAST library) cannot depend on ASTUnit (which is inside clangFrontend > library). > I'm afraid I'll have to revert the commit

r366453 - Revert r366449: [CrossTU] Add a function to retrieve original source location.

2019-07-18 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jul 18 08:43:26 2019 New Revision: 366453 URL: http://llvm.org/viewvc/llvm-project?rev=366453&view=rev Log: Revert r366449: [CrossTU] Add a function to retrieve original source location. Reason: the commit breaks layering by adding a dependency on ASTUnit (whic

Re: r366449 - [CrossTU] Add a function to retrieve original source location.

2019-07-18 Thread Ilya Biryukov via cfe-commits
Hi Balazs, Your commit introduces a layering violation: ASTImporter (which is inside clangAST library) cannot depend on ASTUnit (which is inside clangFrontend library). I'm afraid I'll have to revert the commit to unbreak our integrate. On Thu, Jul 18, 2019 at 5:22 PM Balazs Keri via cfe-commits

r366449 - [CrossTU] Add a function to retrieve original source location.

2019-07-18 Thread Balazs Keri via cfe-commits
Author: balazske Date: Thu Jul 18 08:23:10 2019 New Revision: 366449 URL: http://llvm.org/viewvc/llvm-project?rev=366449&view=rev Log: [CrossTU] Add a function to retrieve original source location. Summary: A new function will be added to get the original SourceLocation for a SourceLocation that