Re: r363086 - For DR712: store on a DeclRefExpr whether it constitutes an odr-use.

2019-08-27 Thread Hans Wennborg via cfe-commits
Bisection for https://bugs.llvm.org/show_bug.cgi?id=42861 also points to this revision. On Wed, Jun 12, 2019 at 1:49 AM Richard Smith via cfe-commits wrote: > > Thanks, should be fixed by r363113. > > On Tue, 11 Jun 2019 at 16:21, Reid Kleckner via cfe-commits > wrote: >> >> >> The new assert i

Re: r363086 - For DR712: store on a DeclRefExpr whether it constitutes an odr-use.

2019-06-11 Thread Richard Smith via cfe-commits
Thanks, should be fixed by r363113. On Tue, 11 Jun 2019 at 16:21, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > The new assert is firing across Chromium, please fix or revert. This is a > reduced test case: > > int a; > struct Foo { > template void operator()(b, c = >

Re: r363086 - For DR712: store on a DeclRefExpr whether it constitutes an odr-use.

2019-06-11 Thread Reid Kleckner via cfe-commits
The new assert is firing across Chromium, please fix or revert. This is a reduced test case: int a; struct Foo { template void operator()(b, c = a); }; Foo d; bool e; decltype(d(e)) gv; This causes the "missing non-odr-use marking for unevaluated decl ref" assertion on SemaExpr.cpp:16227 to fi

r363086 - For DR712: store on a DeclRefExpr whether it constitutes an odr-use.

2019-06-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jun 11 10:50:32 2019 New Revision: 363086 URL: http://llvm.org/viewvc/llvm-project?rev=363086&view=rev Log: For DR712: store on a DeclRefExpr whether it constitutes an odr-use. Begin restructuring to support the forms of non-odr-use reference permitted by DR712. Modified