On Wed, 24 Apr 2019 at 13:28, Richard Smith wrote:
>
> Thanks for the revert.
>
> Looks like this is probably an unfortunate interaction with the
> internal_linkage attribute.
I think this is a libc++ bug. When
_LIBCPP_HIDE_FROM_ABI_PER_TU_BY_DEFAULT is enabled, we have:
#define _LIBCPP_HIDE_FR
Thanks for the revert.
Looks like this is probably an unfortunate interaction with the
internal_linkage attribute.
On Wed, 24 Apr 2019, 01:48 Ilya Biryukov via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> Reverted in r359076.
>
> On Wed, Apr 24, 2019 at 10:28 AM Ilya Biryukov
> wrote:
>
Reverted in r359076.
On Wed, Apr 24, 2019 at 10:28 AM Ilya Biryukov wrote:
> Hi Richard,
>
> This seems to break libc++, found while doing an integrate. The errors are:
>
> In file included from valarray:4:
> .../include/c++/v1/valarray:1062:60: error: explicit instantiation
> declaration of 'va
Hi Richard,
This seems to break libc++, found while doing an integrate. The errors are:
In file included from valarray:4:
.../include/c++/v1/valarray:1062:60: error: explicit instantiation
declaration of 'valarray<_Tp>' with internal linkage
_LIBCPP_EXTERN_TEMPLATE(_LIBCPP_FUNC_VIS valarray::vala
Author: rsmith
Date: Tue Apr 23 16:48:00 2019
New Revision: 359048
URL: http://llvm.org/viewvc/llvm-project?rev=359048&view=rev
Log:
C++ DR2387: a variable template declared wtih (or instantiated with) a
const-qualified type is not implicitly given internal linkage. But a
variable template declare
