Re: r350776 - [Sema] Mark target of __attribute__((alias("target"))) used for C

2019-01-11 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jan 10, 2019 at 09:58:39AM -0800, Nick Desaulniers via cfe-commits wrote: > On Thu, Jan 10, 2019 at 7:26 AM Nico Weber wrote: > > > > Aren't C names sometimes slightly mangled too? For example, on macOS > > they're prefixed by a _, doesn't that have to be undone there? > > Sure, but sho

Re: r350776 - [Sema] Mark target of __attribute__((alias("target"))) used for C

2019-01-10 Thread Nick Desaulniers via cfe-commits
On Thu, Jan 10, 2019 at 7:26 AM Nico Weber wrote: > > Aren't C names sometimes slightly mangled too? For example, on macOS they're > prefixed by a _, doesn't that have to be undone there? Sure, but short of instantiating a demangler in Sema or rewriting how Clang checks for unused variables, thi

Re: r350776 - [Sema] Mark target of __attribute__((alias("target"))) used for C

2019-01-10 Thread Nico Weber via cfe-commits
Aren't C names sometimes slightly mangled too? For example, on macOS they're prefixed by a _, doesn't that have to be undone there? On Wed, Jan 9, 2019 at 6:58 PM Nick Desaulniers via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nickdesaulniers > Date: Wed Jan 9 15:54:55 2019 > New

r350776 - [Sema] Mark target of __attribute__((alias("target"))) used for C

2019-01-09 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Wed Jan 9 15:54:55 2019 New Revision: 350776 URL: http://llvm.org/viewvc/llvm-project?rev=350776&view=rev Log: [Sema] Mark target of __attribute__((alias("target"))) used for C Summary: Prevents -Wunneeded-internal-delcaration warnings when the target has no other r