Reverted on the release_80 branch in r353935.
On Fri, Jan 4, 2019 at 6:01 PM Aaron Ballman via cfe-commits
wrote:
>
> Author: aaronballman
> Date: Fri Jan 4 08:58:14 2019
> New Revision: 350404
>
> URL: http://llvm.org/viewvc/llvm-project?rev=350404&view=rev
> Log:
> Refactor the way we handle d
On Sun, Jan 6, 2019 at 10:58 AM Nico Weber wrote:
>
> On Sat, Jan 5, 2019 at 10:16 AM Aaron Ballman wrote:
>>
>> On Fri, Jan 4, 2019 at 8:41 PM Richard Smith wrote:
>> >
>> > On Fri, 4 Jan 2019 at 17:33, Nico Weber via cfe-commits
>> > wrote:
>> >>
>> >> Nice, this is finding bugs:
>> >> http
On Fri, Jan 4, 2019 at 8:41 PM Richard Smith wrote:
>
> On Fri, 4 Jan 2019 at 17:33, Nico Weber via cfe-commits
> wrote:
>>
>> Nice, this is finding bugs:
>> https://bugs.chromium.org/p/chromium/issues/detail?id=919262
>>
>> However, I noticed that for that case, the same warning is printed twi
On Fri, 4 Jan 2019 at 17:33, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Nice, this is finding bugs:
> https://bugs.chromium.org/p/chromium/issues/detail?id=919262
>
> However, I noticed that for that case, the same warning is printed twice:
>
> ../../third_party/crashpad/cra
Nice, this is finding bugs:
https://bugs.chromium.org/p/chromium/issues/detail?id=919262
However, I noticed that for that case, the same warning is printed twice:
../../third_party/crashpad/crashpad/util/win/process_info.cc(227,36):
error: expression result unused [-Werror,-Wunused-value]
N
Author: aaronballman
Date: Fri Jan 4 08:58:14 2019
New Revision: 350404
URL: http://llvm.org/viewvc/llvm-project?rev=350404&view=rev
Log:
Refactor the way we handle diagnosing unused expression results.
Rather than sprinkle calls to DiagnoseUnusedExprResult() around in places where
we want diag
