Author: maskray
Date: Fri Nov 30 15:41:18 2018
New Revision: 348053
URL: http://llvm.org/viewvc/llvm-project?rev=348053&view=rev
Log:
Revert "Revert r347417 "Re-Reinstate 347294 with a fix for the failures.""
It seems the two failing tests can be simply fixed after
Author: maskray
Date: Fri Nov 30 13:26:09 2018
New Revision: 348039
URL: http://llvm.org/viewvc/llvm-project?rev=348039&view=rev
Log:
Revert r347417 "Re-Reinstate 347294 with a fix for the failures."
Kept the "indirect_builtin_constant_p" test case in
test/SemaCXX/const
There's more details on http://crbug.com/908372, but my conclusion is
that there wasn't anything wrong with your commit, it just triggered a
bug in Chromium's code that had been hiding there for six years
without anyone noticing.
I've re-committed your change in r347756. Sorry for the hassle.
On
Author: hans
Date: Wed Nov 28 06:04:12 2018
New Revision: 347756
URL: http://llvm.org/viewvc/llvm-project?rev=347756&view=rev
Log:
Re-commit r347417 "Re-Reinstate 347294 with a fix for the failures."
This was reverted in r347656 due to me thinking it caused a miscompile of
Chromium
I've reverted this and the follow-ups in r347656 and included a
reduced repro for the miscompile.
On Tue, Nov 27, 2018 at 11:36 AM, Hans Wennborg wrote:
> We're hitting test failures due to this in Chromium:
> https://crbug.com/908372 I'm still not sure what's going on, just
> wanted to give a he
Author: hans
Date: Tue Nov 27 06:01:40 2018
New Revision: 347656
URL: http://llvm.org/viewvc/llvm-project?rev=347656&view=rev
Log:
Revert r347417 "Re-Reinstate 347294 with a fix for the failures."
This caused a miscompile in Chrome (see crbug.com/908372) that's
illust
We're hitting test failures due to this in Chromium:
https://crbug.com/908372 I'm still not sure what's going on, just
wanted to give a heads up in case someone else is seeing issues.
On Wed, Nov 21, 2018 at 9:44 PM, Bill Wendling via cfe-commits
wrote:
> Author: void
> Date: Wed Nov 21 12:44:18
Author: void
Date: Wed Nov 21 12:44:18 2018
New Revision: 347417
URL: http://llvm.org/viewvc/llvm-project?rev=347417&view=rev
Log:
Re-Reinstate 347294 with a fix for the failures.
Don't try to emit a scalar expression for a non-scalar argument to
__builtin_constant_p().
Third time's a charm!
Ad
