Re: r341141 - Extract parseBindID method

2018-09-06 Thread Stephen Kelly via cfe-commits
On 06/09/18 20:42, Roman Lebedev wrote: You can specify the dependencies between the differentials in phabricator. I didn't know that, thanks! ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: r341141 - Extract parseBindID method

2018-09-06 Thread Roman Lebedev via cfe-commits
On Thu, Sep 6, 2018 at 10:05 PM, Stephen Kelly via cfe-commits wrote: > > Yes, this was a prerequisite to https://reviews.llvm.org/D51259. For some > reason the reviewer accepted that one, but not this one. I simply assumed > that was a mistake and committed this one. I'm not sure this is how the

Re: r341141 - Extract parseBindID method

2018-09-06 Thread Stephen Kelly via cfe-commits
Yes, this was a prerequisite to https://reviews.llvm.org/D51259. For some reason the reviewer accepted that one, but not this one. I simply assumed that was a mistake and committed this one. Perhaps part of the problem is that I do one thing per commit, and that confuses reviewers. Maybe I s

Re: r341141 - Extract parseBindID method

2018-08-30 Thread Roman Lebedev via cfe-commits
I don't think this was reviewed. The differential is not in 'accepted' state. Roman. On Fri, Aug 31, 2018 at 2:11 AM, Stephen Kelly via cfe-commits wrote: > Author: steveire > Date: Thu Aug 30 16:11:01 2018 > New Revision: 341141 > > URL: http://llvm.org/viewvc/llvm-project?rev=341141&view=rev >

r341141 - Extract parseBindID method

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:11:01 2018 New Revision: 341141 URL: http://llvm.org/viewvc/llvm-project?rev=341141&view=rev Log: Extract parseBindID method Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D51258 Modified: cfe/trunk/include/clang/ASTMatchers/Dyn