Re: r337850 - Revert "[VFS] Cleanups to VFS interfaces."

2018-07-25 Thread Eric Liu via cfe-commits
Thanks Jordan! On Wed, Jul 25, 2018 at 6:01 PM Jordan Rupprecht wrote: > On Wed, Jul 25, 2018 at 1:40 AM Eric Liu wrote: > >> Please also include a link to the test failure in the commit message or >> this email thread. >> > Sorry, I left the failure on the review thread ( > https://reviews.llv

Re: r337850 - Revert "[VFS] Cleanups to VFS interfaces."

2018-07-25 Thread Jordan Rupprecht via cfe-commits
On Wed, Jul 25, 2018 at 1:40 AM Eric Liu wrote: > Please also include a link to the test failure in the commit message or > this email thread. > Sorry, I left the failure on the review thread ( https://reviews.llvm.org/D49724) but forgot to include it in the commit message. I'll make sure to do t

Re: r337850 - Revert "[VFS] Cleanups to VFS interfaces."

2018-07-25 Thread Eric Liu via cfe-commits
Please also include a link to the test failure in the commit message or this email thread. On Tue, Jul 24, 2018 at 10:28 PM Jordan Rupprecht via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rupprecht > Date: Tue Jul 24 13:28:07 2018 > New Revision: 337850 > > URL: http://llvm.org/vi

r337850 - Revert "[VFS] Cleanups to VFS interfaces."

2018-07-24 Thread Jordan Rupprecht via cfe-commits
Author: rupprecht Date: Tue Jul 24 13:28:07 2018 New Revision: 337850 URL: http://llvm.org/viewvc/llvm-project?rev=337850&view=rev Log: Revert "[VFS] Cleanups to VFS interfaces." This reverts commit r337834 due to test failures. Modified: cfe/trunk/include/clang/Basic/VirtualFileSystem.h