Re: r335854 - Fix unittest build with GCC older than 5.

2018-06-28 Thread Alexander Kornienko via cfe-commits
Thanks! I was going to push the same fix, but you also explained why it's needed ;) On Thu, Jun 28, 2018 at 3:36 PM Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Thu Jun 28 06:31:36 2018 > New Revision: 335854 > > URL: http://llvm.org/viewvc/llvm-proje

r335854 - Fix unittest build with GCC older than 5.

2018-06-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Jun 28 06:31:36 2018 New Revision: 335854 URL: http://llvm.org/viewvc/llvm-project?rev=335854&view=rev Log: Fix unittest build with GCC older than 5. Old GCCs have an annoying bug where RVO disables the automatic conversion to base for unique_ptr. Add a pessimizing std::move