Re: r327959 - [ms] Parse #pragma optimize and ignore it behind its own flag

2018-03-22 Thread Hans Wennborg via cfe-commits
This is a bit confusing, I think. We use -Wignored-pragmas for pragmas that clang doesn't parse, and also for ignored #pragma intrinsics. -Wunknown-pragmas isn't used that much, but there is e.g. "pragma STDC FENV_ACCESS ON is not supported, ignoring pragma". Note that the text says it's unsupport

Re: r327959 - [ms] Parse #pragma optimize and ignore it behind its own flag

2018-03-21 Thread Hans Wennborg via cfe-commits
Not sure either, but I think the ignored warning is used for pragmas that clang fails to parse, so maybe unsupported is better. On Wed, Mar 21, 2018 at 9:33 PM, Nico Weber wrote: > Ah! Hm, maybe that's the better group for this anyway? Not sure. > > On Wed, Mar 21, 2018, 9:03 PM Hans Wennborg wr

Re: r327959 - [ms] Parse #pragma optimize and ignore it behind its own flag

2018-03-21 Thread Nico Weber via cfe-commits
Ah! Hm, maybe that's the better group for this anyway? Not sure. On Wed, Mar 21, 2018, 9:03 PM Hans Wennborg wrote: > Aw, rats. I put it under -Wignored-pragmas rather than > -Wunsupported-pragmas, because I was looking at #pragma intrinsic. > > I'll take a look at this again tomorrow. > > On We

Re: r327959 - [ms] Parse #pragma optimize and ignore it behind its own flag

2018-03-21 Thread Hans Wennborg via cfe-commits
Aw, rats. I put it under -Wignored-pragmas rather than -Wunsupported-pragmas, because I was looking at #pragma intrinsic. I'll take a look at this again tomorrow. On Wed, Mar 21, 2018 at 5:18 PM, Nico Weber via cfe-commits wrote: > From the bot changes, it seems that -Wunknown-pragma doesn't dis

Re: r327959 - [ms] Parse #pragma optimize and ignore it behind its own flag

2018-03-21 Thread Nico Weber via cfe-commits
>From the bot changes, it seems that -Wunknown-pragma doesn't disable this new warning. Shouldn't it do that? On Tue, Mar 20, 2018, 9:55 AM Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hans > Date: Tue Mar 20 01:53:11 2018 > New Revision: 327959 > > URL: http://llv

r327959 - [ms] Parse #pragma optimize and ignore it behind its own flag

2018-03-20 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Mar 20 01:53:11 2018 New Revision: 327959 URL: http://llvm.org/viewvc/llvm-project?rev=327959&view=rev Log: [ms] Parse #pragma optimize and ignore it behind its own flag This allows users to turn off warnings about this pragma specifically, while still receiving warnings ab