Merged in r322632.
On Wed, Jan 17, 2018 at 9:52 AM, NAKAMURA Takumi via cfe-commits
wrote:
> That's good to hear. Thanks!
>
>
> 2018年1月17日(水) 13:51 Richard Trieu :
>>
>> I feel it's best to merge this change into the release branch instead of
>> reverting the previous change. I've filed a bug to
That's good to hear. Thanks!
2018年1月17日(水) 13:51 Richard Trieu :
> I feel it's best to merge this change into the release branch instead of
> reverting the previous change. I've filed a bug to request this revision,
> and a few others that fix the test case, to be merged.
> https://bugs.llvm.org
I feel it's best to merge this change into the release branch instead of
reverting the previous change. I've filed a bug to request this revision,
and a few others that fix the test case, to be merged.
https://bugs.llvm.org/show_bug.cgi?id=35981
On Tue, Jan 16, 2018 at 2:44 PM, NAKAMURA Takumi
w
If r322350 is temporary fix, I suggest r321395 may be reverted in
release_60. Richard, how do you think?
On Wed, Jan 17, 2018 at 4:27 AM Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> There was a different, possibly related, issue with templated methods that
> I just disable
There was a different, possibly related, issue with templated methods that
I just disabled checking for methods all together in r321396 until I can
investigate further.
On Mon, Jan 15, 2018 at 10:45 AM, David Blaikie wrote:
> I'm surprised this problem is unique to friend functions with definiti
I'm surprised this problem is unique to friend functions with definitions
inline and the friend declaration site - doesn't a similar issue occur with
member functions of templates that are not instantiated in some (similar)
contexts?
Is there a common solution that could be used for both cases?
O
Could we pull this into release_60? It resolves an issue in r321395.
On Fri, Jan 12, 2018 at 1:43 PM Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Thu Jan 11 20:42:27 2018
> New Revision: 322350
>
> URL: http://llvm.org/viewvc/llvm-project?rev=322350&
Author: rtrieu
Date: Thu Jan 11 20:42:27 2018
New Revision: 322350
URL: http://llvm.org/viewvc/llvm-project?rev=322350&view=rev
Log:
[ODRHash] Don't hash friend functions.
In certain combinations of templated classes and friend functions, the body
of friend functions does not get propagated along
