Re: r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-25 Thread Saleem Abdulrasool via cfe-commits
Sure, I’ll add a release note. The type for the -fno-short-wchar shouldn’t have changed on ARM. That sounds like a mistake. We could just promote the -fsigned-wchar to a driver level flag. Every target seems to use signed int, not unsigned int for wchar_t. On Wed, Oct 25, 2017 at 1:32 PM Fried

Re: r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-25 Thread Friedman, Eli via cfe-commits
On 10/25/2017 12:49 PM, Reid Kleckner wrote: On Wed, Oct 25, 2017 at 12:14 PM, Friedman, Eli mailto:efrie...@codeaurora.org>> wrote: Maybe we should just ignore -fno-short-wchar, instead?  I think that's what gcc and released versions of clang do (that means -fno-short-wchar doesn't

Re: r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-25 Thread Reid Kleckner via cfe-commits
On Wed, Oct 25, 2017 at 12:14 PM, Friedman, Eli wrote: > Maybe we should just ignore -fno-short-wchar, instead? I think that's > what gcc and released versions of clang do (that means -fno-short-wchar > doesn't do anything for Windows targets, but that's probably fine). > No, the intention of t

Re: r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-25 Thread Friedman, Eli via cfe-commits
On 10/25/2017 11:54 AM, Reid Kleckner wrote: On Wed, Oct 25, 2017 at 10:56 AM, Friedman, Eli mailto:efrie...@codeaurora.org>> wrote: On 10/6/2017 4:09 PM, Saleem Abdulrasool via cfe-commits wrote: Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL: http://llvm

Re: r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-25 Thread Reid Kleckner via cfe-commits
On Wed, Oct 25, 2017 at 10:56 AM, Friedman, Eli wrote: > On 10/6/2017 4:09 PM, Saleem Abdulrasool via cfe-commits wrote: > >> Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp >> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Too >> lChains/Clang.cpp?rev=315126&r1=315125&r2=31512

Re: r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-25 Thread Friedman, Eli via cfe-commits
On 10/6/2017 4:09 PM, Saleem Abdulrasool via cfe-commits wrote: Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=315126&r1=315125&r2=315126&view=diff

r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Oct 6 16:09:55 2017 New Revision: 315126 URL: http://llvm.org/viewvc/llvm-project?rev=315126&view=rev Log: Driver: hoist the `wchar_t` handling to the driver Move the logic for determining the `wchar_t` type information into the driver. Rather than passing the single