Re: r276232 - [Sema] Fix PR28623.

2016-07-22 Thread George Burgess IV via cfe-commits
r276489. Thanks! On Fri, Jul 22, 2016 at 3:17 PM, Richard Smith wrote: > On Fri, Jul 22, 2016 at 3:15 PM, George Burgess IV < > george.burgess...@gmail.com> wrote: > >> (Assuming "yes" :) ) >> >> Richard, are you okay with this being merged into 3.9? >> > > Yes, LGTM for 3.9. > > >> On Fri, Jul

Re: r276232 - [Sema] Fix PR28623.

2016-07-22 Thread Richard Smith via cfe-commits
On Fri, Jul 22, 2016 at 3:15 PM, George Burgess IV < george.burgess...@gmail.com> wrote: > (Assuming "yes" :) ) > > Richard, are you okay with this being merged into 3.9? > Yes, LGTM for 3.9. > On Fri, Jul 22, 2016 at 9:54 AM, George Burgess IV < > george.burgess...@gmail.com> wrote: > >> Error

Re: r276232 - [Sema] Fix PR28623.

2016-07-22 Thread George Burgess IV via cfe-commits
(Assuming "yes" :) ) Richard, are you okay with this being merged into 3.9? On Fri, Jul 22, 2016 at 9:54 AM, George Burgess IV < george.burgess...@gmail.com> wrote: > Error message says r272936 had the error, so it looks like it would, > yeah. :) > > Would you like me to merge it to the 3.9 bran

Re: r276232 - [Sema] Fix PR28623.

2016-07-22 Thread George Burgess IV via cfe-commits
Error message says r272936 had the error, so it looks like it would, yeah. :) Would you like me to merge it to the 3.9 branch? On Fri, Jul 22, 2016 at 6:51 AM, Hans Wennborg wrote: > Does this apply to 3.9? > > On Wed, Jul 20, 2016 at 11:28 PM, George Burgess IV via cfe-commits > wrote: > > Au

Re: r276232 - [Sema] Fix PR28623.

2016-07-22 Thread Hans Wennborg via cfe-commits
Does this apply to 3.9? On Wed, Jul 20, 2016 at 11:28 PM, George Burgess IV via cfe-commits wrote: > Author: gbiv > Date: Wed Jul 20 22:28:13 2016 > New Revision: 276232 > > URL: http://llvm.org/viewvc/llvm-project?rev=276232&view=rev > Log: > [Sema] Fix PR28623. > > In atomic builtins, we assume

r276232 - [Sema] Fix PR28623.

2016-07-20 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Wed Jul 20 22:28:13 2016 New Revision: 276232 URL: http://llvm.org/viewvc/llvm-project?rev=276232&view=rev Log: [Sema] Fix PR28623. In atomic builtins, we assumed that the LValue conversion on the first argument would succeed. So, we would crash given code like: ``` void ovl(c