Re: r275895 - [Driver] Compute effective target triples once per job (NFCI)

2016-07-20 Thread Vedant Kumar via cfe-commits
> On Jul 19, 2016, at 3:53 PM, Eric Christopher wrote: > > > > On Tue, Jul 19, 2016 at 3:51 PM Vedant Kumar wrote: > > > On Jul 19, 2016, at 3:38 PM, Eric Christopher wrote: > > > > > > > > On Tue, Jul 19, 2016 at 3:24 PM Vedant Kumar wrote: > > > > > On Jul 19, 2016, at 3:02 PM, Eric Chri

Re: r275895 - [Driver] Compute effective target triples once per job (NFCI)

2016-07-19 Thread Vedant Kumar via cfe-commits
> On Jul 19, 2016, at 3:38 PM, Eric Christopher wrote: > > > > On Tue, Jul 19, 2016 at 3:24 PM Vedant Kumar wrote: > > > On Jul 19, 2016, at 3:02 PM, Eric Christopher wrote: > > > > ... this is pretty crazy. I think that you needed to plumb the effective > > triple through everything means

Re: r275895 - [Driver] Compute effective target triples once per job (NFCI)

2016-07-19 Thread Vedant Kumar via cfe-commits
> On Jul 19, 2016, at 3:02 PM, Eric Christopher wrote: > > ... this is pretty crazy. I think that you needed to plumb the effective > triple through everything means that it really needs to be owned somewhere > else and cached. > > Can you rethink this? In general it doesn't make sense to hav

r275895 - [Driver] Compute effective target triples once per job (NFCI)

2016-07-18 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Mon Jul 18 14:56:38 2016 New Revision: 275895 URL: http://llvm.org/viewvc/llvm-project?rev=275895&view=rev Log: [Driver] Compute effective target triples once per job (NFCI) Compute an effective target triple exactly once in ConstructJob(), and then simply pass around refere