Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

2016-07-18 Thread Hans Wennborg via cfe-commits
Thanks, I've merged the revert in r275902. Cheers, Hans On Mon, Jul 18, 2016 at 12:06 PM, Devin Coughlin wrote: > Reverted in r275880. Sorry about that. I’ll have to investigate why I didn’t > get an email from the bot about the failure. > > Thanks > Devin > > On Jul 18, 2016, at 11:59 AM, Hans

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

2016-07-18 Thread Devin Coughlin via cfe-commits
Reverted in r275880. Sorry about that. I’ll have to investigate why I didn’t get an email from the bot about the failure. Thanks Devin > On Jul 18, 2016, at 11:59 AM, Hans Wennborg wrote: > > Oops, as you suspected I failed at copy/paste. This is the bot that's > broken: http://bb.pgr.jp/build

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

2016-07-18 Thread Hans Wennborg via cfe-commits
Oops, as you suspected I failed at copy/paste. This is the bot that's broken: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/51780 On Mon, Jul 18, 2016 at 10:57 AM, Devin Coughlin wrote: > Hans, > > I’m happy to revert — but I think r275820 is very unlikely to have been the > root caus

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

2016-07-18 Thread Devin Coughlin via cfe-commits
Hans, I’m happy to revert — but I think r275820 is very unlikely to have been the root cause of the issue at http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/40225/ . (The commit is a change to the clang static analyzer a

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

2016-07-18 Thread Hans Wennborg via cfe-commits
It seems to have broken this buildbot: http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/40225/ I'm just about to create the 3.9 release branch, so it would be great if this could fixed/figured out soon. Thanks, Hans On Mon, Jul 18, 2016 at 10:23 AM, Devin Coughlin via cfe-commits wrote:

r275820 - [analyzer] Add checker modeling potential C++ self-assignment

2016-07-18 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Mon Jul 18 12:23:30 2016 New Revision: 275820 URL: http://llvm.org/viewvc/llvm-project?rev=275820&view=rev Log: [analyzer] Add checker modeling potential C++ self-assignment This checker checks copy and move assignment operators whether they are protected against self-assi