Re: r271211 - CodeGen: tweak CFConstantStrings for COFF and ELF

2016-05-30 Thread Rafael Espíndola via cfe-commits
On 30 May 2016 at 16:48, Saleem Abdulrasool wrote: > On Mon, May 30, 2016 at 12:54 PM, Rafael Espíndola > wrote: >> >> Why .rodata.cfstring? Which linker treats that specially? > > > Its mimicking the fact that the CF macros tried to place the structures in > their own section. This would techni

Re: r271211 - CodeGen: tweak CFConstantStrings for COFF and ELF

2016-05-30 Thread Saleem Abdulrasool via cfe-commits
On Mon, May 30, 2016 at 12:54 PM, Rafael Espíndola < rafael.espind...@gmail.com> wrote: > Why .rodata.cfstring? Which linker treats that specially? > Its mimicking the fact that the CF macros tried to place the structures in their own section. This would technically allow a linker to coalesce th

Re: r271211 - CodeGen: tweak CFConstantStrings for COFF and ELF

2016-05-30 Thread Rafael Espíndola via cfe-commits
Why .rodata.cfstring? Which linker treats that specially? On 30 May 2016 at 12:23, Saleem Abdulrasool via cfe-commits wrote: > Author: compnerd > Date: Mon May 30 11:23:07 2016 > New Revision: 271211 > > URL: http://llvm.org/viewvc/llvm-project?rev=271211&view=rev > Log: > CodeGen: tweak CFConsta

r271211 - CodeGen: tweak CFConstantStrings for COFF and ELF

2016-05-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon May 30 11:23:07 2016 New Revision: 271211 URL: http://llvm.org/viewvc/llvm-project?rev=271211&view=rev Log: CodeGen: tweak CFConstantStrings for COFF and ELF Adjust the constant CFString emission to emit into more appropriate sections on ELF and COFF targets. It would