Re: r264783 - [PGO] Move the instrumentation point closer to the value site.

2016-03-29 Thread Artem Belevich via cfe-commits
From:* Artem Belevich [mailto:t...@google.com] > *Sent:* Tuesday, March 29, 2016 3:15 PM > *To:* Betul Buyukkurt > *Cc:* cfe-commits > *Subject:* Re: r264783 - [PGO] Move the instrumentation point closer to > the value site. > > > > Hi, > > > > FYI, cxx-indirect-ca

RE: r264783 - [PGO] Move the instrumentation point closer to the value site.

2016-03-29 Thread Betul Buyukkurt via cfe-commits
Hi Artem, I’ve uploaded a patch to remove the alignment. Thanks, -Betul From: Artem Belevich [mailto:t...@google.com] Sent: Tuesday, March 29, 2016 3:15 PM To: Betul Buyukkurt Cc: cfe-commits Subject: Re: r264783 - [PGO] Move the instrumentation point closer to the value site

Re: r264783 - [PGO] Move the instrumentation point closer to the value site.

2016-03-29 Thread Artem Belevich via cfe-commits
Hi, FYI, cxx-indirect-call.cpp test fails on platforms with different alignment. It may help to either use specific target or change your patterns to accommodate other targets. --Artem TEST 'Clang :: Profile/cxx-indirect-call.cpp' FAILED Script: -- /usr/

r264783 - [PGO] Move the instrumentation point closer to the value site.

2016-03-29 Thread Betul Buyukkurt via cfe-commits
Author: betulb Date: Tue Mar 29 15:44:09 2016 New Revision: 264783 URL: http://llvm.org/viewvc/llvm-project?rev=264783&view=rev Log: [PGO] Move the instrumentation point closer to the value site. For terminator instructions, the value profiling instrumentation happens in a basic block other than