Re: r264071 - StaticAnalyzer: Avoid an unintentional copy

2016-03-29 Thread Justin Bogner via cfe-commits
David Blaikie writes: > On Tue, Mar 22, 2016 at 10:50 AM, Justin Bogner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: bogner >> Date: Tue Mar 22 12:50:05 2016 >> New Revision: 264071 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=264071&view=rev >> Log: >> StaticAnalyzer:

Re: r264071 - StaticAnalyzer: Avoid an unintentional copy

2016-03-22 Thread David Blaikie via cfe-commits
On Tue, Mar 22, 2016 at 10:50 AM, Justin Bogner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: bogner > Date: Tue Mar 22 12:50:05 2016 > New Revision: 264071 > > URL: http://llvm.org/viewvc/llvm-project?rev=264071&view=rev > Log: > StaticAnalyzer: Avoid an unintentional copy > Jus

r264071 - StaticAnalyzer: Avoid an unintentional copy

2016-03-22 Thread Justin Bogner via cfe-commits
Author: bogner Date: Tue Mar 22 12:50:05 2016 New Revision: 264071 URL: http://llvm.org/viewvc/llvm-project?rev=264071&view=rev Log: StaticAnalyzer: Avoid an unintentional copy The range here isn't over references, so using `auto &` here incites a copy. Switching to `auto *` would do, but we migh