Re: r262275 - Infrastructure improvements to Clang attribute TableGen.

2016-02-29 Thread Sean Silva via cfe-commits
All green on the two latest commits. Thanks! http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/961 -- Sean Silva On Mon, Feb 29, 2016 at 6:14 PM, John McCall wrote: > On Feb 29, 2016, at 5:44 PM, Sean Silva wrote: > This seems to be causing a substantial

Re: r262275 - Infrastructure improvements to Clang attribute TableGen.

2016-02-29 Thread John McCall via cfe-commits
> On Feb 29, 2016, at 5:44 PM, Sean Silva wrote: > This seems to be causing a substantial amount of warning spew from MSVC: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/955 > >

Re: r262275 - Infrastructure improvements to Clang attribute TableGen.

2016-02-29 Thread Sean Silva via cfe-commits
This seems to be causing a substantial amount of warning spew from MSVC: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/955 I think our recommended "portable" method of using llvm_unreachable is outside the switch, instead of in the default case: http://l

r262275 - Infrastructure improvements to Clang attribute TableGen.

2016-02-29 Thread John McCall via cfe-commits
Author: rjmccall Date: Mon Feb 29 18:18:05 2016 New Revision: 262275 URL: http://llvm.org/viewvc/llvm-project?rev=262275&view=rev Log: Infrastructure improvements to Clang attribute TableGen. This should make it easier to add new Attr subclasses. Modified: cfe/trunk/include/clang/AST/Attr.h