Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-03-24 Thread Eric Christopher via cfe-commits
Great, thanks! On Thu, Mar 24, 2016, 5:26 PM Adrian Prantl wrote: > I added a testcase that demonstrates the problem with this commit in > r264366. > > -- adrian > > On Feb 23, 2016, at 11:07 AM, Eric Christopher > wrote: > > > > Thanks Adrian! > > > > On Tue, Feb 23, 2016 at 9:19 AM Adrian Pra

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-03-24 Thread Adrian Prantl via cfe-commits
I added a testcase that demonstrates the problem with this commit in r264366. -- adrian > On Feb 23, 2016, at 11:07 AM, Eric Christopher wrote: > > Thanks Adrian! > > On Tue, Feb 23, 2016 at 9:19 AM Adrian Prantl wrote: > --> r261657. > > Author: adrian > Date: Tue Feb 23 17:13:47 2016 +00

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-02-23 Thread Eric Christopher via cfe-commits
Thanks Adrian! On Tue, Feb 23, 2016 at 9:19 AM Adrian Prantl wrote: > --> r261657. > > Author: adrian > Date: Tue Feb 23 17:13:47 2016 + > > Remove an unnecessary workaround introduced in r259975. (NFC) > > Now that LLVM r259973 allows replacing a temporary type with another >

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-02-23 Thread Adrian Prantl via cfe-commits
--> r261657. Author: adrian Date: Tue Feb 23 17:13:47 2016 + Remove an unnecessary workaround introduced in r259975. (NFC) Now that LLVM r259973 allows replacing a temporary type with another temporary we can rely on the original implementation. It is possible for

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-02-22 Thread Eric Christopher via cfe-commits
Hi Adrian, On Sat, Feb 20, 2016 at 1:18 PM Adrian Prantl wrote: > This had me puzzled for a second, but then I figured out what happened :-) > The “crash” I quoted in the commit message really was an assertion > failure, to be precise, the very assertion I relaxed in LLVM r259973 in > order to b

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-02-20 Thread Adrian Prantl via cfe-commits
This had me puzzled for a second, but then I figured out what happened :-) The “crash” I quoted in the commit message really was an assertion failure, to be precise, the very assertion I relaxed in LLVM r259973 in order to be able to defer the building of the DeclContext implemented by this commi

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-02-19 Thread Eric Christopher via cfe-commits
Hi Adrian, I'm taking a look at this and can't duplicate using the testcase you gave without your patch(es) applied. It's also causing asserts in other code as you can have the forward decl left around and the CU isn't a valid context. Can you take a look/revert until you've got a different testc

r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-02-05 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Feb 5 19:59:09 2016 New Revision: 259975 URL: http://llvm.org/viewvc/llvm-project?rev=259975&view=rev Log: Fix a crash when emitting dbeug info for forward-declared scoped enums. It is possible for enums to be created as part of their own declcontext. We need to cache a p