Re: r259624 - Make CF constant string decl visible to name lookup to fix module errors

2016-02-03 Thread Ben Langmuir via cfe-commits
Hey Doug, I fixed this in r259734; could you take a glance at that patch too? As I mentioned in person it required more changes than just moving this definition outside the if/fixing the name. Thanks, Ben > On Feb 3, 2016, at 11:50 AM, Ben Langmuir via cfe-commits > wrote: > > >> On Feb 3

r259715 - Revert r259624 - Make CF constant string decl visible to name lookup to fix module errors.

2016-02-03 Thread Quentin Colombet via cfe-commits
Author: qcolombet Date: Wed Feb 3 16:14:53 2016 New Revision: 259715 URL: http://llvm.org/viewvc/llvm-project?rev=259715&view=rev Log: Revert r259624 - Make CF constant string decl visible to name lookup to fix module errors. This breaks some internal bots in stage2: clang seg fault. Loo

Re: r259624 - Make CF constant string decl visible to name lookup to fix module errors

2016-02-03 Thread Ben Langmuir via cfe-commits
> On Feb 3, 2016, at 11:45 AM, Douglas Gregor wrote: > >> >> On Feb 2, 2016, at 7:26 PM, Ben Langmuir via cfe-commits >> wrote: >> >> Author: benlangmuir >> Date: Tue Feb 2 21:26:19 2016 >> New Revision: 259624 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=259624&view=rev >> Log: >> M

Re: r259624 - Make CF constant string decl visible to name lookup to fix module errors

2016-02-03 Thread Douglas Gregor via cfe-commits
> On Feb 2, 2016, at 7:26 PM, Ben Langmuir via cfe-commits > wrote: > > Author: benlangmuir > Date: Tue Feb 2 21:26:19 2016 > New Revision: 259624 > > URL: http://llvm.org/viewvc/llvm-project?rev=259624&view=rev > Log: > Make CF constant string decl visible to name lookup to fix module errors

r259624 - Make CF constant string decl visible to name lookup to fix module errors

2016-02-02 Thread Ben Langmuir via cfe-commits
Author: benlangmuir Date: Tue Feb 2 21:26:19 2016 New Revision: 259624 URL: http://llvm.org/viewvc/llvm-project?rev=259624&view=rev Log: Make CF constant string decl visible to name lookup to fix module errors The return type of the __builtin___*StringMakeConstantString functions is a pointer to