On Fri, Jan 22, 2016 at 3:22 PM, Nico Weber wrote:
> Every time we accept something in MS mode that isn't standards compliant,
> we should accept it with a warning (for stuff that's harmless, an Extension
> warning, for stuff that can lead to bugs a Warning warning), unless it's
> really hard to
Every time we accept something in MS mode that isn't standards compliant,
we should accept it with a warning (for stuff that's harmless, an Extension
warning, for stuff that can lead to bugs a Warning warning), unless it's
really hard to implement.
(See also
https://docs.google.com/presentation/d/
Do you mean only a warning for the case this patch is handling, or also for
cases such as the second test case in
https://llvm.org/bugs/show_bug.cgi?id=25875#c1 too?
(I think it would probably be a good idea to warn in both cases.)
On Fri, Jan 22, 2016 at 2:39 PM, Nico Weber wrote:
> Is it poss
Is it possible to emit some -Wmicrosoft warning in cases where this is
necessary?
On Fri, Jan 22, 2016 at 2:26 PM, Ehsan Akhgari via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ehsan
> Date: Fri Jan 22 13:26:44 2016
> New Revision: 258530
>
> URL: http://llvm.org/viewvc/llvm-projec
Author: ehsan
Date: Fri Jan 22 13:26:44 2016
New Revision: 258530
URL: http://llvm.org/viewvc/llvm-project?rev=258530&view=rev
Log:
[MSVC Compat] Accept elided commas in macro function arguments
Summary:
This fixes PR25875. When the trailing comma in a macro argument list is
elided, we need to t
