Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Jan 5, 2016, at 6:56 PM, Richard Smith wrote: > > On Tue, Jan 5, 2016 at 1:32 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > > On Dec 16, 2015, at 5:19 PM, Bob Wilson via cfe-commits > > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Nov 12, 2015, at

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

On Tue, Jan 5, 2016 at 1:32 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Dec 16, 2015, at 5:19 PM, Bob Wilson via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Nov 12, 2015, at 2:19 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrot

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Dec 16, 2015, at 5:19 PM, Bob Wilson via cfe-commits > wrote: > >> >> On Nov 12, 2015, at 2:19 PM, Richard Smith via cfe-commits >> wrote: >> >> Author: rsmith >> Date: Thu Nov 12 16:19:45 2015 >> New Revision: 252960 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=252960&view=rev

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Nov 12, 2015, at 2:19 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Thu Nov 12 16:19:45 2015 > New Revision: 252960 > > URL: http://llvm.org/viewvc/llvm-project?rev=252960&view=rev > Log: > [modules] Simplify and generalize the existing rule for finding hidden > de

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Dec 9, 2015, at 2:49 PM, Richard Smith wrote: > > On Wed, Dec 9, 2015 at 2:00 PM, Ben Langmuir > wrote: > >> On Dec 9, 2015, at 1:36 PM, Richard Smith > > wrote: >> >> On Wed, Dec 9, 2015 at 11:55 AM, Ben Langmuir via cfe-commits

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

On Wed, Dec 9, 2015 at 2:00 PM, Ben Langmuir wrote: > > On Dec 9, 2015, at 1:36 PM, Richard Smith wrote: > > On Wed, Dec 9, 2015 at 11:55 AM, Ben Langmuir via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> > On Dec 9, 2015, at 11:07 AM, Ben Langmuir wrote: >> > >> > Hey Richard, >> > >

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Dec 9, 2015, at 1:36 PM, Richard Smith wrote: > > On Wed, Dec 9, 2015 at 11:55 AM, Ben Langmuir via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > > On Dec 9, 2015, at 11:07 AM, Ben Langmuir > > wrote: > > > > Hey Richard, > > > > This caused a new

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

On Wed, Dec 9, 2015 at 11:55 AM, Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Dec 9, 2015, at 11:07 AM, Ben Langmuir wrote: > > > > Hey Richard, > > > > This caused a new error for the following code: > > > >@import Foo.X; // declaration of ‘struct foo’ from Foo.Y

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Dec 9, 2015, at 11:07 AM, Ben Langmuir wrote: > > Hey Richard, > > This caused a new error for the following code: > >@import Foo.X; // declaration of ‘struct foo’ from Foo.Y is not visible > yet, but the pcm is loaded. >struct foo *bar; // declares ‘struct foo’ >@import Foo.

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

Hey Richard, This caused a new error for the following code: @import Foo.X; // declaration of ‘struct foo’ from Foo.Y is not visible yet, but the pcm is loaded. struct foo *bar; // declares ‘struct foo’ @import Foo.Y; // also declares ‘struct foo’ void useFoo(struct foo *x); //

r252960 - [modules] Simplify and generalize the existing rule for finding hidden

Author: rsmith Date: Thu Nov 12 16:19:45 2015 New Revision: 252960 URL: http://llvm.org/viewvc/llvm-project?rev=252960&view=rev Log: [modules] Simplify and generalize the existing rule for finding hidden declarations in redeclaration lookup. A declaration is now visible to lookup if: * It is vis