Re: r251284 - clang-format: Fix false positive in cast detection.

2015-10-26 Thread David Blaikie via cfe-commits
On Mon, Oct 26, 2015 at 9:43 PM, Daniel Jasper wrote: > If you look closely, there are multiple tests for different configuration > options. > Ah, I see one that's "( int, int )" now - cool, thanks! > The before/after is always just one example. > > On Tue, Oct 27, 2015 at 5:42 AM, David Blaik

Re: r251284 - clang-format: Fix false positive in cast detection.

2015-10-26 Thread Daniel Jasper via cfe-commits
If you look closely, there are multiple tests for different configuration options. The before/after is always just one example. On Tue, Oct 27, 2015 at 5:42 AM, David Blaikie wrote: > > > On Mon, Oct 26, 2015 at 9:21 PM, Daniel Jasper wrote: > >> I mixed up before and after. Other than that, I

Re: r251284 - clang-format: Fix false positive in cast detection.

2015-10-26 Thread David Blaikie via cfe-commits
On Mon, Oct 26, 2015 at 9:21 PM, Daniel Jasper wrote: > I mixed up before and after. Other than that, I don't see a typo. > It looks like the test case "+ verifyFormat("std::function< void(int, int) > fct;", Spaces);" ensures no spaces between the parameters and the () in the function type ("vo

Re: r251284 - clang-format: Fix false positive in cast detection.

2015-10-26 Thread Daniel Jasper via cfe-commits
I mixed up before and after. Other than that, I don't see a typo. On Mon, Oct 26, 2015 at 5:44 PM, David Blaikie wrote: > > > On Mon, Oct 26, 2015 at 5:08 AM, Daniel Jasper via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: djasper >> Date: Mon Oct 26 07:08:47 2015 >> New Revisi

Re: r251284 - clang-format: Fix false positive in cast detection.

2015-10-26 Thread David Blaikie via cfe-commits
On Mon, Oct 26, 2015 at 5:08 AM, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Mon Oct 26 07:08:47 2015 > New Revision: 251284 > > URL: http://llvm.org/viewvc/llvm-project?rev=251284&view=rev > Log: > clang-format: Fix false positive in cast detection

r251284 - clang-format: Fix false positive in cast detection.

2015-10-26 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Oct 26 07:08:47 2015 New Revision: 251284 URL: http://llvm.org/viewvc/llvm-project?rev=251284&view=rev Log: clang-format: Fix false positive in cast detection. Before (with spaces in parentheses): void inFunction() { std::function fct; } After: void inFunction() { s